Skip to content

[codex] Let machine fit override Podman default#192

Merged
8Dionysus merged 1 commit into
mainfrom
codex/podman-machine-fit-override
Jun 16, 2026
Merged

[codex] Let machine fit override Podman default#192
8Dionysus merged 1 commit into
mainfrom
codex/podman-machine-fit-override

Conversation

@8Dionysus

Copy link
Copy Markdown
Owner

Summary

  • Track whether AOA_PODMAN_CONTAINERS_ROOT was operator-provided before aoa-lib.sh computes its runtime-user fallback.
  • Allow machine-fit validated_settings.AOA_PODMAN_CONTAINERS_ROOT to override only that computed default.
  • Preserve explicit operator-provided Podman root values as stronger than machine-fit.

Why

Codex Review on PR #167 found that the computed default made AOA_PODMAN_CONTAINERS_ROOT look set before aoa_apply_machine_fit_runtime_posture, causing validated relocated rootless Podman storage roots to be silently ignored.

Validation

  • failing-before-fix: python -m pytest -q tests/test_aoa_lib_env_compat.py -k 'podman_root' failed because the computed /home/dionysus/.local/share/containers default masked machine-fit
  • python -m pytest -q tests/test_aoa_lib_env_compat.py -k 'podman_root'
  • python -m pytest -q tests/test_profile_topology_validator_module.py -k 'podman_container'
  • git diff --check
  • python -m pytest -q tests/test_aoa_lib_env_compat.py tests/test_profile_topology_validator_module.py
  • python scripts/validate_stack.py
  • python scripts/validate_nested_agents.py
  • python scripts/ci_gate.py --mode source-fast
  • shellcheck scripts/aoa-lib.sh
  • aoa checkpoint review-note /home/dionysus/src/abyss-stack --commit-ref 9820d8c108d635e3f50de3af3729d91aa9a026c3 --auto --root /srv/AbyssOS

@8Dionysus 8Dionysus marked this pull request as ready for review June 16, 2026 04:16
@8Dionysus 8Dionysus merged commit c01a359 into main Jun 16, 2026
4 checks passed
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@8Dionysus 8Dionysus deleted the codex/podman-machine-fit-override branch June 16, 2026 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant