[codex] Let machine fit override Podman default#192
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AOA_PODMAN_CONTAINERS_ROOTwas operator-provided beforeaoa-lib.shcomputes its runtime-user fallback.validated_settings.AOA_PODMAN_CONTAINERS_ROOTto override only that computed default.Why
Codex Review on PR #167 found that the computed default made
AOA_PODMAN_CONTAINERS_ROOTlook set beforeaoa_apply_machine_fit_runtime_posture, causing validated relocated rootless Podman storage roots to be silently ignored.Validation
python -m pytest -q tests/test_aoa_lib_env_compat.py -k 'podman_root'failed because the computed/home/dionysus/.local/share/containersdefault masked machine-fitpython -m pytest -q tests/test_aoa_lib_env_compat.py -k 'podman_root'python -m pytest -q tests/test_profile_topology_validator_module.py -k 'podman_container'git diff --checkpython -m pytest -q tests/test_aoa_lib_env_compat.py tests/test_profile_topology_validator_module.pypython scripts/validate_stack.pypython scripts/validate_nested_agents.pypython scripts/ci_gate.py --mode source-fastshellcheck scripts/aoa-lib.shaoa checkpoint review-note /home/dionysus/src/abyss-stack --commit-ref 9820d8c108d635e3f50de3af3729d91aa9a026c3 --auto --root /srv/AbyssOS