[codex] Allow session-relative freshness refs#190
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
needs_session_contextfreshness checks as non-failing while keeping the status visible in MCP freshness output.aoa_session_evidence_packetwith session-relativeraw:line:*refs and no session context.Why
Codex Review on PR #172 flagged that automatic evidence packets can gather valid session-relative raw refs without a session and should not report
freshness.ok=falsesolely because those refs need session context.Validation
freshness.ok=falsestate.git diff --checkpython -m pytest -q mcp/services/aoa-session-memory-mcp/tests/test_session_memory_mcp.py -k 'evidence_packet_combines_trace_search_retrieve_and_freshness or evidence_packet_does_not_fail_session_relative_raw_refs_without_session'python mcp/services/aoa-session-memory-mcp/scripts/validate_session_memory_mcp.pypython -m pytest mcp/services/aoa-session-memory-mcp/tests -qpython mcp/services/aoa-session-memory-mcp/scripts/release_check.pypython mcp/services/tos-corpus-mcp/scripts/validate_tos_corpus_mcp.pypython -m pytest mcp/services/tos-corpus-mcp/tests -qpython scripts/validate_stack.pypython scripts/validate_nested_agents.pypython scripts/ci_gate.py --mode source-fastpython scripts/release_check.pyRisk
Low: MCP read-only access-plane behavior only; invalid, missing, unknown, or outside-AoA-root refs remain hard freshness failures.