Repository navigation
Smoke-test releases against LavinMQ main - #8
Merged
Merged
Conversation
The release workflow smoke-tested the binary against cloudamqp/lavinmq:latest, the last LavinMQ release. When the suite follows a fix on LavinMQ main, that release still has the old behaviour, so the smoke test fails and nothing is published, while LavinMQ's CI waits for the release (#4). The cloudamqp/lavinmq:main image is built from LavinMQ main, which is what LavinMQ's CI pins QC_VERSION for. Closes #4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
release.ymlsmoke-tests the binary againstcloudamqp/lavinmq:latest, the last LavinMQ release. When the suite follows a fix on LavinMQ main, that release still has the old behaviour, so the smoke test fails and nothing is published. LavinMQ's CI pinsQC_VERSION, so it can't go green until the release exists (#4).That is the case now: #5 expects the MQTT wildcard fixes from cloudamqp/lavinmq#2377, which are on main but not in v2.10.2.
What
cloudamqp/lavinmq:main, the image built from LavinMQ mainTest plan
release.ymlon main (againstlatest): fails onmqtt_hash_matches_parent_level,mqtt_new_subscription_gets_retainedandmqtt_wildcards_skip_dollar_topicsrelease.ymlon this branch (againstmain): passesCloses #4