Skip to content

DOC: Correct WURFL mapping table descriptions, continuation markers and dictionary links - #225

Open
jwrosewell wants to merge 1 commit into
mainfrom
fix/147-wurfl-mapping-table
Open

DOC: Correct WURFL mapping table descriptions, continuation markers and dictionary links#225
jwrosewell wants to merge 1 commit into
mainfrom
fix/147-wurfl-mapping-table

Conversation

@jwrosewell

Copy link
Copy Markdown
Contributor

Closes #147

Corrects the Mapped table in the WURFL migration guide, using the property definitions in the public 51Degrees/common-metadata repository (Properties/*.json) as the source of truth for property descriptions and dictionary categories. The Obsolete table is untouched, and the mapping sanity checks in the issue that need a Data Team conversation (the advertised_app_name and AMR items) are deliberately left alone.

16 rows corrected in total, listed below by group.

Wrong descriptions (text copied from a different property)

Row Before After
is_full_desktop (cont.) -> IsDesktop The IsCrawler boilerplate ("Indicates if the source of the web traffic operates without human interaction, primarily for the purpose of indexing the response...") "Indicates if the device is a desktop computer. This property will return 'False' for mobile devices such as smartphones or tablets."
ux_full_desktop -> IsDesktop Same IsCrawler boilerplate Same replacement text as above
jqm_grade -> jQueryMobileSupport The JavascriptVersion boilerplate ("Indicates which JavaScript version the browser uses. The number refers to JavaScript versioning, not ECMAscript or Jscript...") The jQueryMobileSupport description from common-metadata, "Refers to the grade of the level the device has with the jQuery Mobile Framework, as posted by jQuery."

Note for reviewers, IsDesktop has no definition in common-metadata (there is no IsDesktop.json under Properties/), so the replacement wording is written to match the style of the neighbouring device-type rows rather than quoted from metadata. Please confirm the wording, and whether IsDesktop is still the right mapped property, before merge.

Missing (cont.) continuation markers on duplicate WURFL names

Row Before After
preferred_markup (second row, Html5) preferred_markup preferred_markup (cont.)
ux_full_desktop (second row, DeviceType) ux_full_desktop ux_full_desktop (cont.)
svgt_1_1 (second row, Svg) svgt_1_1 svgt_1_1 (cont.)

The svgt_1_1 row was not listed in the issue but has the identical defect (the sibling svgt_1_1_plus pair already carries the marker), so it is included here.

Two properties bundled into one cell

Each of these cells carried a second linked property with its description hidden in a link tooltip, whilst the very next (cont.) row already listed that same property on its own. The second link is removed so each row now holds exactly one property, matching the rest of the table.

Row Before After
canvas_support CssCanvas + Html5 (tooltip) CssCanvas only (Html5 keeps its own (cont.) row)
density_class (cont.) ScreenInchesWidth + ScreenPixelsWidth (tooltip, and a broken Device|Screenh link) ScreenInchesWidth only (ScreenPixelsWidth keeps its own (cont.) row)
dual_orientation DeviceType + DeviceOrientation (tooltip) DeviceType only (DeviceOrientation keeps its own (cont.) row)
pointing_method (cont.) HasTrackPad + HasTouchScreen (tooltip), leaving HasTouchScreen listed twice HasTrackPad only (HasTouchScreen keeps its own (cont.) row)
preferred_markup HtmlVersion + Html5 (tooltip) HtmlVersion only (Html5 keeps its own (cont.) row)

Property-dictionary deep-link category corrections

Categories taken from the Category field of each property's JSON in common-metadata.

Row Before After
is_bot -> IsCrawler Device|Name Bots|All (matches the sibling is_robot row)
is_tablet -> IsTablet Device|Name Device|Device
is_wireless_device -> IsMobile Device|Name Device|Device
mobile_browser -> BrowserName Device|Name WebBrowserandApps|Name
mobile_browser_version -> BrowserVersion Device|Name WebBrowserandApps|Name

The mobile_browser row was not listed in the issue but had the same wrong component as its version sibling, so it is included.

Two of the issue's suggested URL changes are deliberately not made. The issue guessed advertised_browser_version and advertised_device_os_version should link to a Version category, but BrowserVersion and PlatformVersion both have "Category": "Name" in common-metadata, and no Version category exists there, so the current links already match the metadata and are left unchanged.


This pull request was produced with AI assistance as part of a 5th August 2026 housekeeping sweep. It needs human review, ideally with a Data Team eye on the IsDesktop wording, before merge.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Documentation preview 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WURFL migration guide: mapping-table accuracy follow-up

1 participant