DOC: Correct WURFL mapping table descriptions, continuation markers and dictionary links - #225
Open
jwrosewell wants to merge 1 commit into
Open
DOC: Correct WURFL mapping table descriptions, continuation markers and dictionary links#225jwrosewell wants to merge 1 commit into
jwrosewell wants to merge 1 commit into
Conversation
…nd dictionary links (#147)
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #147
Corrects the Mapped table in the WURFL migration guide, using the property definitions in the public 51Degrees/common-metadata repository (
Properties/*.json) as the source of truth for property descriptions and dictionary categories. The Obsolete table is untouched, and the mapping sanity checks in the issue that need a Data Team conversation (theadvertised_app_nameand AMR items) are deliberately left alone.16 rows corrected in total, listed below by group.
Wrong descriptions (text copied from a different property)
is_full_desktop (cont.)-> IsDesktopux_full_desktop-> IsDesktopjqm_grade-> jQueryMobileSupportNote for reviewers, IsDesktop has no definition in common-metadata (there is no
IsDesktop.jsonunderProperties/), so the replacement wording is written to match the style of the neighbouring device-type rows rather than quoted from metadata. Please confirm the wording, and whether IsDesktop is still the right mapped property, before merge.Missing
(cont.)continuation markers on duplicate WURFL namespreferred_markup(second row, Html5)preferred_markuppreferred_markup (cont.)ux_full_desktop(second row, DeviceType)ux_full_desktopux_full_desktop (cont.)svgt_1_1(second row, Svg)svgt_1_1svgt_1_1 (cont.)The
svgt_1_1row was not listed in the issue but has the identical defect (the siblingsvgt_1_1_pluspair already carries the marker), so it is included here.Two properties bundled into one cell
Each of these cells carried a second linked property with its description hidden in a link tooltip, whilst the very next
(cont.)row already listed that same property on its own. The second link is removed so each row now holds exactly one property, matching the rest of the table.canvas_support(cont.)row)density_class (cont.)Device|Screenhlink)(cont.)row)dual_orientation(cont.)row)pointing_method (cont.)(cont.)row)preferred_markup(cont.)row)Property-dictionary deep-link category corrections
Categories taken from the
Categoryfield of each property's JSON in common-metadata.is_bot-> IsCrawlerDevice|NameBots|All(matches the siblingis_robotrow)is_tablet-> IsTabletDevice|NameDevice|Deviceis_wireless_device-> IsMobileDevice|NameDevice|Devicemobile_browser-> BrowserNameDevice|NameWebBrowserandApps|Namemobile_browser_version-> BrowserVersionDevice|NameWebBrowserandApps|NameThe
mobile_browserrow was not listed in the issue but had the same wrong component as its version sibling, so it is included.Two of the issue's suggested URL changes are deliberately not made. The issue guessed
advertised_browser_versionandadvertised_device_os_versionshould link to aVersioncategory, but BrowserVersion and PlatformVersion both have"Category": "Name"in common-metadata, and noVersioncategory exists there, so the current links already match the metadata and are left unchanged.This pull request was produced with AI assistance as part of a 5th August 2026 housekeeping sweep. It needs human review, ideally with a Data Team eye on the IsDesktop wording, before merge.