Add Maven wrapper pinned to Maven 3.9.16 - #640
Open
jwrosewell wants to merge 1 commit into
Open
Conversation
Adds mvnw, mvnw.cmd and .mvn/wrapper/maven-wrapper.properties (Maven Wrapper 3.3.4, script-only type) so the examples can be built without a system Maven install. Use ./mvnw (or mvnw.cmd on Windows) as a drop-in replacement for mvn. A .gitattributes entry keeps mvnw on LF and mvnw.cmd on CRLF so both scripts run correctly on any checkout. Closes #610
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
This repo had no committed Maven wrapper, so it could not be built on a machine without a system Maven install. Issue #610 records that during local cross-platform verification the Java examples were the only stack that could not be compiled locally, which made the nightly CI dashboard the first real compile for any change.
What was added
The standard Maven wrapper files at the repo root, generated from the official Maven Wrapper 3.3.4 distribution (script-only type, no jar committed).
mvnw(POSIX shell script, committed with the executable bit set)mvnw.cmd(Windows script).mvn/wrapper/maven-wrapper.propertiespinning Apache Maven 3.9.16 (the latest 3.9.x release, chosen because the CI scripts do not pin a Maven version themselves and rely on the runner's pre-installed Maven 3.9.x).gitattributeswith two entries that keepmvnwon LF andmvnw.cmdon CRLF so both scripts run correctly whatever the checkout platform's line-ending settings areNo existing file is modified and there is no runtime behaviour change. Anyone can now build with
./mvnw(ormvnw.cmdon Windows) as a drop-in replacement formvn.How it was verified
On a Windows 11 machine with JDK 21 and no system Maven installed, both
./mvnw --version(Git Bash) and.\mvnw.cmd --version(Windows shell) downloaded Apache Maven 3.9.16 on first run and reported it correctly../mvnw -B compile -pl sharedthen compiled thesharedmodule successfully (BUILD SUCCESS, classes produced undershared/target/classes). The committed blobs were checked to be stored with LF endings andmvnwis tracked with mode 100755.Review note
This change was produced with AI assistance as part of a 5th August 2026 housekeeping sweep and needs human review before merge.
Closes #610