DOCS: Add native access flag to example run commands - #634
Open
oleksandrlazarenko-pi wants to merge 3 commits into
Open
DOCS: Add native access flag to example run commands#634oleksandrlazarenko-pi wants to merge 3 commits into
oleksandrlazarenko-pi wants to merge 3 commits into
Conversation
Documents --enable-native-access=ALL-UNNAMED for the fat-jar examples and the module path alternative, per 51Degrees/device-detection-java#476.
justadreamer
marked this pull request as ready for review
August 5, 2026 11:37
justadreamer
self-requested a review
August 5, 2026 11:37
Explains that a fat jar can only use ALL-UNNAMED, since everything inside it is part of the unnamed module, and points at the individual-jar layout that can be narrowed. Per 51Degrees/device-detection-java#476.
oleksandrlazarenko-pi
marked this pull request as draft
August 5, 2026 12:36
justadreamer
marked this pull request as ready for review
August 5, 2026 18:19
The snippet had no goal or executable. exec:java runs in the Maven JVM and passes <arguments> to main, so --enable-native-access there is silently ignored; only exec:exec with <executable>java</executable> forks a JVM that takes the flag. The run commands used Windows-style backslashes inside a bash fence, where they are escapes rather than separators.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation half of 51Degrees/device-detection-java#476.
The on-premise examples use a native library, and
JEP 472 restricts the operations needed to load it.
Java 24 and 25 warn once per calling module, and a later release will refuse the call.
Extends Running built examples from command line with a Native library access
subsection:
--enable-native-access=ALL-UNNAMED, shown on the existing example command;of the unnamed module, with a pointer to the device-detection-java README for the
individual-jar layout that can.
No code changes.
Depends on the companion pipeline-java and device-detection-java PRs, which add the
README sections this one links to; merge those first.