fix pagination on external sources#62
Open
floriangantner wants to merge 11 commits into4Science:dspace-cris-2023_02_xfrom
Open
fix pagination on external sources#62floriangantner wants to merge 11 commits into4Science:dspace-cris-2023_02_xfrom
floriangantner wants to merge 11 commits into4Science:dspace-cris-2023_02_xfrom
Conversation
[DSC-1408] - Fix dropdown readonly field Approved-by: Andrea Barbasso
# Conflicts: # src/config/default-app-config.ts # src/environments/environment.test.ts
[DSC-1352] Move breadcrumb char limit property inside layout configuration properties Approved-by: Andrea Barbasso
DSC-1037 Approved-by: Giuseppe Digilio
[DSC-1430] Add missing labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
Set the paginationId on external sources lists. Otherwise the pagination should not work.
Instructions for Reviewers
List of changes in this PR:
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
yarn lintyarn check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.