Draft: Enhancement nameenhancer

[floriangantner]

References

Add references/links to any related issues or PRs. These may include:
based on the NameEnhancer implementation of #312

Description

• add some Enhancer which sets the dc.title based on a list of other metadatavalues (e.g. crisrp.name, crisrp.variants). This is helpful for repositories which set some displayName bases on the values and preferences of other metadatavalue

• Known Restrictions:

  • creating new ResearcherProfiles might not work. It could be necessary to add dc.title as the last element of the metadatavalues as fallback (not tested but came in mind while writing this lines) or set the name metadata explicitly in the Researcher Profile Creation

    DSpace/dspace-api/src/main/java/org/dspace/profile/ResearcherProfileServiceImpl.java

    Line 311 in 029adbc

    itemService.addMetadata(context, item, "dc", "title", null, null, fullName);

  • created Entities through cris consumer might have no title. It could be necessary to add dc.title as the last element of the metadatavalues as fallback (not tested) or change the template of the crisconsumer or add the name field for certain entity types bases on the metadata value

    DSpace/dspace-api/src/main/java/org/dspace/authority/CrisConsumer.java

    Line 259 in 029adbc

    Item relatedItem = workspaceItem.getItem();

Instructions for Reviewers

• Some own integration tests depending on the enhancer type would be nice, not testing the whole enhancer :)
• Still working on tests. Some other integration tests fail because of the enhancer

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & integration tests). Exceptions may be made if previously agreed upon.
• My PR passes Checkstyle validation based on the Code Style Guide.
• My PR includes Javadoc for all new (or modified) public methods and classes. It also includes Javadoc for large or complex private methods.
• My PR passes all tests and includes new/updated Unit or Integration Tests based on the Code Testing Guide.
• If my PR includes new libraries/dependencies (in any pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
• If my PR modifies REST API endpoints, I've opened a separate REST Contract PR related to this change.
• If my PR includes new configurations, I've provided basic technical documentation in the PR itself.
• If my PR fixes an issue ticket, I've linked them together.

[github-actions]

This pull request has been automatically marked as stale because it has not had
activity in one year. It will be closed in 14 days if no further activity occurs.

Allowing pull requests to close as stale helps us filter out old work that is no longer
relevant and helps developers focus on reviewing current work.

All pull requests closed by this bot act like normal pull requests;
they can be searched for, commented on or reopened at any point.

If these changes are still relevant then please comment and/or rebase your PR based on the
latest DSpace code. This will remove the stale status and notify us to assign a reviewer
for your PR.

[github-actions]

This pull request has been closed automatically. If these changes are still relevant
then please re-open this pull request with a comment and rebase your PR based on the latest
DSpace code. This will notify us to assign a reviewer to your PR.