refactor: use CodeBuilder#189
Conversation
|
Just a quick aside - but I'd recommend switching over to using projects (i.e. defined by a I'm hoping to expand |
|
+1 on landing this as the official guidance. I did a very similar migration on #192 last week while fixing tutorial issues from #191 and converged on the same shape, so independent confirmation it's the right move. @bitwalker I'm bought on project-assembler as the destination, just not for tutorials in this iteration. Couldn't find any Happy to take a fresh PR at it once Should we open an issue for this? |
|
@Keinberger That's fine as a temporary step, the next compiler release already supports compilation of both Rust and MASM projects (and mixed projects), so at that point, I do want to give you a heads up that I'm aiming for a state, ASAP, where the I want to give you that heads up so that the process of shifting things that direction can start sooner rather than later, but until the 0.23.x VM release has shipped all the way to devnet/testnet, we're not quite there yet (though I think that's supposed to happen this week/next).
The compiler has various examples of this (or at least the branch which adds project support does, but that should be merged later tonight). That said, I was anticipating that project stuff would be documented as part of the main Miden docs (and here in the form of tutorials) - but if there are specific documentation aspects missing in the
That's incorrect - the
Sure, that's fine. Ultimately we want people using |
I think #187 got closed when the base branch got merged.
Official guidance should be to utilize the
CodeBuilder, which is also provided byClient. Recently mixing source managers in assemblers started resulting in internal panics (0xMiden/miden-vm#2778), so we need to make guidance as consistent as possible. This also simplifies code a bunch. cc @Keinberger @BrianSeong99Closes #188.