Skip to content

mcvs_review: full review of main @ a276963 #71

Description

@sbp-bvanb

Full review of main at a276963 (no PR; reviewed against the empty tree).

Findings

Updated for main @ e1ec2fd: #62, #63, #69 and #70 are closed; the dependabot nit is reworded.

Nits

  • .gitignore:2: only update-branch-protection-rule.json is ignored; add update-actions-permissions.json and update-actions-selected-actions.json (written by main.py:74,85).
  • pyproject.toml:19: types-requests is a dev dependency but requests is never imported. Remove it.
  • .github/dependabot.yml (preference, not a CI failure): Dependabot commits use the build(...) type, which lint-commit accepts (build(deps-dev): bump the pip-all group across 1 directory with 4 updates #60). Add commit-message: {prefix: chore} per ecosystem only if chore is preferred.

Clean

  • github-actions-reviewer: ✅ all 6 uses: references pinned to full SHAs with exact-release comments.

Generated by mcvs_review 3.1.0 (pr-reviewer, doc-reviewer, dependency-reviewer, github-actions-reviewer) at commit a276963.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions