Repository navigation
ci(e2e): run the unlicensed e2e tests in every E2E job - #6017
Conversation
Only the WCP jobs ran anything in e2e/ past the installation test, and those only run for the people in AI_E2E_USERS. So the login test ran for nobody else, on /e2e or on push. Every other E2E job, AWS and standalone, /e2e and push, now runs `yarn e2e --exclude-tag wcp,ai,installation --pass-with-no-tests` after the installation test, and uploads e2e/.e2e/ if it fails. Today that is the login test. The WCP jobs keep their own run, which already covers these tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
🚓 Slop Cop ✅ Nothing worth flagging. The diff looks consistent with the PR's stated intent and the code-style rules. The PR coherently adds an unlicensed-e2e-test step to all non-WCP e2e jobs, matching its stated intent, with no integrity or style issues found. Automated, non-blocking heads-up from an LLM. It can be wrong — use your judgment. Regenerates on every push. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
Only the WCP jobs ran anything in
e2e/after the installation test, and those jobs only run when someone inAI_E2E_USERSposts/e2e. For everyone else, and on every push tonext, the login test never ran. Each job proved that a fresh project installs, and nothing more.Every other E2E job now runs one more step after the installation test. That covers the AWS DDB and DDB+OS jobs and the standalone SQLite and Postgres jobs, both in
/e2eand on push:login.e2e.ts, which signs in as the admin the installation test created and checks the dashboard loads.aiis excluded along withwcp. These jobs have noANTHROPIC_API_KEY, so a test taggedaibut notwcpwould fail withMODEL_UNAVAILABLE.--pass-with-no-testskeeps the step green if the filter ever selects nothing, instead of failing withNO_TESTS.e2e/.e2e/(report, screenshots, traces) ase2e-test-results-<variant>.yarn e2e --exclude-tag installationrun already includes these tests.The step lives in
.github/workflows/wac/e2e/unlicensedE2e.ts, next to the installation test step.e2e/README.mddescribes the new CI order and notes that a test withoutwcporainow runs in every job.Tested: against a freshly built standalone project on an empty SQLite database, the installation test passed, then this exact command ran the login test and it passed. The AWS jobs haven't run it yet;
/e2eon this PR covers them.Workspace: wby-next5 · 🧪 port admin install e2e
🤖 Generated with Claude Code
Summary by CodeRabbit