From 830b9e93243b494b1da687395877c08cf9ebfa4f Mon Sep 17 00:00:00 2001 From: Joe Isaacs Date: Fri, 13 Mar 2026 17:18:09 +0000 Subject: [PATCH 1/2] new bench --- .github/workflows/bench-pr.yml | 2 +- .github/workflows/bench.yml | 2 +- .github/workflows/nightly-bench.yml | 2 +- .github/workflows/sql-benchmarks.yml | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/bench-pr.yml b/.github/workflows/bench-pr.yml index 9787832cf48..7092e55d4ab 100644 --- a/.github/workflows/bench-pr.yml +++ b/.github/workflows/bench-pr.yml @@ -38,7 +38,7 @@ jobs: timeout-minutes: 120 runs-on: >- ${{ github.repository == 'vortex-data/vortex' - && format('runs-on={0}/runner=bench-dedicated/tag={1}{2}', github.run_id, matrix.benchmark.id, github.event.pull_request.head.repo.fork == false && '/extras=s3-cache' || '') + && format('runs-on={0}/runner=bench-dedicated-2/tag={1}{2}', github.run_id, matrix.benchmark.id, github.event.pull_request.head.repo.fork == false && '/extras=s3-cache' || '') || 'ubuntu-latest' }} strategy: matrix: diff --git a/.github/workflows/bench.yml b/.github/workflows/bench.yml index 5f879b5e8e4..10beccfa778 100644 --- a/.github/workflows/bench.yml +++ b/.github/workflows/bench.yml @@ -35,7 +35,7 @@ jobs: timeout-minutes: 120 runs-on: >- ${{ github.repository == 'vortex-data/vortex' - && format('runs-on={0}/runner=bench-dedicated/extras=s3-cache/tag={1}', github.run_id, matrix.benchmark.id) + && format('runs-on={0}/runner=bench-dedicated-2/extras=s3-cache/tag={1}', github.run_id, matrix.benchmark.id) || 'ubuntu-latest' }} strategy: matrix: diff --git a/.github/workflows/nightly-bench.yml b/.github/workflows/nightly-bench.yml index d207291c16c..123f8ae250a 100644 --- a/.github/workflows/nightly-bench.yml +++ b/.github/workflows/nightly-bench.yml @@ -73,7 +73,7 @@ jobs: matrix: machine_type: - id: x86 - instance_name: c6id.8xlarge + instance_name: c8id.8xlarge # TODO(joe): support other arch # - id: arm64 # instance_name: c6gd.8xlarge diff --git a/.github/workflows/sql-benchmarks.yml b/.github/workflows/sql-benchmarks.yml index e6bb11da945..a33674c6224 100644 --- a/.github/workflows/sql-benchmarks.yml +++ b/.github/workflows/sql-benchmarks.yml @@ -9,7 +9,7 @@ on: machine_type: required: false type: string - default: c6id.8xlarge + default: c8id.8xlarge benchmark_matrix: required: false type: string @@ -107,7 +107,7 @@ jobs: runs-on: >- ${{ github.repository == 'vortex-data/vortex' - && format('runs-on={0}/runner=bench-dedicated/tag={1}{2}', github.run_id, matrix.id, (inputs.mode != 'pr' || github.event.pull_request.head.repo.fork == false) && '/extras=s3-cache' || '') + && format('runs-on={0}/runner=bench-dedicated-2/tag={1}{2}', github.run_id, matrix.id, (inputs.mode != 'pr' || github.event.pull_request.head.repo.fork == false) && '/extras=s3-cache' || '') || 'ubuntu-latest' }} steps: - uses: runs-on/action@v2 From f0d3e8f8e3d9eb886aa07a5509fedf657aac6f99 Mon Sep 17 00:00:00 2001 From: Joe Isaacs Date: Fri, 13 Mar 2026 17:53:31 +0000 Subject: [PATCH 2/2] Remove unused machine_type input from benchmark workflows Signed-off-by: Joe Isaacs Co-Authored-By: Claude Opus 4.6 --- .github/workflows/nightly-bench.yml | 11 ----------- .github/workflows/sql-benchmarks.yml | 4 ---- 2 files changed, 15 deletions(-) diff --git a/.github/workflows/nightly-bench.yml b/.github/workflows/nightly-bench.yml index 123f8ae250a..7c3ac0b3f34 100644 --- a/.github/workflows/nightly-bench.yml +++ b/.github/workflows/nightly-bench.yml @@ -22,7 +22,6 @@ jobs: secrets: inherit with: mode: "develop" - machine_type: ${{ matrix.machine_type.instance_name }} # datafusion:vortex uses a lot of memory benchmark_matrix: | [ @@ -67,13 +66,3 @@ jobs: "scale_factor": "100.0" }, ] - strategy: - # A single run not should kill the others - fail-fast: false - matrix: - machine_type: - - id: x86 - instance_name: c8id.8xlarge -# TODO(joe): support other arch -# - id: arm64 -# instance_name: c6gd.8xlarge diff --git a/.github/workflows/sql-benchmarks.yml b/.github/workflows/sql-benchmarks.yml index a33674c6224..911746a09b5 100644 --- a/.github/workflows/sql-benchmarks.yml +++ b/.github/workflows/sql-benchmarks.yml @@ -6,10 +6,6 @@ on: mode: required: true type: string - machine_type: - required: false - type: string - default: c8id.8xlarge benchmark_matrix: required: false type: string