Skip to content

Ensure integration tests cover nrepl startup #186

Description

@trptcolin

In a recent change, lein trampoline run failed, but the test suite didn't catch it (😿) because the nrepl integration spec currently attaches to an nREPL server that's spun up in setup, then uses :attach.

This leaves the nrepl integration under-exercised by tests, which is now an issue due to the more active development and potential breaking changes there.

I'd be happy with another few tests like the existing ones, but run without the :attach assumption, where the server can be spun up inline. If necessary (due to port assumptions, TravisCI, or whatever), they could be done in a bash script instead of in clojure-land.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions