Lower unused plugin envvar messages from warning to debug log level#4969
Lower unused plugin envvar messages from warning to debug log level#4969AthreyVinay wants to merge 1 commit into
Conversation
AthreyVinay
added
code | logging
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request downgrades the logging level for unused or missing plugin environment variables from warning to debug in tmt/steps/__init__.py. The corresponding CLI tests in tests/cli/plugin-envvars/test.sh are updated to assert the presence of these messages in the log file instead of checking for warnings in the standard run log. No review comments were provided.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
tcornell-bus
left a comment
tcornell-bus
left a comment
There was a problem hiding this comment.
default debug level=1 seems correct and looks like these were the only two warning spots added in pr #4472
tcornell-bus
added
the
ci | full test
|
/packit test |
| rlRun -s "TMT_PLUGIN_REPORT_XHTML_DISPLAY_GUEST=never $run_tmt" | ||
|
|
||
| rlAssertGrep "warn: Found environment variable for plugin 'report/xhtml', but the plugin was not found. The following environment variable will have no effect: TMT_PLUGIN_REPORT_XHTML_DISPLAY_GUEST" $rlRun_LOG | ||
| rlAssertGrep "Found environment variable for plugin 'report/xhtml', but the plugin was not found. The following environment variable will have no effect: TMT_PLUGIN_REPORT_XHTML_DISPLAY_GUEST" $rundir/log.txt |
5 participants
Resolves #4955