Skip to content

fix: add pcre2 and libyaml to macos install script#1360

Merged
brendan-kellam merged 1 commit into
sourcebot-dev:mainfrom
dsabsay:fix-macos-deps
Jun 23, 2026
Merged

fix: add pcre2 and libyaml to macos install script#1360
brendan-kellam merged 1 commit into
sourcebot-dev:mainfrom
dsabsay:fix-macos-deps

Conversation

@dsabsay

@dsabsay dsabsay commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Fixes #1359.

This install script failed for me the first time I think because I had old x86_64 installs of these dependencies. Installing ARM versions fixed the issue.

Summary by CodeRabbit

  • Chores
    • Updated macOS installer script to include additional Homebrew build dependencies for enhanced compatibility and stability during installation.

@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2d35ea6a-bb99-440d-8355-e731db62cf91

📥 Commits

Reviewing files that changed from the base of the PR and between 7c127b9 and cb27bca.

📒 Files selected for processing (1)
  • install-ctags-macos.sh

Walkthrough

The macOS ctags installer script adds pcre2 and libyaml to the Homebrew dependency installation command, expanding the list from autoconf automake pkg-config jansson to also include these two libraries before building universal-ctags v6.1.0.

Changes

macOS ctags build dependency fix

Layer / File(s) Summary
Expand Homebrew build dependencies
install-ctags-macos.sh
pcre2 and libyaml added to the brew install command that runs before the universal-ctags build.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • sourcebot-dev/sourcebot#1023: Introduces install-ctags-macos.sh with the initial Homebrew dependency list that this PR extends with pcre2 and libyaml.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: add pcre2 and libyaml to macos install script' directly matches the main change in the PR, which adds these two dependencies to the macOS installation script.
Linked Issues check ✅ Passed The PR fully addresses issue #1359 by adding pcre2 and libyaml to the install-ctags-macos.sh script's dependency list, resolving the architecture mismatch linker errors.
Out of Scope Changes check ✅ Passed All changes are scoped to resolving the linker error issue by adding the required dependencies; no unrelated modifications are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@brendan-kellam brendan-kellam left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thx!

@brendan-kellam brendan-kellam merged commit 889e2b1 into sourcebot-dev:main Jun 23, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] macOS development requires pcre2 and libyaml

2 participants