Replace deprecated TypeORM findByIds calls in RolesService

[RUKAYAT-CODER]

Overview

RolesService.createRole() and RolesService.updateRole() both call this.permissionRepository.findByIds(permissionIds). findByIds is deprecated in TypeORM 0.3 (the project is on ^0.3.28) and scheduled for removal; the supported form is find({ where: { id: In(ids) } }). Beyond the deprecation, neither call verifies that the returned set matches the requested ids — passing a non-existent permission id silently yields a role with fewer permissions than the caller asked for, and the API returns 200 as though the full set were applied.

Specifications

Features:

• Permission lookups use the supported In() operator.
• A request naming an unknown permission id fails rather than partially applying.

Tasks:

• Replace both findByIds calls with find({ where: { id: In(permissionIds) } }).
• Compare the returned count against the requested count and throw BadRequestException naming the missing ids when they differ.
• Sweep the codebase for other findByIds usages and migrate them.
• Add tests covering a valid id set and a set containing an unknown id.

Impacted Files:

• src/rbac/roles/roles.service.ts

Acceptance Criteria

• No findByIds call remains in the codebase.
• A request with an unknown permission id returns 400 identifying it.
• Role permission assignment is all-or-nothing.

[Tobiloba0]

@Tobiloba0 has applied to work on this issue as part of the Stellar Wave Program's 7th wave.

Hi maintainer, I would like to work on this issue.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Tobiloba0 to this issue.

[emynogithub]

@emynogithub has applied to work on this issue as part of the Stellar Wave Program's 7th wave.

I can do the Job . please assign to me

ℹ️ Repo Maintainers: To accept this application, review their application or assign @emynogithub to this issue.

[Chrisland58]

@Chrisland58 has applied to work on this issue as part of the Stellar Wave Program's 7th wave.

Hi maintainer I will like to work on this issue please

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Chrisland58 to this issue.

[mijinummi]

@mijinummi has applied to work on this issue as part of the Stellar Wave Program's 7th wave.

Hello maintainers I'm a full stack developer experience in building scalable systems I can handle this perfectly

ℹ️ Repo Maintainers: To accept this application, review their application or assign @mijinummi to this issue.

[drips-wave]

Congratulations, @mijinummi! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on July 30, 2026.

🧑‍💻 @mijinummi: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊