Use google-format-code instead of eclipse ? #663

Activity

1. gorkem

   added

   question

   on Oct 5, 2018
2. gorkem commented on Oct 5, 2018

   

   gorkem

   on Oct 5, 2018

   Contributor

   More actions

   Take a look at eclipse-jdtls/eclipse.jdt.ls#640 I think it provides what you need.
3. hexa00 commented on Oct 5, 2018

   

   hexa00

   on Oct 5, 2018

   Author

   More actions

   @gorkem Yeah unfortunately even using like:

   {
   "java.format.enabled": true,
   "java.saveActions.organizeImports": true,
   "java.format.onType.enabled": true,
   "java.format.settings.url": "https://raw.githubusercontent.com/google/styleguide/gh-pages/eclipse-java-google-style.xml"
   }

   The style is still different than what I get when I run google-format-code :(

   👍React with 👍5Reacted by Arjun Surendra, joehanlon, Tomas Aschan, Ferlim Putra and Will 保哥
4. snjeza commented on Oct 5, 2018

   

   snjeza

   on Oct 5, 2018

   Collaborator

   More actions

   @hexa00 Try to add:

   "editor.tabSize": 2,
   "editor.detectIndentation": false,
   "editor.insertSpaces": true,
   
5. hexa00 commented on Oct 5, 2018

   

   hexa00

   on Oct 5, 2018

   Last edited by hexa00

   Author

   More actions

   @snjeza Thanks but no luck it's like eclipse will format:

   Like this:

     List<String> someIds = foo.stream()
           .map(id -> Something.Func(ABC, id))
           .collect(Collectors.toList());
   

   But google-format-code will do:

    List<String> someIds =
           foo
               .stream()
               .map(id -> Something.Func(ABC, id))
               .collect(Collectors.toList());
   

   👍React with 👍2Reacted by Arjun Surendra and Will 保哥
6. gorkem commented on Oct 6, 2018

   

   gorkem

   on Oct 6, 2018

   Contributor

   More actions

   I think Eclipse formatter does not have an option to insert newline before '.' references.
   I am not sure if there is any value over SaveAndRun extension to making this internal to vscode-java. What is the issue that you are having with SaveAndRun?
7. hexa00 commented on Oct 6, 2018

   

   hexa00

   on Oct 6, 2018

   Author

   More actions

   @gorkem The main problem is that there's a delay to between the save and reload of the formatted code in vscode. So if I save and continue to type then I have modifications that are not in the reloaded file causing vscode to prompt me to compare the unsaved buffer and the reload file. It can get quite annoying :(

   👍React with 👍2Reacted by Arjun Surendra and pcdlynn
8. anthonyvdotbe commented on Mar 22, 2020

   

   anthonyvdotbe

   on Mar 22, 2020

   Last edited by anthonyvdotbe

   More actions

   edit: @fbricon will you please relabel? Thanks in advance

   @gorkem will you please label this as an enhancement rather than a question?
9. doggy8088 commented on Sep 4, 2022

   

   doggy8088

   on Sep 4, 2022

   Contributor

   More actions

   I think embed google-java-format into language server will be the best option. Just like the IntelliJ IDEA's google-java-format plugin did.

   👍React with 👍1Reacted by Marc Jakobi
10. testforstephen

    added

    formatter

    on Feb 13, 2023
11. fbricon

    added

    enhancement

    and removed

    question

    on Apr 14, 2023
12. abceleung commented on Feb 21, 2024

    

    abceleung

    on Feb 21, 2024

    Last edited by abceleung

    More actions

    Bumping because Google released binary versions of google-java-format this week.

    Not sure if they are useful to this extension (the binaries are huge). But for future readers, you can just download the binary and put it on PATH (rename it to google-java-format or google-java-format.exe if on Windows), then run it with the vscode-runonsave extension.

    Example config:

    // settings.json
    {
      "emeraldwalk.runonsave": {
        "commands": [
          {
            "match": ".java$",
            "cmd": "google-java-format --replace ${file}"
          }
        ]
      }
    }