Hooks commit merge #232
Closed
tesseralis
started this conversation in
Team Posts
Replies: 6 comments
|
I ended up merging things manually and you should be able to find a pull request called "Sync Original" that does the update. |
0 replies
|
Oh boy, that PR is huge 😟 |
0 replies
|
@dmoralesm and @carburo, does holding off any merge until we merge reactjs/es.react.dev#115 sound like a good plan to you? I think that's the only way to avoid more conflicts. |
0 replies
|
What do people think about this behavior for the bot? Instead of cherry picking each commit into a new PR, just run it every day or so and create a PR with all the changes. Or possibly a different PR per file? |
0 replies
|
Is the following possible?
|
0 replies
|
I think that's something we have to do in the original repo -- require squash commits and prevent merge/rebase commits. I could put up an issue to see if thats's feasible. |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
@reactjs/reactjs-org-localization Hi everyone!
I ran the update bot on the recent commit for the hooks release, so you should be getting a bunch of [Merge] issues from the react translation bot. Unfortunately it doesn't seem like any of the issues were able to be merged, so I'll take a look at that tomorrow
This is our big first test to see how this approach will work :)
All reactions