Conversation
meta-cla
Bot
added
the
CLA Signed
cortinico
marked this pull request as ready for review
September 21, 2026 10:55
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this in D120988250. |
|
@cortinico merged this pull request in 9da1bac. |
Contributor
Author
|
Merged here: 9da1bac |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The format workflow currently runs on
macos-15, whose default Xcode 16.4 toolchain does not meet the repository formatter's Swift 6.3 minimum. As a result,format-swift.jswarns and skips Swift files.Run the format job on
macos-26and explicitly select Xcode 26.6.0 so thatswift format6.3 is available and Swift formatting is actually exercised in CI.This does not include the unrelated C++ formatting change currently making the job red on
main.Changelog:
[INTERNAL] [FIXED] - Configure Swift formatting in the format workflow
Test Plan:
yarn prettier --check .github/workflows/format.yml— passes.swift format --version— reports6.3.0locally.format-swift.jscompleted without the missing Swift 6.3 warning. The job remains red because enabling the formatter exposes existing formatting changes (along with the unrelated C++ formatting issue already present onmain).