Repository navigation
Commit bf62cce
Accept --remote-debugging-port (#58905)
Summary:
Pull Request resolved: #58905
Launching the React Native DevTools shell with Electron's standard `--remote-debugging-port=<port>` switch, for example to drive it from an end-to-end test over the Chrome DevTools Protocol, opens the port but then fails to open any window. Chromium consumes the switch at startup, but the shell's own launch-argument parsing is strict and rejects it as an unknown option, so the window for `--frontendUrl` is never created and the main process logs an unhandled rejection.
Here, the launch-argument parser accepts `--remote-debugging-port` and ignores it. Chromium still acts on it, so the shell can be automated the same way as any Electron app, with no shell-specific environment variable or wrapper. Every other unknown option is still rejected.
Changelog: [Internal]
Differential Revision: D123603419
fbshipit-source-id: 8453352d1eb96b362ac07c23f491bcab12d8eb6e1 parent 73f4204 commit bf62cce
1 file changed
Lines changed: 5 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
39 | 44 | | |
40 | 45 | | |
41 | 46 | | |
| |||
0 commit comments