Skip to content

Commit 4711f3e

Browse files
huntiefacebook-github-bot
authored andcommitted
Consolidate package checks into one Jest test
Summary: Simplify/unify various mechanisms for the monorepo's package invariants. These checks were previously scattered: - `private/monorepo-tests` package (manifest field checks) - `.github/workflow-scripts/lint_files.sh` (`.npmignore` ban) - `react-native/eslint-plugin-monorepo` (manifest field checks — duplicated) This folds everything into `scripts/monorepo-tests/__tests__/check-packages-test.js`. A plain Jest test is the most extensible home for future checks. Changelog: [Internal] Differential Revision: D111471313
1 parent c948b61 commit 4711f3e

11 files changed

Lines changed: 42 additions & 301 deletions

File tree

.eslintrc.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -61,12 +61,6 @@ module.exports = {
6161
files: ['package.json'],
6262
parser: 'jsonc-eslint-parser',
6363
},
64-
{
65-
files: ['package.json'],
66-
rules: {
67-
'@react-native/monorepo/react-native-manifest': 'error',
68-
},
69-
},
7064
{
7165
files: ['flow-typed/**/*.js', 'packages/react-native/flow/**/*'],
7266
rules: {

.github/workflow-scripts/lint_files.sh

Lines changed: 0 additions & 12 deletions
This file was deleted.

.github/workflows/test-all.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -453,9 +453,6 @@ jobs:
453453
uses: ./.github/actions/setup-node
454454
- name: Install dependencies
455455
uses: ./.github/actions/yarn-install
456-
- name: Lint file structure
457-
shell: bash
458-
run: ./.github/workflow-scripts/lint_files.sh
459456
- name: Run shellcheck
460457
shell: bash
461458
run: ./.github/workflow-scripts/analyze_scripts.sh

private/eslint-plugin-monorepo/index.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ exports.rules = {
1515
'no-react-named-type-imports': require('./rules/no-react-named-type-imports'),
1616
'no-react-native-imports': require('./rules/no-react-native-imports'),
1717
'no-react-node-imports': require('./rules/no-react-node-imports'),
18-
'react-native-manifest': require('./rules/react-native-manifest'),
1918
'require-extends-error': require('./rules/require-extends-error'),
2019
'sort-imports': require('./rules/sort-imports'),
2120
'valid-flow-typed-signature': require('./rules/valid-flow-typed-signature'),

private/eslint-plugin-monorepo/rules/__tests__/react-native-manifest-test.js

Lines changed: 0 additions & 92 deletions
This file was deleted.

private/eslint-plugin-monorepo/rules/react-native-manifest.js

Lines changed: 0 additions & 85 deletions
This file was deleted.

private/monorepo-tests/__tests__/no-dependencies-in-root-package-test.js

Lines changed: 0 additions & 31 deletions
This file was deleted.

private/monorepo-tests/__tests__/no-dev-dependencies-in-react-native-package-test.js

Lines changed: 0 additions & 33 deletions
This file was deleted.

private/monorepo-tests/__tests__/no-dev-dependencies-in-tester-package.js

Lines changed: 0 additions & 33 deletions
This file was deleted.

private/monorepo-tests/package.json

Lines changed: 0 additions & 5 deletions
This file was deleted.

0 commit comments

Comments
 (0)