Using 3.8.3 Trace Functions Correctly

[alpdevel]

Hello I have recently switched from v3.6 to v3.8 and I am not sure I am using the trace functionality correctly. I started off with the async server examples

async def run_async_server(args):
    logger.trace(vars(args))
    address = (args.host if args.host else "",
               args.port if args.port else None)
    server = await ModbusTcpServer(
        context=args.server_context,           # Data storage
        identity=args.identity,         # server identify
        address=address,                # listen address
        framer=FramerType.SOCKET,   # The framer strategy to use
        trace_packet=sim_trace_packet,
        trace_pdu=nsim_trace_pdu,
        trace_connect=sim_trace_connect,
    )
    return server


async def run_modbus_server(port: str, server_info: dict):
    run_args = setup_server(
        server_info, description="Run asynchronous server.")
    run_args.port = port

    updated_task = asyncio.create_task(updating_task(run_args.server_context))
    updated_task.set_name("Update Server Register Values")

    await run_async_server(run_args)

    updated_task.cancel()

here are the trace functions

def sim_trace_packet(sending: bool, data: bytes) -> bytes:
    """Do dummy trace."""
    print("=" * 80)

    logger.critical(f"nsim_trace_packet" * 5)
    txt = "REQUEST stream" if sending else "RESPONSE stream"
    print(f"---> {txt}: {data!r}")
    return data


def sim_trace_pdu(sending: bool, pdu: ModbusPDU) -> ModbusPDU:
    """Do dummy trace."""
    logger.critical(f"sim_trace_pdu" * 5)
    print("=" * 80)
    txt = "REQUEST pdu" if sending else "RESPONSE pdu"
    print(f"---> {txt}: {pdu}")
    return pdu


def sim_trace_connect(connect: bool) -> None:
    """Do dummy trace."""
    logger.critical(f"sim_trace_connect" * 5)
    print("=" * 80)
    txt = "Connected" if connect else "Disconnected"
    print(f"---> {txt}")
    sys.exit(1)

[alpdevel]

With the sample code above, those trace functions are never called. I am sure I have not set things up correctly and would love to know where I went wrong

Thanks!

[janiversen]

That should work, or at least I cannot see why not. I will take a look later.

[janiversen]

Just checked the code, seems we "lost" some code.

V3.8.3 do not support server side tracing only client side.

Thanks for finding this, the problem is simply missing parameter passing, a pull request will be made shortly.

[janiversen]

Created an issue for tracking: #2543

[janiversen]

Your code is correct, and the problem is solved on dev and will be part of an upcoming v3.8.4

[alpdevel]

Thanks for you for all the work you have put in as it has been extreemely helpful!

[alpdevel]

Any idea as to when v3.8.4 will be available

[janiversen]

Soon.