ext/standard: Fix stream use after error handler in stream_get_meta_data

Fixes GH-23262

Author: bukka

ext/standard/streamsfuncs.c

@@ -563,7 +563,6 @@ PHP_FUNCTION(stream_get_meta_data)
 		add_assoc_bool(return_value, "blocked", 1);
 		add_assoc_bool(return_value, "eof", php_stream_eof(stream));
 	}
-	php_stream_error_operation_end_for_stream(stream);
 
 	if (!Z_ISUNDEF(stream->wrapperdata)) {
 		Z_ADDREF_P(&stream->wrapperdata);
@@ -598,6 +597,7 @@ PHP_FUNCTION(stream_get_meta_data)
 		add_assoc_string(return_value, "uri", stream->orig_path);
 	}
 
+	php_stream_error_operation_end_for_stream(stream);
 }
 /* }}} */
 

ext/standard/tests/streams/gh23262.phpt

@@ -0,0 +1,46 @@
+--TEST--
+GH-23262 (stream_get_meta_data() uses the stream after error_handler closes it)
+--FILE--
+<?php
+class InvalidEofStream
+{
+    public $context;
+
+    public function stream_open($path, $mode, $options, &$openedPath): bool
+    {
+        return true;
+    }
+
+    public function stream_eof()
+    {
+        return [];
+    }
+
+    public function stream_stat(): array
+    {
+        return [];
+    }
+}
+
+stream_wrapper_register('invalid-eof', InvalidEofStream::class);
+
+$stream = null;
+$context = stream_context_create([
+    'stream' => [
+        'error_mode' => StreamErrorMode::Silent,
+        'error_handler' => static function (array $errors) use (&$stream): void {
+            echo "handler: {$errors[0]->code->name}\n";
+            fclose($stream);
+        },
+    ],
+]);
+
+$stream = fopen('invalid-eof://input', 'r', false, $context);
+$meta = stream_get_meta_data($stream);
+var_dump($meta['eof'], $meta['wrapper_type'], $meta['uri']);
+?>
+--EXPECT--
+handler: UserspaceInvalidReturn
+bool(true)
+string(10) "user-space"
+string(19) "invalid-eof://input"