From f7649ee2c5eb72a4f224f481c7d6e1e34ec99f4e Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 8 Apr 2026 19:43:18 +0000 Subject: [PATCH] feat: change talk details from bottom sheet to full-screen with top bar On narrow screens, the session detail was shown as a ModalBottomSheet overlay. This changes it to a regular full-screen push navigation entry with a top bar and back arrow, matching the intent of the main content. - Remove BottomSheetSceneStrategy.bottomSheet() metadata from SessionDetailKey on narrow screens (use emptyMap() instead) - Always show back button and top bar in SessionDetailScreen - Always use LocalNavAnimatedContentScope for animated visibility scope - Remove unused bottomSheetStrategy from NavDisplay.sceneStrategies Agent-Logs-Url: https://github.com/paug/AndroidMakersApp/sessions/fb32d396-6686-453a-a984-e98401f2f5f7 Co-authored-by: benju69 <2486590+benju69@users.noreply.github.com> --- .../ui/common/navigation/AVALayout.kt | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/shared/ui/src/commonMain/kotlin/com/androidmakers/ui/common/navigation/AVALayout.kt b/shared/ui/src/commonMain/kotlin/com/androidmakers/ui/common/navigation/AVALayout.kt index f3ca4fa1..c8f8ac10 100644 --- a/shared/ui/src/commonMain/kotlin/com/androidmakers/ui/common/navigation/AVALayout.kt +++ b/shared/ui/src/commonMain/kotlin/com/androidmakers/ui/common/navigation/AVALayout.kt @@ -376,7 +376,7 @@ private fun AVANavDisplay( metadata = if (isWideScreen) { ListDetailSceneStrategy.detailPane() } else { - BottomSheetSceneStrategy.bottomSheet() + emptyMap() } ) { key -> Surface( @@ -388,15 +388,10 @@ private fun AVANavDisplay( viewModel = koinViewModel(key = key.sessionId) { parametersOf(key.sessionId) }, onBackClick = { navigator.goBack() }, onSpeakerClick = { speakerId -> navigator.navigate(SpeakerDetailKey(speakerId)) }, - showBackButton = isWideScreen, - showTopBar = isWideScreen, + showBackButton = true, + showTopBar = true, sharedTransitionScope = sharedTransitionScope, - // LocalNavAnimatedContentScope is unavailable in OverlayScene (bottom sheet) - animatedVisibilityScope = if (isWideScreen) { - LocalNavAnimatedContentScope.current - } else { - null - }, + animatedVisibilityScope = LocalNavAnimatedContentScope.current, ) } } @@ -417,13 +412,12 @@ private fun AVANavDisplay( } } - val bottomSheetStrategy = remember { BottomSheetSceneStrategy() } val listDetailStrategy = rememberListDetailSceneStrategy() NavDisplay( entries = navigationState.toDecoratedEntries(entryProvider), - sceneStrategies = listOf(bottomSheetStrategy, listDetailStrategy), + sceneStrategies = listOf(listDetailStrategy), onBack = navigator::goBack, transitionSpec = { fadeIn(tween(200)) togetherWith ExitTransition.None