feat: support informer.without-namespace-index in ConfigLoader

Signed-off-by: Antonio Fernandez Alhambra <antonio.alhambra@hivemq.com>

Author: afalhambra-hivemq

docs/content/en/docs/documentation/operations/configuration.md

@@ -356,6 +356,7 @@ All controller-level keys are prefixed with `josdk.controller.<controller-name>.
 | `josdk.controller.<name>.informer.label-selector` | `String` | Label selector for the primary resource informer (alias for `label-selector`) |
 | `josdk.controller.<name>.informer.shard-selector` | `String` | Shard selector for the primary resource informer (alias for `shard-selector`) |
 | `josdk.controller.<name>.informer.list-limit` | `Long` | Page size for paginated informer list requests; omit for no pagination |
+| `josdk.controller.<name>.informer.without-namespace-index` | `Boolean` | Removes the namespace index the informer maintains; defaults to `false`. See [Removing the Namespace Index](../eventing#removing-the-namespace-index) |
 
 #### Retry
 

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ControllerConfigurationOverrider.java

@@ -210,6 +210,18 @@ public ControllerConfigurationOverrider<R> withInformerListLimit(Long informerLi
     return this;
   }
 
+  /**
+   * Whether to remove the namespace index the underlying informer maintains by default. Note that
+   * event sources that disagree on this setting do not share an informer.
+   *
+   * @param withoutNamespaceIndex true to remove the namespace index, false (the default) to keep it
+   * @see io.javaoperatorsdk.operator.api.config.informer.Informer#withoutNamespaceIndex()
+   */
+  public ControllerConfigurationOverrider<R> withoutNamespaceIndex(boolean withoutNamespaceIndex) {
+    config.withoutNamespaceIndex(withoutNamespaceIndex);
+    return this;
+  }
+
   public ControllerConfigurationOverrider<R> replacingNamedDependentResourceConfig(
       String name, Object dependentResourceConfig) {
 

operator-framework/src/main/java/io/javaoperatorsdk/operator/config/loader/ConfigLoader.java

@@ -170,7 +170,11 @@ public static ConfigLoader getDefault() {
           new ConfigBinding<>(
               "informer.list-limit",
               Long.class,
-              ControllerConfigurationOverrider::withInformerListLimit));
+              ControllerConfigurationOverrider::withInformerListLimit),
+          new ConfigBinding<>(
+              "informer.without-namespace-index",
+              Boolean.class,
+              ControllerConfigurationOverrider::withoutNamespaceIndex));
 
   private final ConfigProvider configProvider;
 
@@ -228,7 +232,7 @@ Consumer<ControllerConfigurationOverrider<R>> applyControllerConfigs(String cont
 
     Consumer<ControllerConfigurationOverrider<R>> retryStep = buildRetryConsumer(prefix);
     if (retryStep != null) {
-      consumer = consumer == null ? retryStep : consumer.andThen(retryStep);
+      consumer = consumer.andThen(retryStep);
     }
     Consumer<ControllerConfigurationOverrider<R>> rateLimiterStep =
         buildRateLimiterConsumer(prefix);

operator-framework/src/test/java/io/javaoperatorsdk/operator/config/loader/ConfigLoaderTest.java

@@ -26,6 +26,7 @@
 
 import org.junit.jupiter.api.Test;
 
+import io.fabric8.kubernetes.api.model.ConfigMap;
 import io.javaoperatorsdk.operator.api.config.BaseConfigurationService;
 import io.javaoperatorsdk.operator.api.config.ConfigurationService;
 import io.javaoperatorsdk.operator.api.config.ConfigurationServiceOverrider;
@@ -218,10 +219,23 @@ public <T> Optional<T> getValue(String key, Class<T> type) {
             "josdk.controller.ctrl.informer.label-selector",
             "josdk.controller.ctrl.informer.shard-selector",
             "josdk.controller.ctrl.informer.list-limit",
+            "josdk.controller.ctrl.informer.without-namespace-index",
             "josdk.controller.ctrl.rate-limiter.refresh-period",
             "josdk.controller.ctrl.rate-limiter.limit-for-period");
   }
 
+  @Test
+  void applyControllerConfigsAppliesInformerWithoutNamespaceIndex() {
+    var loader =
+        new ConfigLoader(
+            mapProvider(Map.of("josdk.controller.ctrl.informer.without-namespace-index", true)));
+    var overrider = ControllerConfigurationOverrider.override(baseControllerConfig());
+
+    loader.<ConfigMap>applyControllerConfigs("ctrl").accept(overrider);
+
+    assertThat(overrider.build().getInformerConfig().isWithoutNamespaceIndex()).isTrue();
+  }
+
   @Test
   void operatorKeyPrefixIsJosdkDot() {
     assertThat(ConfigLoader.DEFAULT_OPERATOR_KEY_PREFIX).isEqualTo("josdk.");
@@ -567,7 +581,6 @@ private static boolean isTypeCompatible(Class<?> methodParam, Class<?> bindingTy
     if (methodParam == long.class && bindingType == Long.class) return true;
     if (methodParam == Long.class && bindingType == long.class) return true;
     if (methodParam == double.class && bindingType == Double.class) return true;
-    if (methodParam == Double.class && bindingType == double.class) return true;
-    return false;
+    return methodParam == Double.class && bindingType == double.class;
   }
 }