review fixes

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

Author: csviri

operator-framework/src/main/java/io/javaoperatorsdk/operator/config/loader/ConfigLoader.java

@@ -331,6 +331,9 @@ Consumer<ControllerConfigurationOverrider<R>> buildNamespacesConsumer(String pre
     if (value.isEmpty()) {
       return null;
     }
+    if (value.get().isBlank()) {
+      return null;
+    }
 
     final var namespaces =
         Arrays.stream(value.get().split(NAMESPACES_SEPARATOR))

operator-framework/src/test/java/io/javaoperatorsdk/operator/config/loader/ConfigLoaderTest.java

@@ -434,12 +434,9 @@ private static class DummyReconciler
 
   private static io.javaoperatorsdk.operator.processing.retry.GenericRetry applyAndGetRetry(
       java.util.function.Consumer<
-              io.javaoperatorsdk.operator.api.config.ControllerConfigurationOverrider<
-                  io.fabric8.kubernetes.api.model.ConfigMap>>
+              ControllerConfigurationOverrider<io.fabric8.kubernetes.api.model.ConfigMap>>
           consumer) {
-    var overrider =
-        io.javaoperatorsdk.operator.api.config.ControllerConfigurationOverrider.override(
-            baseControllerConfig());
+    var overrider = ControllerConfigurationOverrider.override(baseControllerConfig());
     consumer.accept(overrider);
     return (io.javaoperatorsdk.operator.processing.retry.GenericRetry) overrider.build().getRetry();
   }
@@ -448,9 +445,7 @@ private static io.javaoperatorsdk.operator.processing.retry.GenericRetry applyAn
   void retryIsNotConfiguredWhenNoRetryPropertiesPresent() {
     var loader = new ConfigLoader(mapProvider(Map.of()));
     var consumer = loader.<io.fabric8.kubernetes.api.model.ConfigMap>applyControllerConfigs("ctrl");
-    var overrider =
-        io.javaoperatorsdk.operator.api.config.ControllerConfigurationOverrider.override(
-            baseControllerConfig());
+    var overrider = ControllerConfigurationOverrider.override(baseControllerConfig());
     consumer.accept(overrider);
     // no retry property set → retry stays at the controller's default (null or unchanged)
     var result = overrider.build();
@@ -564,12 +559,9 @@ void retryIsIsolatedPerControllerName() {
 
   private static Set<String> applyAndGetNamespaces(
       java.util.function.Consumer<
-              io.javaoperatorsdk.operator.api.config.ControllerConfigurationOverrider<
-                  io.fabric8.kubernetes.api.model.ConfigMap>>
+              ControllerConfigurationOverrider<io.fabric8.kubernetes.api.model.ConfigMap>>
           consumer) {
-    var overrider =
-        io.javaoperatorsdk.operator.api.config.ControllerConfigurationOverrider.override(
-            baseControllerConfig());
+    var overrider = ControllerConfigurationOverrider.override(baseControllerConfig());
     consumer.accept(overrider);
     return overrider.build().getInformerConfig().getNamespaces();
   }
@@ -610,9 +602,7 @@ void watchAllNamespacesCanBeRequestedExplicitly() {
         new ConfigLoader(
             mapProvider(
                 Map.of("josdk.controller.ctrl.namespaces", Constants.WATCH_ALL_NAMESPACES)));
-    var overrider =
-        io.javaoperatorsdk.operator.api.config.ControllerConfigurationOverrider.override(
-            baseControllerConfig());
+    var overrider = ControllerConfigurationOverrider.override(baseControllerConfig());
     loader
         .<io.fabric8.kubernetes.api.model.ConfigMap>applyControllerConfigs("ctrl")
         .accept(overrider);
@@ -625,9 +615,7 @@ void watchCurrentNamespaceCanBeRequested() {
         new ConfigLoader(
             mapProvider(
                 Map.of("josdk.controller.ctrl.namespaces", Constants.WATCH_CURRENT_NAMESPACE)));
-    var overrider =
-        io.javaoperatorsdk.operator.api.config.ControllerConfigurationOverrider.override(
-            baseControllerConfig());
+    var overrider = ControllerConfigurationOverrider.override(baseControllerConfig());
     loader
         .<io.fabric8.kubernetes.api.model.ConfigMap>applyControllerConfigs("ctrl")
         .accept(overrider);