Repository navigation
feat(gmail): allow quoted create/update drafts with missing images - #1342
pedro-pscunha wants to merge 2 commits into
Conversation
…update Extend the existing draft-only placeholder policy to create and update with --quote. Keep the default strict, preserve valid inline resources, and report degradation for review. Co-Authored-By: Claude Code <noreply@anthropic.com>
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
Add the PR reference and contributor credit to the Unreleased entry. Co-Authored-By: Claude Code <noreply@anthropic.com>
|
Codex review: needs real behavior proof before merge. What this changesExtends the existing missing-image placeholder option to quoted Gmail draft creation and updates. Example: Quote a message containing <img src="cid:missing@example.com"> without a matching MIME part.
Review scores
ProductKind: Feature · Worth it: Needs a maintainer decision · Fix scope: Complete Merge readiness⛔ Blocked before merge - 1 item remains Keep this PR open: it adds distinct create/update support absent from main, and source review found no definite correctness regression. Priority: P3 Decision needed
Before merge
FindingsNone. Tests
Agent review detailsHow this fits togetherGmail draft commands combine caller input with a source message through shared reply and MIME composition, save the result through Gmail, and return draft identifiers and warnings. flowchart LR
A[Draft create or update] --> B[Validate quote policy]
B --> C[Fetch source message]
C --> D[Shared quote and MIME composer]
D --> E[Gmail draft API]
E --> F[Draft result and warnings]
Technical reviewBest possible solution: Reuse the existing placeholder composer for both commands, retain strict defaults, and obtain owner acceptance of the additional flag locations. Do we have a high-confidence way to reproduce the issue? Current source establishes the limitation: create/update cannot select placeholder composition and therefore retain intentional missing-CID rejection; no runtime reproduction was executed. Is this the best way to solve the issue? The implementation is focused: it threads the existing policy and warnings through the existing draft composer without introducing another MIME repair path. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 351e62175513. Provenance checked
TestingProof path: in-process harness. SecurityNone. EvidenceWhat I checked:
Likely related people:
Preflight sourceSource unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified. LabelsLabel changes:
Label justifications:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed November 19, 2026, 7:18 PM ET / November 20, 2026, 00:18 UTC. |
What Problem This Solves
Some Outlook replies keep a quoted
cid:image reference but omit its MIME part.gmail drafts create/update --quotethen fails instead of saving the draft.User Impact
Both commands now accept
--missing-inline-images=placeholderwith--quote. Missing images become visible text placeholders. The default remainserror.For example:
Why This Change Was Made
drafts replyandreply-allalready support this option. This change reuses their MIME checks, placeholders, and degradation warnings for create/update. Valid inline resources stay intact. Placeholder mode requires--quoteand cannot accompany--raw-file.The draft result reports
degraded: trueand image warnings. The stderr warning asks for review before sending.Evidence
The command package tests pass with a clean environment:
env -u GOG_ACCOUNT -u GOG_HOME -u GOG_KEYRING_PASSWORD go test ./internal/cmd/...The new fixture tests cover create/update placeholders, the strict default, dry-run output, and invalid non-quote/raw usage. The new tests reject the unmodified v0.48.1 commands because they lack the flag.
These checks use local HTTP fixtures, not a live Google account. I did not run the whole-repository suite.
🤖 Generated with Claude Code