feat: Add the possibility to create invitation links to circles#2254
feat: Add the possibility to create invitation links to circles#2254Koc wants to merge 1 commit into
Conversation
Koc
force-pushed
the
feature/invitation-links-to-circles
branch
13 times, most recently
from
8301408 to
a89bf72
Compare
Koc
force-pushed
the
feature/invitation-links-to-circles
branch
3 times, most recently
from
baffcc3 to
af15456
Compare
Koc
force-pushed
the
feature/invitation-links-to-circles
branch
from
af15456 to
018eea9
Compare
Koc
force-pushed
the
feature/invitation-links-to-circles
branch
from
018eea9 to
08b6110
Compare
Koc
force-pushed
the
feature/invitation-links-to-circles
branch
2 times, most recently
from
213cfc1 to
b01cd7a
Compare
| $initiatorHelper = new MemberHelper($circle->getInitiator()); | ||
| $initiatorHelper->mustBeAdmin(); | ||
|
|
||
| $new = clone $circle; |
There was a problem hiding this comment.
Why is it needed to clone the circle object?
There was a problem hiding this comment.
I've just inspired from already existent verify method implementations:
circles/lib/FederatedItems/CircleConfig.php
Line 128 in 6c37964
- ...
| * | ||
| * @throws InvalidIdException | ||
| */ | ||
| public function replace(CircleInvitation $circleInvitation): void { |
There was a problem hiding this comment.
Could there be multiple invitation per circle? If so, shouldn't we delete a specific invitation, and not all of them?
There was a problem hiding this comment.
not now. In theory we can add that, but in this case we need rework UI and introduce something like "invitation link name" to distinguish links.
I would like to start with something really simple and improve it later
| $qb->limitToInitiator(CoreQueryBuilder::CIRCLE, $initiator); | ||
| $qb->orderBy($qb->generateAlias(CoreQueryBuilder::CIRCLE, CoreQueryBuilder::INITIATOR) . '.level', 'desc'); | ||
| $qb->addOrderBy(CoreQueryBuilder::CIRCLE . '.display_name', 'asc'); | ||
| $qb->leftJoinCircleInvitation(CoreQueryBuilder::CIRCLE); |
There was a problem hiding this comment.
Shouldn't we join only if $probe->hasInvitationCode() === true?
There was a problem hiding this comment.
no, because we need to respond with invitationCode in GET https://nextcloud.test/ocs/v2.php/apps/circles/circles endpoint
| /** | ||
| * @return CoreQueryBuilder&IQueryBuilder | ||
| */ | ||
| protected function getCircleInvitationInsertSql(): CoreQueryBuilder { |
There was a problem hiding this comment.
Similarly to getCircleInvitationDeleteSql, we should inline the content of this method.
Koc
force-pushed
the
feature/invitation-links-to-circles
branch
2 times, most recently
from
bac0d4e to
524ff22
Compare
Koc
force-pushed
the
feature/invitation-links-to-circles
branch
from
524ff22 to
63d11c0
Compare
Koc
force-pushed
the
feature/invitation-links-to-circles
branch
from
63d11c0 to
23a9469
Compare
I can't use |
Koc
force-pushed
the
feature/invitation-links-to-circles
branch
2 times, most recently
from
cb5808c to
c1227d7
Compare
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
Koc
force-pushed
the
feature/invitation-links-to-circles
branch
from
c1227d7 to
ab2ab91
Compare
2 participants
This PR adds possibility to generate invitation link (even for completely hidden/closed Circles). Any user is able to join to the circle by opening this link.
Dependencies