Skip to content

Add JIRA configuration discovery and fix REST API fallback script execution#79

Open
mrrajan wants to merge 2 commits into
mrizzi:mainfrom
mrrajan:fix-jira-fallback-plugin-root-path
Open

Add JIRA configuration discovery and fix REST API fallback script execution#79
mrrajan wants to merge 2 commits into
mrizzi:mainfrom
mrrajan:fix-jira-fallback-plugin-root-path

Conversation

@mrrajan
Copy link
Copy Markdown
Contributor

@mrrajan mrrajan commented Apr 17, 2026

  • Add JIRA configuration discovery to remove hardcoded field values
  • Add explicit plugin-root execution pattern to all SKILL.md files and update all jira-client.py command examples to include the required 'cd &&' prefix.

Summary by Sourcery

Document the correct plugin-root execution pattern for Jira REST API fallback usage across SDLC workflow skills.

Documentation:

  • Add a shared "REST API Script Execution Pattern" section to SKILL docs describing that jira-client.py must be run from the plugin root directory.
  • Update Jira REST API command examples in SDLC workflow skill docs to prefix invocations with cd <plugin-root> && so they execute from the plugin cache location.

@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai Bot commented Apr 17, 2026

Reviewer's Guide

Documents the correct Jira REST API fallback execution pattern across SDLC workflow skills by introducing a shared "REST API Script Execution Pattern" section and updating all jira-client.py command examples to first cd to the plugin root so they run from the plugin cache instead of the project directory.

Sequence diagram for Jira REST API fallback using plugin-root execution pattern

sequenceDiagram
  actor Developer
  participant ClaudeSkill
  participant PluginRootResolver
  participant JiraClientScript
  participant JiraRESTAPI

  Developer->>ClaudeSkill: Invoke_skill_operation
  ClaudeSkill-->>Developer: MCP_unavailable_detected
  ClaudeSkill-->>Developer: Show_REST_API_Script_Execution_Pattern

  Developer->>PluginRootResolver: Determine_plugin_root_from_skill_base
  PluginRootResolver-->>Developer: plugin_root_path

  Developer->>JiraClientScript: cd_plugin_root_and_run_command
  activate JiraClientScript
  JiraClientScript->>JiraRESTAPI: HTTPS_request_with_credentials
  JiraRESTAPI-->>JiraClientScript: JSON_response
  JiraClientScript-->>Developer: CLI_output
  deactivate JiraClientScript

  ClaudeSkill-->>Developer: Continue_skill_flow_using_script_results
Loading

File-Level Changes

Change Details Files
Standardize and document the Jira REST API script execution pattern for all SDLC workflow skills.
  • Add a "REST API Script Execution Pattern" section explaining plugin-root vs project directory and how to derive plugin root from the skill base directory.
  • Specify the required command pattern cd <plugin-root> && python3 scripts/jira-client.py <command> and refer readers to shared/jira-rest-fallback.md for extraction details.
plugins/sdlc-workflow/skills/define-feature/SKILL.md
plugins/sdlc-workflow/skills/implement-task/SKILL.md
plugins/sdlc-workflow/skills/verify-pr/SKILL.md
plugins/sdlc-workflow/skills/plan-feature/SKILL.md
plugins/sdlc-workflow/skills/setup/SKILL.md
Update all Jira REST fallback command examples to run jira-client.py from the plugin root rather than the project directory.
  • Prefix all direct python3 scripts/jira-client.py ... examples with cd <plugin-root> && so they execute from the plugin cache.
  • Adjust multi-line examples (e.g., create_issue, add_comment) to include cd <plugin-root> && \ on the first line while preserving flags and formatting.
  • Update REST API equivalence tables for each skill so every jira-client mapping includes the cd <plugin-root> && prefix, including get_issue, get_user_info, update_issue, create_issue, create_link, add_comment, transition_issue, and get_project_metadata calls.
  • Keep the Bash tool exception text but ensure examples remain consistent with the new execution pattern where applicable.
plugins/sdlc-workflow/skills/define-feature/SKILL.md
plugins/sdlc-workflow/skills/implement-task/SKILL.md
plugins/sdlc-workflow/skills/verify-pr/SKILL.md
plugins/sdlc-workflow/skills/plan-feature/SKILL.md
plugins/sdlc-workflow/skills/setup/SKILL.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • In the implement-task and verify-pr SKILL docs, the examples for get_transitions / transition_issue now read cd <plugin-root> && get_transitions ... / cd <plugin-root> && transition_issue ...; these should be updated to include the python3 scripts/jira-client.py prefix like the other commands for consistency and correctness.
  • You’ve added an identical “REST API Script Execution Pattern” block to multiple SKILL files; consider extracting this into a single shared section (e.g., in shared/jira-rest-fallback.md) and referencing it from each SKILL to avoid future drift between copies.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- In the `implement-task` and `verify-pr` SKILL docs, the examples for `get_transitions` / `transition_issue` now read `cd <plugin-root> && get_transitions ...` / `cd <plugin-root> && transition_issue ...`; these should be updated to include the `python3 scripts/jira-client.py` prefix like the other commands for consistency and correctness.
- You’ve added an identical “REST API Script Execution Pattern” block to multiple SKILL files; consider extracting this into a single shared section (e.g., in `shared/jira-rest-fallback.md`) and referencing it from each SKILL to avoid future drift between copies.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Add explicit plugin-root execution pattern to all SKILL.md files
and update all jira-client.py command examples to include the
required 'cd <plugin-root> &&' prefix.

The scripts/jira-client.py script is located in the plugin cache,
not the project directory. All invocations must cd to plugin-root
(2 directory levels up from skill base) before executing.

Changes:
- Add "REST API Script Execution Pattern" section to 5 SKILL.md files
- Update 25+ command examples with correct cd prefix
- Ensures fallback works when Atlassian MCP is unavailable

Fixes issue where fallback referred to project directory instead
of extracting plugin-root from skill base directory.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@mrrajan mrrajan force-pushed the fix-jira-fallback-plugin-root-path branch from 7b02fef to f1a56b6 Compare April 17, 2026 06:10
Signed-off-by: mrrajan <86094767+mrrajan@users.noreply.github.com.>
@mrrajan mrrajan changed the title docs: fix Jira REST API fallback to use plugin-root path Add JIRA configuration discovery and fix REST API fallback script execution Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant