Add JIRA configuration discovery and fix REST API fallback script execution#79
Open
mrrajan wants to merge 2 commits into
Open
Add JIRA configuration discovery and fix REST API fallback script execution#79mrrajan wants to merge 2 commits into
mrrajan wants to merge 2 commits into
Conversation
Contributor
Reviewer's GuideDocuments the correct Jira REST API fallback execution pattern across SDLC workflow skills by introducing a shared "REST API Script Execution Pattern" section and updating all jira-client.py command examples to first cd to the plugin root so they run from the plugin cache instead of the project directory. Sequence diagram for Jira REST API fallback using plugin-root execution patternsequenceDiagram
actor Developer
participant ClaudeSkill
participant PluginRootResolver
participant JiraClientScript
participant JiraRESTAPI
Developer->>ClaudeSkill: Invoke_skill_operation
ClaudeSkill-->>Developer: MCP_unavailable_detected
ClaudeSkill-->>Developer: Show_REST_API_Script_Execution_Pattern
Developer->>PluginRootResolver: Determine_plugin_root_from_skill_base
PluginRootResolver-->>Developer: plugin_root_path
Developer->>JiraClientScript: cd_plugin_root_and_run_command
activate JiraClientScript
JiraClientScript->>JiraRESTAPI: HTTPS_request_with_credentials
JiraRESTAPI-->>JiraClientScript: JSON_response
JiraClientScript-->>Developer: CLI_output
deactivate JiraClientScript
ClaudeSkill-->>Developer: Continue_skill_flow_using_script_results
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In the
implement-taskandverify-prSKILL docs, the examples forget_transitions/transition_issuenow readcd <plugin-root> && get_transitions .../cd <plugin-root> && transition_issue ...; these should be updated to include thepython3 scripts/jira-client.pyprefix like the other commands for consistency and correctness. - You’ve added an identical “REST API Script Execution Pattern” block to multiple SKILL files; consider extracting this into a single shared section (e.g., in
shared/jira-rest-fallback.md) and referencing it from each SKILL to avoid future drift between copies.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In the `implement-task` and `verify-pr` SKILL docs, the examples for `get_transitions` / `transition_issue` now read `cd <plugin-root> && get_transitions ...` / `cd <plugin-root> && transition_issue ...`; these should be updated to include the `python3 scripts/jira-client.py` prefix like the other commands for consistency and correctness.
- You’ve added an identical “REST API Script Execution Pattern” block to multiple SKILL files; consider extracting this into a single shared section (e.g., in `shared/jira-rest-fallback.md`) and referencing it from each SKILL to avoid future drift between copies.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Add explicit plugin-root execution pattern to all SKILL.md files and update all jira-client.py command examples to include the required 'cd <plugin-root> &&' prefix. The scripts/jira-client.py script is located in the plugin cache, not the project directory. All invocations must cd to plugin-root (2 directory levels up from skill base) before executing. Changes: - Add "REST API Script Execution Pattern" section to 5 SKILL.md files - Update 25+ command examples with correct cd prefix - Ensures fallback works when Atlassian MCP is unavailable Fixes issue where fallback referred to project directory instead of extracting plugin-root from skill base directory. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
7b02fef to
f1a56b6
Compare
Signed-off-by: mrrajan <86094767+mrrajan@users.noreply.github.com.>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Document the correct plugin-root execution pattern for Jira REST API fallback usage across SDLC workflow skills.
Documentation:
cd <plugin-root> &&so they execute from the plugin cache location.