Skip to content

Github NULL body error #36

Description

@YTheon

Hi!

I ran into this error using the bult-in github downloader:

Error: retrieve archive failed for module tnt
-> Could not find release `v8.38` in github repository BGforgeNet/bg2-tweaks-and-tricks
get release endpoint returned incorrect data
error decoding response body
caused by
Some(Error("invalid type: null, expected a string", line: 1, column: 5355))

The problematic mod and url is this:
https://api.github.com/repos/BGforgeNet/bg2-tweaks-and-tricks/releases/tags/v8.38

The problem is that the mod author did not define a body text for this release...

"body": null

...but the parser expects a string instead of null

struct ReleaseInfo {
    pub url: String,
    pub html_url: String,
    pub assets_url: String,
    pub tarball_url: String,
    pub zipball_url: String,
    pub id: u32,
    pub tag_name: String,
    pub body: String,
    pub name: String,
    pub assets: Vec<Asset>,
}

if file: modda-lib/src/module/location/github.rs
line number: 211

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions