expose basic Prometheus metrics#371
Open
jnodorp-jaconi wants to merge 1 commit into
Open
Conversation
|
I'm glad to see other people working on metrics for the replicator too. It looks like we've been working in parallel a bit, I've opened a PR that also exposes a metrics server and adds a basic operation counter to start with some application metrics: #372 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR starts work on #340 by exposing a
/metricsendpoint with a basic set of metrics (for example,go_info).Application metrics can be added by following the Prometheus documentation.