Version emacs 31, make-frame-invisible fails in the terminal

[bommbo]

I tried using delete-frame instead of make-frame-invisible.

(defun corfu--hide-frame-deferred (frame)
  "Deferred hiding of child FRAME."
  (when (and (frame-live-p frame) (frame-visible-p frame))
    (set-frame-parameter frame 'corfu--hide-timer nil)
    (with-current-buffer (window-buffer (frame-root-window frame))
      (with-silent-modifications
        (delete-region (point-min) (point-max))))
    ;; TTY child frame: delete instead of make-invisible (bug in Emacs 31 TTY)
    (if (display-graphic-p)
        (make-frame-invisible frame)
      (delete-frame frame))))

[minad]

Thanks for the report. I cannot reproduce this. Please tell me more about your setup. How old is your Emacs (please try compiling the newest version from Emacs master)? Did you use emacs -Q? In any case, if make-frame-invisible does not work on the terminal it would be an upstream bug and should be reported there.

[bommbo]

It's hard to test - besides this package, I don't know how to conveniently create a TTY child frame. You can comment out (make-frame-visible frame), and it still works normally in the terminal. Can I conclude that make-frame-invisible can only be used properly after make-frame-visible has been called? @minad

[minad]

I believe this has been resolved, see the discussion in #608.