From 12bfd55768b90804e820ecc5ec102b150f41e189 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" Date: Mon, 13 Jul 2026 13:05:29 +0200 Subject: [PATCH 1/5] reorganized fields on the page --- .../BaseApp/Foundation/Company/CompanyInformation.Page.al | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Layers/FR/BaseApp/Foundation/Company/CompanyInformation.Page.al b/src/Layers/FR/BaseApp/Foundation/Company/CompanyInformation.Page.al index ae8a7c04a9..40883d9521 100644 --- a/src/Layers/FR/BaseApp/Foundation/Company/CompanyInformation.Page.al +++ b/src/Layers/FR/BaseApp/Foundation/Company/CompanyInformation.Page.al @@ -110,10 +110,6 @@ page 1 "Company Information" VATRegistrationLogMgt.AssistEditCompanyInfoVATReg(); end; } - field("SIRET No."; Rec."SIRET No.") - { - ApplicationArea = Basic, Suite; - } field(GLN; Rec.GLN) { ApplicationArea = Basic, Suite; @@ -347,6 +343,10 @@ page 1 "Company Information" Importance = Additional; ToolTip = 'Specifies the company''s registration number. You can enter a maximum of 20 characters, both numbers and letters.'; } + field("SIRET No."; Rec."SIRET No.") + { + ApplicationArea = Basic, Suite; + } field(Control1120004; Rec."Trade Register") { ApplicationArea = Basic, Suite; From eed0d0ea72dd567eb0f404254598e10d11e42034 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" Date: Mon, 13 Jul 2026 16:31:12 +0200 Subject: [PATCH 2/5] remove dinternal --- .../app/src/Formats/FacturX/ExportFacturXDocument.Codeunit.al | 1 - 1 file changed, 1 deletion(-) diff --git a/src/Apps/FR/EDocument_FR/EReportingFR/app/src/Formats/FacturX/ExportFacturXDocument.Codeunit.al b/src/Apps/FR/EDocument_FR/EReportingFR/app/src/Formats/FacturX/ExportFacturXDocument.Codeunit.al index d7444b562b..13084db9a1 100644 --- a/src/Apps/FR/EDocument_FR/EReportingFR/app/src/Formats/FacturX/ExportFacturXDocument.Codeunit.al +++ b/src/Apps/FR/EDocument_FR/EReportingFR/app/src/Formats/FacturX/ExportFacturXDocument.Codeunit.al @@ -17,7 +17,6 @@ using System.Utilities; codeunit 10983 "Export Factur-X Document" { - Access = Internal; TableNo = "Record Export Buffer"; var From 1da8334dfde33bf3138ab0314de77deaf1814155 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" Date: Mon, 13 Jul 2026 23:03:13 +0200 Subject: [PATCH 3/5] [master][NAV] Track failed BCApps validation (AUTODETECTED) - tests updated --- .../LibraryERM.Codeunit.al | 19 ++----------------- .../IT/Tests/Local/ITNonDedVAT.Codeunit.al | 4 ++++ .../Tests/Local/NonDedVATMiscIT.Codeunit.al | 1 + .../IT/Tests/VAT/NonDedVATMisc.Codeunit.al | 2 ++ .../VAT/NonDeductiblePurchPosting.Codeunit.al | 1 + .../W1/Tests/VAT/NonDedVATMisc.Codeunit.al | 2 ++ 6 files changed, 12 insertions(+), 17 deletions(-) diff --git a/src/Layers/IT/Tests/ApplicationTestLibrary/LibraryERM.Codeunit.al b/src/Layers/IT/Tests/ApplicationTestLibrary/LibraryERM.Codeunit.al index 9c2d2459e9..b27dd42b23 100644 --- a/src/Layers/IT/Tests/ApplicationTestLibrary/LibraryERM.Codeunit.al +++ b/src/Layers/IT/Tests/ApplicationTestLibrary/LibraryERM.Codeunit.al @@ -1421,9 +1421,6 @@ codeunit 131300 "Library - ERM" end; procedure CreateVATBusinessPostingGroup(var VATBusinessPostingGroup: Record "VAT Business Posting Group") - var - NoSeries: Record "No. Series"; - NoSeriesCode: Code[20]; begin VATBusinessPostingGroup.Init(); VATBusinessPostingGroup.Validate( @@ -1434,20 +1431,8 @@ codeunit 131300 "Library - ERM" // Validating Code as Name because value is not important. VATBusinessPostingGroup.Validate(Description, VATBusinessPostingGroup.Code); - // Set "Default Sales/Purchase operation"s - select first appropriate from "No. Series" - NoSeries.SetRange("No. Series Type", NoSeries."No. Series Type"::Sales); - if NoSeries.FindFirst() then - NoSeriesCode := NoSeries.Code - else - NoSeriesCode := CreateNoSeriesSalesCode(); - VATBusinessPostingGroup."Default Sales Operation Type" := NoSeriesCode; - - NoSeries.SetRange("No. Series Type", NoSeries."No. Series Type"::Purchase); - if NoSeries.FindFirst() then - NoSeriesCode := NoSeries.Code - else - NoSeriesCode := CreateNoSeriesPurchaseCode(); - VATBusinessPostingGroup."Default Purch. Operation Type" := NoSeriesCode; + VATBusinessPostingGroup."Default Sales Operation Type" := CreateNoSeriesSalesCode(); + VATBusinessPostingGroup."Default Purch. Operation Type" := CreateNoSeriesPurchaseCode(); VATBusinessPostingGroup.Insert(true); end; diff --git a/src/Layers/IT/Tests/Local/ITNonDedVAT.Codeunit.al b/src/Layers/IT/Tests/Local/ITNonDedVAT.Codeunit.al index edbd696f67..f786708fd2 100644 --- a/src/Layers/IT/Tests/Local/ITNonDedVAT.Codeunit.al +++ b/src/Layers/IT/Tests/Local/ITNonDedVAT.Codeunit.al @@ -595,6 +595,7 @@ codeunit 144001 "IT - Non Ded. VAT" // [THEN] There are several VAT entries having in total: Base = 670.28, Amount = 147.46, Nondeductible Base = 1005.43, Nondeductible Amount = 221.20 FindVATEntry(VATEntry, PostedInvoiceNo); + VATEntry.SetRange(Type, VATEntry.Type::Purchase); VATEntry.CalcSums(Base, Amount, "Nondeductible Base", "Nondeductible Amount"); VATEntry.TestField(Base, 670.28); VATEntry.TestField(Amount, 147.46); @@ -651,6 +652,7 @@ codeunit 144001 "IT - Non Ded. VAT" // [THEN] There are several VAT entries having in total: Base = 363.67, Amount = 80.01, Nondeductible Base = 545.51, Nondeductible Amount = 120.01 FindVATEntry(VATEntry, PostedInvoiceNo); + VATEntry.SetRange(Type, VATEntry.Type::Purchase); Assert.RecordCount(VATEntry, 6); VATEntry.CalcSums(Base, Amount, "Nondeductible Base", "Nondeductible Amount"); VATEntry.TestField(Base, 363.67); @@ -1174,6 +1176,8 @@ codeunit 144001 "IT - Non Ded. VAT" VATEntry: Record "VAT Entry"; begin FindVATEntry(VATEntry, DocumentNo); + VATEntry.SetRange(Type, VATEntry.Type::Purchase); + VATEntry.FindLast(); VATEntry.TestField("Nondeductible Base", NonDeductibleBase); VATEntry.TestField("Nondeductible Amount", NonDeductibleAmount); end; diff --git a/src/Layers/IT/Tests/Local/NonDedVATMiscIT.Codeunit.al b/src/Layers/IT/Tests/Local/NonDedVATMiscIT.Codeunit.al index 8431a2d843..449ab77452 100644 --- a/src/Layers/IT/Tests/Local/NonDedVATMiscIT.Codeunit.al +++ b/src/Layers/IT/Tests/Local/NonDedVATMiscIT.Codeunit.al @@ -1096,6 +1096,7 @@ codeunit 144251 "Non Ded. VAT Misc. IT" begin VATEntry.SetRange("Document No.", DocumentNo); VATEntry.SetRange("Document Type", VATEntry."Document Type"::Invoice); + VATEntry.SetRange(Type, VATEntry.Type::Purchase); VATEntry.FindLast(); end; diff --git a/src/Layers/IT/Tests/VAT/NonDedVATMisc.Codeunit.al b/src/Layers/IT/Tests/VAT/NonDedVATMisc.Codeunit.al index aa388c20a9..1e0eee9709 100644 --- a/src/Layers/IT/Tests/VAT/NonDedVATMisc.Codeunit.al +++ b/src/Layers/IT/Tests/VAT/NonDedVATMisc.Codeunit.al @@ -551,6 +551,7 @@ codeunit 134284 "Non Ded. VAT Misc." // [THEN] There are several VAT entries having in total: Base = 670.28, Amount = 147.46, Nondeductible Base = 1005.43, Nondeductible Amount = 221.20 FindVATEntry(VATEntry, PostedInvoiceNo); + VATEntry.SetRange(Type, VATEntry.Type::Purchase); VATEntry.CalcSums(Base, Amount, "Non-Deductible VAT Base", "Non-Deductible VAT Amount"); VATEntry.TestField(Base, 670.28); VATEntry.TestField(Amount, 147.46); @@ -603,6 +604,7 @@ codeunit 134284 "Non Ded. VAT Misc." // [THEN] There are several VAT entries having in total: Base = 363.67, Amount = 80.01, Nondeductible Base = 545.51, Nondeductible Amount = 120.01 FindVATEntry(VATEntry, PostedInvoiceNo); + VATEntry.SetRange(Type, VATEntry.Type::Purchase); Assert.RecordCount(VATEntry, 6); VATEntry.CalcSums(Base, Amount, "Non-Deductible VAT Base", "Non-Deductible VAT Amount"); VATEntry.TestField(Base, 363.67); diff --git a/src/Layers/IT/Tests/VAT/NonDeductiblePurchPosting.Codeunit.al b/src/Layers/IT/Tests/VAT/NonDeductiblePurchPosting.Codeunit.al index 1df5fdeec1..d35009e98f 100644 --- a/src/Layers/IT/Tests/VAT/NonDeductiblePurchPosting.Codeunit.al +++ b/src/Layers/IT/Tests/VAT/NonDeductiblePurchPosting.Codeunit.al @@ -928,6 +928,7 @@ codeunit 134283 "Non-Deductible Purch. Posting" begin VATEntry.SetRange("Document No.", DocumentNo); VATEntry.SetRange("Posting Date", WorkDate()); + VATEntry.SetRange(Type, VATEntry.Type::Purchase); VATEntry.FindFirst(); end; diff --git a/src/Layers/W1/Tests/VAT/NonDedVATMisc.Codeunit.al b/src/Layers/W1/Tests/VAT/NonDedVATMisc.Codeunit.al index ee98b13f29..e8a48011f8 100644 --- a/src/Layers/W1/Tests/VAT/NonDedVATMisc.Codeunit.al +++ b/src/Layers/W1/Tests/VAT/NonDedVATMisc.Codeunit.al @@ -551,6 +551,7 @@ codeunit 134284 "Non Ded. VAT Misc." // [THEN] There are several VAT entries having in total: Base = 670.28, Amount = 147.46, Nondeductible Base = 1005.43, Nondeductible Amount = 221.20 FindVATEntry(VATEntry, PostedInvoiceNo); + VATEntry.SetRange(Type, VATEntry.Type::Purchase); VATEntry.CalcSums(Base, Amount, "Non-Deductible VAT Base", "Non-Deductible VAT Amount"); VATEntry.TestField(Base, 670.28); VATEntry.TestField(Amount, 147.46); @@ -603,6 +604,7 @@ codeunit 134284 "Non Ded. VAT Misc." // [THEN] There are several VAT entries having in total: Base = 363.67, Amount = 80.01, Nondeductible Base = 545.51, Nondeductible Amount = 120.01 FindVATEntry(VATEntry, PostedInvoiceNo); + VATEntry.SetRange(Type, VATEntry.Type::Purchase); Assert.RecordCount(VATEntry, 6); VATEntry.CalcSums(Base, Amount, "Non-Deductible VAT Base", "Non-Deductible VAT Amount"); VATEntry.TestField(Base, 363.67); From 9df36b51c25601a4762bf594edaf89b8abb9bb67 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" Date: Mon, 13 Jul 2026 23:15:08 +0200 Subject: [PATCH 4/5] Revert "reorganized fields on the page" This reverts commit 12bfd55768b90804e820ecc5ec102b150f41e189. --- .../BaseApp/Foundation/Company/CompanyInformation.Page.al | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Layers/FR/BaseApp/Foundation/Company/CompanyInformation.Page.al b/src/Layers/FR/BaseApp/Foundation/Company/CompanyInformation.Page.al index 40883d9521..ae8a7c04a9 100644 --- a/src/Layers/FR/BaseApp/Foundation/Company/CompanyInformation.Page.al +++ b/src/Layers/FR/BaseApp/Foundation/Company/CompanyInformation.Page.al @@ -110,6 +110,10 @@ page 1 "Company Information" VATRegistrationLogMgt.AssistEditCompanyInfoVATReg(); end; } + field("SIRET No."; Rec."SIRET No.") + { + ApplicationArea = Basic, Suite; + } field(GLN; Rec.GLN) { ApplicationArea = Basic, Suite; @@ -343,10 +347,6 @@ page 1 "Company Information" Importance = Additional; ToolTip = 'Specifies the company''s registration number. You can enter a maximum of 20 characters, both numbers and letters.'; } - field("SIRET No."; Rec."SIRET No.") - { - ApplicationArea = Basic, Suite; - } field(Control1120004; Rec."Trade Register") { ApplicationArea = Basic, Suite; From 94418fae9c51456587c3ba4ebf337a9a54bf864d Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" Date: Mon, 13 Jul 2026 23:15:31 +0200 Subject: [PATCH 5/5] Revert "remove dinternal" This reverts commit eed0d0ea72dd567eb0f404254598e10d11e42034. --- .../app/src/Formats/FacturX/ExportFacturXDocument.Codeunit.al | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Apps/FR/EDocument_FR/EReportingFR/app/src/Formats/FacturX/ExportFacturXDocument.Codeunit.al b/src/Apps/FR/EDocument_FR/EReportingFR/app/src/Formats/FacturX/ExportFacturXDocument.Codeunit.al index 13084db9a1..d7444b562b 100644 --- a/src/Apps/FR/EDocument_FR/EReportingFR/app/src/Formats/FacturX/ExportFacturXDocument.Codeunit.al +++ b/src/Apps/FR/EDocument_FR/EReportingFR/app/src/Formats/FacturX/ExportFacturXDocument.Codeunit.al @@ -17,6 +17,7 @@ using System.Utilities; codeunit 10983 "Export Factur-X Document" { + Access = Internal; TableNo = "Record Export Buffer"; var