Skip to content

Commit 13aa71d

Browse files
committed
ci: drop host nasm install — mcpp >= 0.0.95 self-bootstraps nasm
mcpp resolves nasm like any toolchain: PATH first, then the mcpp sandbox, then an automatic 'xlings install nasm', lazily and only when the build plan actually contains .asm units (compat.ffmpeg). The sandbox copy lives under ~/.mcpp/registry, so the CI cache carries it across runs. Keeping a host apt install would mask the self-bootstrap path this repo is supposed to exercise.
1 parent b80ecb6 commit 13aa71d

1 file changed

Lines changed: 5 additions & 7 deletions

File tree

.github/workflows/validate.yml

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -211,13 +211,11 @@ jobs:
211211
echo "MCPP_VENDORED_XLINGS=$root/${{ matrix.xlings }}" >> "$GITHUB_ENV"
212212
echo "$root/bin" >> "$GITHUB_PATH"
213213
fi
214-
# compat.ffmpeg carries NASM .asm sources; mcpp resolves nasm PATH-first
215-
# (ubuntu-24.04 ships nasm 2.16 — deterministic, no index round-trip).
216-
- name: Install nasm (Linux)
217-
if: runner.os == 'Linux'
218-
shell: bash
219-
run: sudo apt-get update && sudo apt-get install -y nasm
220-
214+
# compat.ffmpeg carries NASM .asm sources. No host install needed:
215+
# mcpp >= 0.0.95 resolves nasm itself (PATH → sandbox → auto
216+
# `xlings install nasm`), lazily, only when the plan has .asm units —
217+
# same self-bootstrap contract as the llvm toolchain. The sandbox copy
218+
# lands in ~/.mcpp/registry, so the cache carries it across runs.
221219
- name: mcpp test --workspace
222220
shell: bash
223221
env:

0 commit comments

Comments
 (0)