more openwrt enhancements#995
Conversation
|
@rietbergenm missing DCO |
Yeah, DCO is not missing; it just doesn't match my github username and it does not like that... |
|
Can you align it easily enough or should I do it? |
|
Ah okay, I can do it. I thought you had to use a real name, not some username :) |
|
We definitely prefer using real names as it makes the validity of the DCO a lot less ambiguous. In this case, I would just have re-written the git Author field to match your DCO line. You can do that using the |
To be able to insert files in `/etc/uci-defaults`, incus-agent needs to run before `S10boot`, so start as `S05incus-agent`. Signed-off-by: Mathijs Rietbergen <mathijs.rietbergen@proton.me>
`fdisk` is not meant to be used in scripts. Its output is not easy to parse and not guaranteed to be stable. `partx` is meant for this and is even installed by default on debian based distros (as part of `util-linux`). Signed-off-by: Mathijs Rietbergen <mathijs.rietbergen@proton.me>
stgraber
force-pushed
the
pr/openwrt-improvements
branch
from
0b498f9 to
736d1a2
Compare
Noted. |
2 participants
I have another pr coming in lxc-ci which fixes the hostname not being set properly. It makes use of templates which need to be present during early boot. For this to work, incus-agent needs to run early in the boot proces.
Also
fdiskis kind of ugly to use w.r.t. output parsing, so use partx which is meant for this and installed by default on debain based distros.