Repository navigation
notificationDaemon: resolve native desktop-entry hints without a PID match - #14090
Open
jkramer5103 wants to merge 2 commits into
Open
jkramer5103 wants to merge 2 commits into
jkramer5103 wants to merge 2 commits into
Conversation
Member
|
Please don't include tests |
Author
|
Removed the standalone test in 55f2ada. The PR now contains only the eight-line notification lookup change; the description retains the local validation results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notifications from native applications without a tracked PID/window can still use a generic icon even after e225755:
Source._getApp()only resolves thedesktop-entryhint through the Flatpak-only application table. Resolve the desktop-file ID first, accepting hints with or without.desktop, then retain the existing Flatpak, browser-alias, name and tray fallbacks. PID matches retain priority.Related to #14070. This addresses the remaining native-app lookup case; it does not duplicate the app-icon fallback already on master or claim to reproduce every reported Slack/Geary notification.
The standalone test was removed from the PR at the maintainer's request. The final diff contains only the eight-line source change.
Validation performed locally before removing the test:
node tests/unit/notificationDaemon.jspasses against the real module with GI/UI boundaries stubbed. Covers native desktop hints, source and notification icons, explicit icon priority, PID precedence, Flatpak IDs/browser aliases, unique/ambiguous names, unknown/missing hints, urgency icons and tray lookup.nullinstead of the native app).node --check js/ui/notificationDaemon.jsandgit diff --cached --checkpass. Staged diff reviewed and scanned for common credential patterns.memory.max=1073741824andmemory.swap.max=0, one process at a time.Limitations: the local standalone proof is not included in the submitted changes. No full build, real GI/CJS session, D-Bus integration test or live UI screenshots; Cinnamon/CJS and a desktop session are unavailable in this environment. Visual behavior remains unverified.