Fix doctest typos in src/server/config/mod.rs

[coderabbitai]

Description

Two doctest examples in src/server/config/mod.rs contain stray text (important - comment) that causes compilation failures.

Affected Lines

• Line 305: In the accept_initial_delay method documentation
• Line 326: In the accept_max_delay method documentation

Required Changes

Remove the stray (important - comment) text from both doctests:

-    /// let server = WireframeServer::new(|| WireframeApp::default())(important - comment)
+    /// let server = WireframeServer::new(|| WireframeApp::default())

References

• Discovered in PR: Make exponential backoff parameters configurable in accept_loop #290
• Original comment: Make exponential backoff parameters configurable in accept_loop #290 (comment)
• Requested by: @leynos
• Issue: Fix doctest typos in src/server/config/mod.rs #293

[leynos]

@coderabbitai Has this now been resolved in the latest commit?

Use codegraph analysis to determine your answer.

If this comment is now resolved, please mark it as such using the API. Otherwise, please provide an AI agent prompt for the remaining work to be done to address this comment.

[coderabbitai]

This issue has been resolved through the refactoring in commit 071fdfd (PR #279), which removed the problematic accept_initial_delay and accept_max_delay methods entirely. These methods were replaced with a consolidated accept_backoff API that uses a BackoffConfig struct.

The stray text (important - comment) never made it into the git history, and the problematic doctests no longer exist in the codebase.

Resolution: Code removed through refactoring - issue no longer applicable.

[coderabbitai]

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash

# Get details about issue `#293`
echo "=== Issue `#293` Details ==="
gh issue view 293 --json number,title,body,state,labels,createdAt,updatedAt,closedAt

echo -e "\n=== Recent Commits ==="
# Get the last 5 commits to see recent changes
git log -5 --oneline --decorate

echo -e "\n=== Latest Commit Details ==="
# Get detailed information about the latest commit
git log -1 --stat

echo -e "\n=== Files Changed in Latest Commit ==="
# Get the list of files changed in the latest commit
git diff-tree --no-commit-id --name-only -r HEAD

Length of output: 3865

---

🏁 Script executed:

#!/bin/bash

# Check if the issue still exists in src/server/config/mod.rs
echo "=== Checking lines around 305 in src/server/config/mod.rs ==="
sed -n '300,310p' src/server/config/mod.rs | cat -n

echo -e "\n=== Checking lines around 326 in src/server/config/mod.rs ==="
sed -n '321,331p' src/server/config/mod.rs | cat -n

echo -e "\n=== Search for the stray text pattern ==="
rg -n "\(important - comment\)" src/server/config/mod.rs || echo "Pattern not found"

echo -e "\n=== Full context of accept_initial_delay method ==="
sed -n '/fn accept_initial_delay/,/^    \}/p' src/server/config/mod.rs | head -30

echo -e "\n=== Full context of accept_max_delay method ==="
sed -n '/fn accept_max_delay/,/^    \}/p' src/server/config/mod.rs | head -30

Length of output: 287

---

🏁 Script executed:

#!/bin/bash

# Check if the file exists and its size
echo "=== File existence check ==="
ls -lh src/server/config/mod.rs 2>&1 || echo "File does not exist"

# Check the entire file structure
echo -e "\n=== File structure (if exists) ==="
if [ -f src/server/config/mod.rs ]; then
    wc -l src/server/config/mod.rs
    echo -e "\n=== First 50 lines ==="
    head -50 src/server/config/mod.rs
    echo -e "\n=== Last 50 lines ==="
    tail -50 src/server/config/mod.rs
fi

# Search for these methods in the entire codebase
echo -e "\n=== Search for accept_initial_delay ==="
rg -n "fn accept_initial_delay" --type rust

echo -e "\n=== Search for accept_max_delay ==="
rg -n "fn accept_max_delay" --type rust

# Check server directory structure
echo -e "\n=== Server directory structure ==="
find src/server -type f -name "*.rs" 2>/dev/null || echo "src/server directory not found"

Length of output: 3944

---

🏁 Script executed:

#!/bin/bash

# Check git history for changes to this file
echo "=== Git history for src/server/config/mod.rs ==="
git log --oneline --all -- src/server/config/mod.rs | head -20

echo -e "\n=== Recent commits that modified this file ==="
git log -10 --stat --oneline -- src/server/config/mod.rs

echo -e "\n=== Check if accept_initial_delay ever existed (git grep in history) ==="
git log --all --source --full-history -S "accept_initial_delay" -- src/server/config/mod.rs | head -20

echo -e "\n=== Find when the stray text was removed ==="
git log --all --source --full-history -S "(important - comment)" -- src/server/config/mod.rs | head -20

Length of output: 2829

---

🏁 Script executed:

#!/bin/bash

# Check the commit that refactored the file
echo "=== Commit 071fdfd details ==="
git show 071fdfd --stat

echo -e "\n=== Check if the stray text existed before the refactor ==="
git show 071fdfd~1:src/server/config/mod.rs | grep -n "(important - comment)" || echo "Not found in parent commit"

echo -e "\n=== Search the lines around 305 and 326 before the refactor ==="
echo "--- Lines 300-310 before refactor ---"
git show 071fdfd~1:src/server/config/mod.rs | sed -n '300,310p' | cat -n

echo -e "\n--- Lines 321-331 before refactor ---"
git show 071fdfd~1:src/server/config/mod.rs | sed -n '321,331p' | cat -n

echo -e "\n=== Check commit bd5bf50 (PR `#290` - the one that introduced backoff) ==="
git show bd5bf50:src/server/config/mod.rs | grep -n "(important - comment)" || echo "Not found in PR `#290` commit"

echo -e "\n=== Check if the issue text was in PR `#290` diff ==="
git show bd5bf50 | grep -C5 "(important - comment)" || echo "Not found in PR `#290` diff"

Length of output: 4055

---

🏁 Script executed:

#!/bin/bash

# Let's check the actual PR `#290` comments and see what happened
echo "=== PR `#290` Details ==="
gh pr view 290 --json number,title,body,state,createdAt,mergedAt,closedAt

echo -e "\n=== Check all commits in PR `#290` ==="
gh pr view 290 --json commits --jq '.commits[].commit.message'

echo -e "\n=== Timeline: When was issue `#293` created vs when was the refactor ==="
echo "Issue `#293` created: 2025-08-08T23:12:38Z"
git log --format="%H %ai %s" --all -- src/server/config/mod.rs | grep -E "(071fdfd|bd5bf50)"

echo -e "\n=== Check if the stray text exists in ANY commit in the repo history ==="
git log --all --source -S "(important - comment)" --oneline -- src/server/config/mod.rs || echo "Never existed in git history"

echo -e "\n=== Let's see what state the file was in when issue was created ==="
# Find the commit closest to when the issue was created (2025-08-08T23:12:38Z)
git log --all --before="2025-08-09" --format="%H %ai" -1 -- src/server/config/mod.rs

Length of output: 4998

---

🏁 Script executed:

#!/bin/bash

# Check the PR `#290` discussion comment referenced in the issue
echo "=== Fetching PR `#290` comments ==="
gh pr view 290 --json comments --jq '.comments[] | {author: .author.login, createdAt: .createdAt, body: .body}' | head -50

echo -e "\n=== Check PR review comments ==="
gh api "/repos/leynos/wireframe/pulls/290/comments" --jq '.[] | {author: .user.login, path: .path, line: .line, body: .body, created_at: .created_at}' 2>/dev/null | head -100

echo -e "\n=== Detailed timeline ==="
echo "PR `#290` created: 2025-08-08T14:35:55Z"
echo "PR `#290` merged: 2025-08-08T23:14:02Z"
echo "Issue `#293` created: 2025-08-08T23:12:38Z (2 minutes before merge)"
echo "Refactor commit 071fdfd: 2025-08-09 19:40:13 +0100 (next day)"

echo -e "\n=== Check current state: methods no longer exist ==="
rg -n "fn accept_(initial|max)_delay" src/server/config/mod.rs || echo "Methods do not exist"
rg -n "fn accept_backoff" src/server/config/mod.rs

Length of output: 62169

---

@leynos, the issue has been resolved through refactoring. Here's what I found:## Resolution Summary

Issue #293 has been resolved through the major refactoring in commit 071fdfd (9 August 2025), which occurred the day after the issue was created.

Key Findings:

1. Methods no longer exist: The problematic methods accept_initial_delay and accept_max_delay (and their doctests at lines 305 and 326) were completely removed during the refactoring
2. Replaced with new API: These methods were consolidated into a single accept_backoff method that uses a BackoffConfig struct with proper validation
3. File significantly reduced: The file went from 300+ lines to 168 lines during the refactor
4. Stray text never committed: The (important - comment) text never actually appeared in git history, suggesting it was caught before merging PR #290

Current State:

• File: src/server/config/mod.rs (168 lines)
• No accept_initial_delay or accept_max_delay methods
• Uses accept_backoff(cfg: BackoffConfig) instead with proper invariant enforcement

The issue is effectively resolved by deletion - the problematic code no longer exists in the codebase.

---

🏁 Script executed:

#!/bin/bash

# Close issue `#293` as completed
gh issue close 293 --reason completed --comment "This issue has been resolved through the refactoring in commit 071fdfd (PR `#279`), which removed the problematic \`accept_initial_delay\` and \`accept_max_delay\` methods entirely. These methods were replaced with a consolidated \`accept_backoff\` API that uses a \`BackoffConfig\` struct.

The stray text \`(important - comment)\` never made it into the git history, and the problematic doctests no longer exist in the codebase.

**Resolution**: Code removed through refactoring - issue no longer applicable."

Length of output: 83

---

✅ Issue #293 has been closed as resolved.

The issue was successfully marked as completed via the GitHub API. The problematic methods and their doctests were removed during the refactoring in PR #279 (commit 071fdfd), making the issue no longer applicable. The stray text (important - comment) never actually made it into the repository's git history.