Skip to content

Add net10.0, update packages#177

Merged
michal12334 merged 8 commits into
mainfrom
feature/net10.0
Nov 20, 2025
Merged

Add net10.0, update packages#177
michal12334 merged 8 commits into
mainfrom
feature/net10.0

Conversation

@michal12334

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Nov 13, 2025

Copy link
Copy Markdown

Test Results

  3 files  + 1    3 suites  +1   1m 30s ⏱️ +27s
 85 tests ± 0   85 ✅ ± 0  0 💤 ±0  0 ❌ ±0 
276 runs  +92  276 ✅ +92  0 💤 ±0  0 ❌ ±0 

Results for commit 4d1c3ec. ± Comparison against base commit 8d0c9e1.

♻️ This comment has been updated with latest results.

Comment thread Directory.Build.targets Outdated
Comment thread Directory.Build.targets
<PackageReference Update="Microsoft.Extensions.FileSystemGlobbing" Version="$(ExtsVer)" />
<PackageReference Update="System.Collections.Immutable" Version="9.0.0" />
<PackageReference Update="System.Collections.Immutable" Version="10.0.0" />
<PackageReference Update="System.Reflection.MetadataLoadContext" Version="$(ExtsVer)" />

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this, I think, should be bumpable to 10.0.0.

@Saancreed

Copy link
Copy Markdown
Member

https://github.com/leancodepl/contractsgenerator/blob/v4.0.0-alpha.1/examples/project/Directory.Build.targets#L2-L6 will need some fixups, to remove net10.0 if current SDK (like 9.0.xxx) can't target it. Otherwise tests will fail in the way you see on CI.

(If you have an idea about how to make this more robust, feel free to experiment.)

@codecov-commenter

codecov-commenter commented Nov 18, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.87%. Comparing base (d2604e8) to head (7ff3014).
⚠️ Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #177      +/-   ##
==========================================
- Coverage   81.26%   75.87%   -5.40%     
==========================================
  Files          34       37       +3     
  Lines         993     1061      +68     
  Branches      117      133      +16     
==========================================
- Hits          807      805       -2     
- Misses        141      204      +63     
- Partials       45       52       +7     
Flag Coverage Δ
net10.0 75.87% <ø> (?)
net8.0 75.87% <ø> (-5.38%) ⬇️
net9.0 75.87% <ø> (-5.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread Directory.Build.targets
@jakubfijalkowski

Copy link
Copy Markdown
Member

Let's remember to update the CHANGELOG (and release a 4.1 version afterwards) and we're good to go I think.

Comment thread CHANGELOG.md
@Saancreed

Copy link
Copy Markdown
Member

release a 4.1 version afterwards

And skip 4.0? Why?

@jakubfijalkowski

Copy link
Copy Markdown
Member

release a 4.1 version afterwards

And skip 4.0? Why?

I missed that it is not released. Nevertheless, should it be released as-is, and .NET 10 should be in 4.1?

@michal12334

Copy link
Copy Markdown
Contributor Author

release a 4.1 version afterwards

And skip 4.0? Why?

I missed that it is not released. Nevertheless, should it be released as-is, and .NET 10 should be in 4.1?

Yea, I think so.

@michal12334 michal12334 merged commit 4ce8124 into main Nov 20, 2025
5 checks passed
@michal12334 michal12334 deleted the feature/net10.0 branch November 20, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants