CLI can't find global packages or npm. Maybe wrong path config? #4599

Activity

1. ionitron-bot

   added

   triage

   on Oct 30, 2020
2. PhilippSonntagORGADATA

   changed the title [-]CLI uses wrong paths[/-] [+]CLI can't find global packages or npm. Maybe wrong path config?[/+] on Oct 30, 2020
3. PhilippSonntagORGADATA commented on Nov 13, 2020

   

   PhilippSonntagORGADATA

   on Nov 13, 2020

   Last edited by PhilippSonntagORGADATA

   Author

   More actions

   Can somebody help me here? This actively prevents me from using the cli.
   The $PATH environment variable is correctly set as it displays when I'm printing it out.

   /Users/psn_local/.nvm/versions/node/v14.15.0/bin:
   is in my path which contains the binaries of
   ionic ionic-lab ng node_modules npx pnpx tsc webpack-cli ionic-cli-scripts ionic-v1 node npm pnpm preact tsserver webpack-dev-server.

   EDIT: Found the error, going to submit a PR.
4. sonntag-philipp commented on Nov 13, 2020

   

   sonntag-philipp

   on Nov 13, 2020

   Last edited by sonntag-philipp

   More actions

   It was an error in my project ionic.config.json. I switched from Windows to macOS and didn't notice the config used windows paths with backslashes. I think this error message is very misleading.
5. imhoffd

   linked a pull request that will close this issueValidation of project and integration root directories. #4608on Nov 13, 2020
6. imhoffd commented on Nov 13, 2020

   

   imhoffd

   on Nov 13, 2020

   Contributor

   More actions

   What exactly did you have in ionic.config.json that caused this issue?
7. sonntag-philipp commented on Nov 13, 2020

   

   sonntag-philipp

   on Nov 13, 2020

   More actions

   {
       "defaultProject": "first-project",
       "projects": {
           "first-project": {
               "name": "First Project",
               "integrations": {},
               "type": "angular",
               "root": "projects\\first-project"
           },
           "second-project": {
               "name": "Second Project",
               "integrations": {},
               "type": "angular",
               "root": "projects\\second-project"
           },
           "third-project": {
               "name": "Third Project",
               "integrations": {},
               "type": "angular",
               "root": "projects\\third-project"
           }
       }
   }

   I had to change the names but this was exactly the structure. The paths in the root properties were made on windows which didn't work on macOS.
8. imhoffd commented on Nov 13, 2020

   

   imhoffd

   on Nov 13, 2020

   Contributor

   More actions

   Ahh, so the ENOENT was coming from a missing cwd, I'm guessing.

   I'm wondering if it might be better to validate the project directory exists before we even attempt to spin up the serve CLI. I looked at your PR and realized we'd have to handle the same error in the build CLI and anywhere else we use that project directory as the cwd of the subprocess.
9. sonntag-philipp commented on Nov 13, 2020

   

   sonntag-philipp

   on Nov 13, 2020

   More actions

   Yeah exactly, sorry for missing out that information.

   My first attempt was also to check the cwd, but I wasn't sure if other parameters could cause this error too, so I just ended up checking the existance of the cli command itself.
   I don't know if I can figure out all positions where this has to be fixed, but I could modify my changes if they are still needed.
10. imhoffd commented on Nov 13, 2020

    

    imhoffd

    on Nov 13, 2020

    Contributor

    More actions

    I believe your PR will only realistically fix this specific issue: that the subprocess can emit an ENOENT error because of a missing cwd. Since that is the case, the logic may be simpler if we just check if that directory exists beforehand.

    I thought about this a bit more and I think you were pretty close. We probably do want this check to exist when we attempt to serve/build/generate.

    Here are some starting points:

    • https://github.com/ionic-team/ionic-cli/blob/develop/packages/@ionic/cli/src/lib/serve.ts#L192
    • https://github.com/ionic-team/ionic-cli/blob/develop/packages/@ionic/cli/src/lib/build.ts#L99
    • https://github.com/ionic-team/ionic-cli/blob/develop/packages/@ionic/cli/src/lib/generate.ts#L24

    I can take a look too, but it will be some time before I dig in. I'm mostly focused on Capacitor these days. Bugs in the Ionic CLI are rare, and this one looks like it will only affect devs who are using multiapp and make a typo in the project paths.

    If you intend to continue with a fix, let me know if you have any questions! I'd be happy to answer them.
11. sonntag-philipp commented on Nov 21, 2020

    

    sonntag-philipp

    on Nov 21, 2020

    More actions

    Hej there,
    finally found some time to investigate. To prevent any false configurations, I implemented a validation for integration and project roots. I think this will handle most of the possible errors. Thanks for the help :)

    When the directory is not accessible, the CLI will throw an exception like this: