Update lsimh01 snapshot to match current non-CRAN check output#239
Conversation
Unit Tests Summary 1 files 274 suites 13m 44s ⏱️ Results for commit dcba9d1. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Additional test case details
Results for commit 39e1131 ♻️ This comment has been updated with latest results. |
|
hi @munoztd0 and @gmbecker , I would like to check and confirm with you when pharmaversesdtmjnj will be released to i see it was changed at, our internal pipeline is currently breaking because of this. i would like to fix revert this change here, and reintroduce the update on a branch, when it is more ready, we can merge it back ok? thanks for your understanding |
Signed-off-by: Joe Zhu <sha.joe.zhu@gmail.com>
lsimh01 snapshot to match current non-CRAN check output
Yeah this is awkward, I am sorry we wanted to do a full release with all the changes at once so we created a non-cran version that would resolve those issue the v0.0.5 but it fine if you revert the changes until we do the new cran release with all the new updates and datasets |
|
I see. I am going to merge this in. tests/testthat/test-lsimh01.R expect_snapshot_file(write_test_rtf_for("lsimh01.R"), "lsimh01.rtf") is causing me a bit headache at the moment. Can I leave this with you and fixing in your new version? I think this is related to your data. Thanks. I will create an issue and tag you in. @munoztd0 |
Yeah of course I will take care of it , sorry for the trouble ! |
R CMD Check (non-CRAN)started failing on a single snapshot assertion intest-lsimh01.Rbecause the generated RTF output forwrite_test_rtf_for("lsimh01.R")no longer matched the committed fixture.This PR updates the stored snapshot to the expected output so the snapshot assertion reflects current generated content.
What changed
tests/testthat/_snaps/lsimh01/lsimh01.rtfScope
lsimh01Representative snapshot delta