Skip to content

Update lsimh01 snapshot to match current non-CRAN check output#239

Merged
shajoezhu merged 11 commits into
mainfrom
copilot/downversion-to-004
Jun 24, 2026
Merged

Update lsimh01 snapshot to match current non-CRAN check output#239
shajoezhu merged 11 commits into
mainfrom
copilot/downversion-to-004

Conversation

Copilot AI commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

R CMD Check (non-CRAN) started failing on a single snapshot assertion in test-lsimh01.R because the generated RTF output for write_test_rtf_for("lsimh01.R") no longer matched the committed fixture.
This PR updates the stored snapshot to the expected output so the snapshot assertion reflects current generated content.

  • What changed

    • Updated snapshot fixture:
      • tests/testthat/_snaps/lsimh01/lsimh01.rtf
  • Scope

    • Snapshot-only update for lsimh01
    • No test logic or template code changes
  • Representative snapshot delta

    -\pard\intbl\qc\fs16 3 \cell
    +\pard\intbl\qc\fs16 5 \cell

Copilot AI changed the title [WIP] Downversion DESCRIPTION pharmaversesdtmjnj to 0.0.4 Downversion pharmaversesdtmjnj to 0.0.4 in DESCRIPTION Jun 23, 2026
Copilot AI requested a review from shajoezhu June 23, 2026 08:46
@shajoezhu shajoezhu marked this pull request as ready for review June 23, 2026 09:30
@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Unit Tests Summary

  1 files  274 suites   13m 44s ⏱️
411 tests 219 ✅ 192 💤 0 ❌
676 runs  267 ✅ 409 💤 0 ❌

Results for commit dcba9d1.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
pagination_table 💚 $13.97$ $-1.48$ $0$ $0$ $0$ $0$
table_ent 💚 $15.26$ $-1.16$ $0$ $0$ $0$ $0$
table_lbt14 💚 $33.96$ $-2.63$ $0$ $0$ $0$ $0$
tsfae06b 💚 $19.05$ $-1.66$ $0$ $0$ $0$ $0$
tsfae21bpart1 💚 $11.57$ $-1.19$ $0$ $0$ $0$ $0$
tsfae21bpart2 💚 $10.95$ $-1.12$ $0$ $0$ $0$ $0$
tsfae21bpart3 💚 $11.05$ $-1.04$ $0$ $0$ $0$ $0$
tsfae21bpart4 💚 $11.20$ $-1.09$ $0$ $0$ $0$ $0$
tsfae22apart1 💚 $9.90$ $-1.07$ $0$ $0$ $0$ $0$
tsfae22apart4 💚 $9.67$ $-1.06$ $0$ $0$ $0$ $0$
tsfae24fpart1 💚 $12.58$ $-1.22$ $0$ $0$ $0$ $0$
tsfae24fpart3 💚 $12.21$ $-1.14$ $0$ $0$ $0$ $0$
tsflab01apart1 💚 $15.13$ $-1.19$ $0$ $0$ $0$ $0$
tsflab01apart2 💚 $14.56$ $-1.33$ $0$ $0$ $0$ $0$
tsflab01apart3 💚 $14.76$ $-1.22$ $0$ $0$ $0$ $0$
tsids02a 💚 $7.96$ $-1.03$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
tsfae06b 💚 $19.05$ $-1.66$ tsfae06b
tsfae21bpart1 💚 $11.57$ $-1.19$ tsfae21bpart1of4
tsfae21bpart2 💚 $10.95$ $-1.12$ tsfae21bpart2of4
tsfae21bpart3 💚 $11.05$ $-1.04$ tsfae21bpart3of4
tsfae21bpart4 💚 $11.20$ $-1.09$ tsfae21bpart4of4
tsfae22apart1 💚 $9.90$ $-1.07$ tsfae22apart1of4
tsfae22apart4 💚 $9.67$ $-1.06$ tsfae22apart4of4
tsfae24fpart1 💚 $12.58$ $-1.22$ tsfae24fpart1of3
tsfae24fpart3 💚 $12.21$ $-1.14$ tsfae24fpart3of3
tsflab01apart1 💚 $15.13$ $-1.19$ tsflab01a
tsflab01apart2 💚 $14.56$ $-1.33$ tsflab01a
tsflab01apart3 💚 $14.76$ $-1.22$ tsflab01a
tsids02a 💚 $7.96$ $-1.03$ tsids02a

Results for commit 39e1131

♻️ This comment has been updated with latest results.

@shajoezhu

Copy link
Copy Markdown
Contributor

hi @munoztd0 and @gmbecker , I would like to check and confirm with you when pharmaversesdtmjnj will be released to
cran

i see it was changed at,

https://github.com/insightsengineering/scda.test/pull/231/changes#diff-9cc358405149db607ff830a16f0b4b21f7366e3c99ec00d52800acebe21b231c

our internal pipeline is currently breaking because of this. i would like to fix revert this change here, and reintroduce the update on a branch, when it is more ready, we can merge it back ok? thanks for your understanding

Comment thread DESCRIPTION Outdated
Signed-off-by: Joe Zhu <sha.joe.zhu@gmail.com>
Copilot AI changed the title Downversion pharmaversesdtmjnj to 0.0.4 in DESCRIPTION Update lsimh01 snapshot to match current non-CRAN check output Jun 23, 2026
@munoztd0

Copy link
Copy Markdown
Collaborator

hi @munoztd0 and @gmbecker , I would like to check and confirm with you when pharmaversesdtmjnj will be released to cran

i see it was changed at,

https://github.com/insightsengineering/scda.test/pull/231/changes#diff-9cc358405149db607ff830a16f0b4b21f7366e3c99ec00d52800acebe21b231c

our internal pipeline is currently breaking because of this. i would like to fix revert this change here, and reintroduce the update on a branch, when it is more ready, we can merge it back ok? thanks for your understanding

Yeah this is awkward, I am sorry we wanted to do a full release with all the changes at once so we created a non-cran version that would resolve those issue the v0.0.5 but it fine if you revert the changes until we do the new cran release with all the new updates and datasets

@shajoezhu

Copy link
Copy Markdown
Contributor

I see. I am going to merge this in.

tests/testthat/test-lsimh01.R

expect_snapshot_file(write_test_rtf_for("lsimh01.R"), "lsimh01.rtf")

is causing me a bit headache at the moment. Can I leave this with you and fixing in your new version? I think this is related to your data. Thanks. I will create an issue and tag you in. @munoztd0

@shajoezhu shajoezhu merged commit 29d075d into main Jun 24, 2026
30 of 31 checks passed
@shajoezhu shajoezhu deleted the copilot/downversion-to-004 branch June 24, 2026 09:43
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 24, 2026
@munoztd0

Copy link
Copy Markdown
Collaborator

I see. I am going to merge this in.

tests/testthat/test-lsimh01.R

expect_snapshot_file(write_test_rtf_for("lsimh01.R"), "lsimh01.rtf")

is causing me a bit headache at the moment. Can I leave this with you and fixing in your new version? I think this is related to your data. Thanks. I will create an issue and tag you in. @munoztd0

Yeah of course I will take care of it , sorry for the trouble !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants