From 41dec84c2cbf793a20d15fcf292352cdf4bec282 Mon Sep 17 00:00:00 2001 From: Simon Davies Date: Wed, 16 Sep 2026 21:56:31 +0100 Subject: [PATCH] ci: run lint before build steps `just lint` runs cargo hyperlight clippy, cargo clippy --all-targets and lint-js, none of which need artifacts from the preceding build steps, so nothing was gained by running it after them. clippy executes build.rs, which builds and links the guest, so lint-first also catches guest toolchain and link failures. This is not theoretical: during PR #308 a macOS llvm-ar failure surfaced only in the Build step, many minutes in, when lint-first would have caught it. clippy and cargo build have separate fingerprints, so the reorder does not duplicate compilation work. Net effect: cheap, fast-failing checks run before expensive ones, which shortens the feedback loop on a matrix of 10+ jobs, several of which run on scarce self-hosted runners. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Simon Davies --- .github/workflows/dep_build.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/dep_build.yml b/.github/workflows/dep_build.yml index d55b26d..28e0362 100644 --- a/.github/workflows/dep_build.yml +++ b/.github/workflows/dep_build.yml @@ -160,6 +160,9 @@ jobs: - name: fmt run: just fmt-check + - name: lint + run: just lint ${{ matrix.config }} + - name: Build run: | just build ${{ matrix.config }} @@ -168,9 +171,6 @@ jobs: run: | just build-js-host-api ${{ matrix.config }} - - name: lint - run: just lint ${{ matrix.config }} - - name: test run: just test-all ${{ matrix.config }}