Skip to content

Update: Added K8s & Jenkins CI/CD#9

Merged
hoangsonww merged 2 commits into
masterfrom
feat/add-ci-cd-tests
Jul 4, 2025
Merged

Update: Added K8s & Jenkins CI/CD#9
hoangsonww merged 2 commits into
masterfrom
feat/add-ci-cd-tests

Conversation

@hoangsonww

@hoangsonww hoangsonww commented Jul 4, 2025

Copy link
Copy Markdown
Owner

Pull Request Template

Overview

This pull request implements the CI/CD pipeline for the LMS application. It includes:

  • Formatting and linting setup
  • Parallel backend (pytest) and frontend (Jest) testing
  • Frontend code coverage collection
  • Docker build & push to GHCR
  • Simple deployment step messaging
  • Final completion notification

Files Changed

  • .github/workflows/ci.yml (added full pipeline config)
  • Added test specs under frontend/__tests__/
  • Minor updates to package.json scripts
  • Added .dockerignore and adjusted Dockerfile for backend & frontend

Testing

  • Ran all jobs locally in dry-run mode
  • Verified pytest -q works for the backend
  • Verified npm test and npm run coverage for the frontend
  • Confirmed Docker images built and pushed successfully on GHCR
  • Confirmed GitHub Actions workflow passes on PR event

Screenshots (if applicable)

N/A (pipeline config)

Notes to Reviewers

  • Please check the Docker build steps closely — I set explicit context and file paths
  • Deployment is currently a simple echo message; future production deployment commands can replace these
  • If you want, you can test the pipeline by pushing to a feature branch to verify parallel jobs

Deployment Notes

  • Ensure secrets.GITHUB_TOKEN is available for GHCR push
  • Ensure Render and Vercel accounts are ready for actual deployment once the placeholders are swapped with real commands

@hoangsonww hoangsonww requested a review from Copilot July 4, 2025 14:43
@hoangsonww hoangsonww self-assigned this Jul 4, 2025
@hoangsonww hoangsonww added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Jul 4, 2025
@netlify

netlify Bot commented Jul 4, 2025

Copy link
Copy Markdown

Deploy Preview for fullstack-learning-management-system canceled.

Name Link
🔨 Latest commit 6d5a2b0
🔍 Latest deploy log https://app.netlify.com/projects/fullstack-learning-management-system/deploys/6867e88cf50c340008786e4f

@vercel

vercel Bot commented Jul 4, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
learning-management-system-fullstack ⬜️ Ignored (Inspect) Jul 4, 2025 2:43pm

@hoangsonww hoangsonww merged commit 4382391 into master Jul 4, 2025
6 of 7 checks passed
@hoangsonww hoangsonww changed the title Feat/add ci cd tests Update: Added K8s & Jenkins CI/CD Jul 4, 2025

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds new badges to the project README to surface API documentation, testing frameworks, and CI/CD integration.

  • Introduces a Swagger badge in the API Docs section
  • Adds Cypress, Jest, and Pytest badges under a new Testing section
  • Includes a GitHub Actions badge in the Version Control section

Comment thread README.md
Comment on lines +135 to +137
<a href="https://docs.github.com/en/actions" target="_blank">
<img src="https://img.shields.io/badge/GitHub-Actions-2088FF?style=for-the-badge&logo=githubactions&logoColor=white" alt="GitHub Actions"/>
</a>

Copilot AI Jul 4, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] This GitHub Actions badge duplicates the existing CI/CD badge earlier in the README. Consider removing one instance or consolidating to reduce redundancy.

Suggested change
<a href="https://docs.github.com/en/actions" target="_blank">
<img src="https://img.shields.io/badge/GitHub-Actions-2088FF?style=for-the-badge&logo=githubactions&logoColor=white" alt="GitHub Actions"/>
</a>
<!-- Removed duplicate GitHub Actions badge -->

Copilot uses AI. Check for mistakes.
Comment thread README.md
Comment on lines 134 to +137
<!-- Version Control -->
<a href="https://docs.github.com/en/actions" target="_blank">
<img src="https://img.shields.io/badge/GitHub-Actions-2088FF?style=for-the-badge&logo=githubactions&logoColor=white" alt="GitHub Actions"/>
</a>

Copilot AI Jul 4, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Placing the GitHub Actions badge under the Version Control section may confuse readers. It might fit better alongside other CI/CD badges in the DevOps section.

Suggested change
<!-- Version Control -->
<a href="https://docs.github.com/en/actions" target="_blank">
<img src="https://img.shields.io/badge/GitHub-Actions-2088FF?style=for-the-badge&logo=githubactions&logoColor=white" alt="GitHub Actions"/>
</a>
<!-- CI/CD -->
<a href="https://docs.github.com/en/actions" target="_blank">
<img src="https://img.shields.io/badge/GitHub-Actions-2088FF?style=for-the-badge&logo=githubactions&logoColor=white" alt="GitHub Actions"/>
</a>
<!-- Version Control -->

Copilot uses AI. Check for mistakes.
Comment thread README.md
<img src="https://img.shields.io/badge/Testing-Cypress-17202C?style=for-the-badge&logo=cypress&logoColor=white" alt="Cypress"/>
</a>
<a href="https://jestjs.io/" target="_blank">
<img src="https://img.shields.io/badge/Jest-Testing-FF6F61?style=for-the-badge&logo=jest&logoColor=white" alt="Jest"/>

Copilot AI Jul 4, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The label ordering for the Jest badge is inconsistent with the others. Consider using Testing-Jest to match Testing-Cypress and Testing-Pytest.

Suggested change
<img src="https://img.shields.io/badge/Jest-Testing-FF6F61?style=for-the-badge&logo=jest&logoColor=white" alt="Jest"/>
<img src="https://img.shields.io/badge/Testing-Jest-FF6F61?style=for-the-badge&logo=jest&logoColor=white" alt="Testing-Jest"/>

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request

Projects

Development

Successfully merging this pull request may close these issues.

2 participants