Update: Added K8s & Jenkins CI/CD#9
Conversation
✅ Deploy Preview for fullstack-learning-management-system canceled.
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
There was a problem hiding this comment.
Pull Request Overview
Adds new badges to the project README to surface API documentation, testing frameworks, and CI/CD integration.
- Introduces a Swagger badge in the API Docs section
- Adds Cypress, Jest, and Pytest badges under a new Testing section
- Includes a GitHub Actions badge in the Version Control section
| <a href="https://docs.github.com/en/actions" target="_blank"> | ||
| <img src="https://img.shields.io/badge/GitHub-Actions-2088FF?style=for-the-badge&logo=githubactions&logoColor=white" alt="GitHub Actions"/> | ||
| </a> |
There was a problem hiding this comment.
[nitpick] This GitHub Actions badge duplicates the existing CI/CD badge earlier in the README. Consider removing one instance or consolidating to reduce redundancy.
| <a href="https://docs.github.com/en/actions" target="_blank"> | |
| <img src="https://img.shields.io/badge/GitHub-Actions-2088FF?style=for-the-badge&logo=githubactions&logoColor=white" alt="GitHub Actions"/> | |
| </a> | |
| <!-- Removed duplicate GitHub Actions badge --> |
| <!-- Version Control --> | ||
| <a href="https://docs.github.com/en/actions" target="_blank"> | ||
| <img src="https://img.shields.io/badge/GitHub-Actions-2088FF?style=for-the-badge&logo=githubactions&logoColor=white" alt="GitHub Actions"/> | ||
| </a> |
There was a problem hiding this comment.
[nitpick] Placing the GitHub Actions badge under the Version Control section may confuse readers. It might fit better alongside other CI/CD badges in the DevOps section.
| <!-- Version Control --> | |
| <a href="https://docs.github.com/en/actions" target="_blank"> | |
| <img src="https://img.shields.io/badge/GitHub-Actions-2088FF?style=for-the-badge&logo=githubactions&logoColor=white" alt="GitHub Actions"/> | |
| </a> | |
| <!-- CI/CD --> | |
| <a href="https://docs.github.com/en/actions" target="_blank"> | |
| <img src="https://img.shields.io/badge/GitHub-Actions-2088FF?style=for-the-badge&logo=githubactions&logoColor=white" alt="GitHub Actions"/> | |
| </a> | |
| <!-- Version Control --> |
| <img src="https://img.shields.io/badge/Testing-Cypress-17202C?style=for-the-badge&logo=cypress&logoColor=white" alt="Cypress"/> | ||
| </a> | ||
| <a href="https://jestjs.io/" target="_blank"> | ||
| <img src="https://img.shields.io/badge/Jest-Testing-FF6F61?style=for-the-badge&logo=jest&logoColor=white" alt="Jest"/> |
There was a problem hiding this comment.
[nitpick] The label ordering for the Jest badge is inconsistent with the others. Consider using Testing-Jest to match Testing-Cypress and Testing-Pytest.
| <img src="https://img.shields.io/badge/Jest-Testing-FF6F61?style=for-the-badge&logo=jest&logoColor=white" alt="Jest"/> | |
| <img src="https://img.shields.io/badge/Testing-Jest-FF6F61?style=for-the-badge&logo=jest&logoColor=white" alt="Testing-Jest"/> |
Pull Request Template
Overview
This pull request implements the CI/CD pipeline for the LMS application. It includes:
Files Changed
.github/workflows/ci.yml(added full pipeline config)frontend/__tests__/package.jsonscripts.dockerignoreand adjustedDockerfilefor backend & frontendTesting
pytest -qworks for the backendnpm testandnpm run coveragefor the frontendScreenshots (if applicable)
N/A (pipeline config)
Notes to Reviewers
contextandfilepathsDeployment Notes
secrets.GITHUB_TOKENis available for GHCR pushRenderandVercelaccounts are ready for actual deployment once the placeholders are swapped with real commands