Rationalise temperature localisation

[artmg]

This is a new feature request. Previously there was some temperature conversion, but only on min / max temperatures, and not through the rest of this custom component. The little there was had to be removed (PR #46 and issue #42) as it used the deprecated temperature utility, which was about to be killed off.

We should use the current strategy tool TemperatureConverter (home assistant unit_conversion.py in util folder) to implement any temperature conversion required.

[artmg]

See also issue #12 that introduces some facts around units used for temperature.
We should also bear in mind the current (minimal) documentation in this project wiki page on Device-attributes

[rct]

See the comments in #38 and #46. I may be misunderstanding things, but the temperature conversion may not be necessary.

#46 fixed the problem where a double conversion from C to F was happening. Min/Max are now being correctly localized.

There still are a number of temperature attributes that aren't being localized correctly. If Min/Max are being localized correctly without the integration doing the conversion, than it might be that the other temperature attributes need to have their type/class/unit set correctly so that Home Assistant will handle the localization.

[artmg]

Renamed issue from Reintroduce temperature conversion. Porting diagnositics from #38

Worked previously

Temperature values that were already correctly localised into Fahrenheit:

• temperature (set point)
• current_temperature

Working now

Following recent removal of duplicate conversion, temperatures now correctly localised into Fahrenheit (temperature names followed by sample values):

• min_temp: 41
• max_temp: 86

Needing attention to make them work:

Temperature related attributes not yet being correctly localised (sample values appear to be Celsius even though system localised to Fahrenheit):

floor_temperature: 18
air_temperature: 21.5
away_temperature: 16
comfort_temperature: 20
fixed_temperature: 15
override_temperature: 20
override_duration_mins: 0
sleep_temperature: 18

Suggestion

Perhaps the types/units must be correctly identified for these. e.g. make sure Home Assistant knows they are device class == temperature and unit of measurement is 'C'

[artmg]

Whilst testing any changes to this, also test whether the warmup.set_override values need adjusting at all (see issue #39)