chore(generator): cleanup snippet metadata generation#8404
Merged
quirogas merged 2 commits intoJun 2, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request deletes multiple JSON snippet files containing API definitions and metadata for various Node.js client libraries, including asset, storage, bigquery, compute, dlp, kms, logging, monitoring, and redis. There are no review comments to assess, and I have no additional feedback to provide on these deletions.
quirogas
force-pushed
the
feat/5787-disable-snippet-metadata-cleanup
branch
from
eda52f7 to
2304a1e
Compare
quirogas
changed the title
pearigee
approved these changes
Jun 2, 2026
pearigee
left a comment
pearigee
left a comment
Contributor
There was a problem hiding this comment.
Do we also need to delete the snippet templates from the generator itself?
Contributor
Author
For posterity. Yes, and this is addressed in #8403. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup all snippet metadata JSON files.
For librarian/5787