Skip to content

chore: fix sinon versions in generator and autogen#8442

Open
feywind wants to merge 2 commits into
mainfrom
feywind-fix-sinon-again-2
Open

chore: fix sinon versions in generator and autogen#8442
feywind wants to merge 2 commits into
mainfrom
feywind-fix-sinon-again-2

Conversation

@feywind

@feywind feywind commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Replaces #8417

@feywind feywind requested a review from a team as a code owner June 4, 2026 20:55
@feywind feywind added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 4, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 4, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the sinon and @types/sinon devDependencies across numerous packages and generator templates to pinned versions 21.0.3 and 21.0.1 respectively. It also adds a 'Using TypeScript' section to several README files to document the availability of TypeScript type definitions. As there are no review comments, I have no additional feedback to provide.

@feywind feywind added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 8, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 8, 2026
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 8, 2026
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 8, 2026
@suztomo

suztomo commented Jun 8, 2026

Copy link
Copy Markdown
Member

OwlBot postprocessor failed:

Step #5: Entering post-processing for /workspace/google-cloud-node/packages/google-identity-accesscontextmanager
Step #5: Entering post-processing for /workspace/google-cloud-node/packages/google-cloud-datastream
Step #5: Entering post-processing for /workspace/google-cloud-node/packages/google-cloud-bigquery-datatransfer
Step #5: Entering post-processing for /workspace/google-cloud-node/packages/google-maps-navconnect
Step #5: Entering post-processing for /workspace/google-cloud-node/packages/google-cloud-beyondcorp-appconnectors
Step #5: Entering post-processing for /workspace/google-cloud-node/packages/google-cloud-locationfinder
Step #5: Entering post-processing for /workspace/google-cloud-node/packages/google-appengine
Step #5: Entering post-processing for /workspace/google-cloud-node/packages/google-cloud-gkeconnect-gateway
Step #5: Entering post-processing for /workspace/google-cloud-node/packages/google-cloud-dialogflow
Step #5: Entering post-processing for /workspace/google-cloud-node/packages/google-cloud-certificatemanager
Step #5: 2026-06-08 14:33:41,084 synthtool [ERROR] > Failed executing node /synthtool/synthtool/languages/node-monorepo-newprocess.js /workspace/google-cloud-node/packages/google-cloud-secretmanager:
Step #5: 
Step #5: /workspace/google-cloud-node/packages/google-cloud-secretmanager
Step #5: checking if /workspace/google-cloud-node/packages/google-cloud-secretmanager/librarian.js exists
Step #5: Running /workspace/google-cloud-node/packages/google-cloud-secretmanager/librarian.js
Step #5: node:internal/errors:865
Step #5:   const err = new Error(message);
Step #5:               ^
Step #5: 
Step #5: Error: Command failed: node /workspace/google-cloud-node/packages/google-cloud-secretmanager/librarian.js
Step #5: Error processing file /workspace/google-cloud-node/packages/google-cloud-secretmanager/src/v1/secret_manager_service_client.ts: Error: Pattern /return\sPromise\.resolve\(\);\s+}\s+}/g was not found or did not result in any changes.
Step #5:     at replaceInFile (/workspace/google-cloud-node/packages/google-cloud-secretmanager/librarian.js:29:13)
Step #5:     at /workspace/google-cloud-node/packages/google-cloud-secretmanager/librarian.js:147:5
Step #5:     at Array.forEach (<anonymous>)
Step #5:     at Object.<anonymous> (/workspace/google-cloud-node/packages/google-cloud-secretmanager/librarian.js:145:11)
Step #5:     at Module._compile (node:internal/modules/cjs/loader:1364:14)
Step #5:     at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
Step #5:     at Module.load (node:internal/modules/cjs/loader:1203:32)
Step #5:     at Module._load (node:internal/modules/cjs/loader:1019:12)
Step #5:     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
Step #5:     at node:internal/main/run_main_module:28:49
Step #5: Error processing file /workspace/google-cloud-node/packages/google-cloud-secretmanager/src/v1/secret_manager_service_client.ts: Error: Pattern /topicPathTemplate:\s+new\s+this\._gaxModule\.PathTemplate\(\s+'projects\/{project}\/topics\/{topic}',?\s*\),?\s*};/g was not found or did not result in any changes.
Step #5:     at replaceInFile (/workspace/google-cloud-node/packages/google-cloud-secretmanager/librarian.js:29:13)
Step #5:     at /workspace/google-cloud-node/packages/google-cloud-secretmanager/librarian.js:148:5
Step #5:     at Array.forEach (<anonymous>)
Step #5:     at Object.<anonymous> (/workspace/google-cloud-node/packages/google-cloud-secretmanager/librarian.js:145:11)
Step #5:     at Module._compile (node:internal/modules/cjs/loader:1364:14)
Step #5:     at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
Step #5:     at Module.load (node:internal/modules/cjs/loader:1203:32)
Step #5:     at Module._load (node:internal/modules/cjs/loader:1019:12)
Step #5:     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
Step #5:     at node:internal/main/run_main_module:28:49
Step #5: Error processing file /workspace/google-cloud-node/packages/google-cloud-secretmanager/src/v1beta2/secret_manager_service_client.ts: Error: Pattern /return\sPromise\.resolve\(\);\s+}\s+}/g was not found or did not result in any changes.
Step #5:     at replaceInFile (/workspace/google-cloud-node/packages/google-cloud-secretmanager/librarian.js:29:13)
Step #5:     at /workspace/google-cloud-node/packages/google-cloud-secretmanager/librarian.js:147:5
Step #5:     at Array.forEach (<anonymous>)
Step #5:     at Object.<anonymous> (/workspace/google-cloud-node/packages/google-cloud-secretmanager/librarian.js:145:11)
Step #5:     at Module._compile (node:internal/modules/cjs/loader:1364:14)
Step #5:     at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
Step #5:     at Module.load (node:internal/modules/cjs/loader:1203:32)
Step #5:     at Module._load (node:internal/modules/cjs/loader:1019:12)
Step #5:     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
Step #5:     at node:internal/main/run_main_module:28:49
Step #5: Error processing file /workspace/google-cloud-node/packages/google-cloud-secretmanager/src/v1beta2/secret_manager_service_client.ts: Error: Pattern /topicPathTemplate:\s+new\s+this\._gaxModule\.PathTemplate\(\s+'projects\/{project}\/topics\/{topic}',?\s*\),?\s*};/g was not found or did not result in any changes.
Step #5:     at replaceInFile (/workspace/google-cloud-node/packages/google-cloud-secretmanager/librarian.js:29:13)
Step #5:     at /workspace/google-cloud-node/packages/google-cloud-secretmanager/librarian.js:148:5
Step #5:     at Array.forEach (<anonymous>)
Step #5:     at Object.<anonymous> (/workspace/google-cloud-node/packages/google-cloud-secretmanager/librarian.js:145:11)
Step #5:     at Module._compile (node:internal/modules/cjs/loader:1364:14)
Step #5:     at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
Step #5:     at Module.load (node:internal/modules/cjs/loader:1203:32)
Step #5:     at Module._load (node:internal/modules/cjs/loader:1019:12)
Step #5:     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
Step #5:     at node:internal/main/run_main_module:28:49
Step #5: 
Step #5:     at ChildProcess.exithandler (node:child_process:422:12)
Step #5:     at ChildProcess.emit (node:events:517:28)
Step #5:     at maybeClose (node:internal/child_process:1098:16)
Step #5:     at ChildProcess._handle.onexit (node:internal/child_process:303:5) {
Step #5:   code: 1,
Step #5:   killed: false,
Step #5:   signal: null,
Step #5:   cmd: 'node /workspace/google-cloud-node/packages/google-cloud-secretmanager/librarian.js',
Step #5:   stdout: '',
Step #5:   stderr: 'Error processing file /workspace/google-cloud-node/packages/google-cloud-secretmanager/src/v1/secret_manager_service_client.ts: Error: Pattern /return\\sPromise\\.resolve\\(\\);\\s+}\\s+}/g was not found or did not result in any changes.\n' +
Step #5:     '    at replaceInFile (/workspace/google-cloud-node/packages/google-cloud-secretmanager/librarian.js:29:13)\n' +
Step #5:     '    at /workspace/google-cloud-node/packages/google-cloud-secretmanager/librarian.js:147:5\n' +
Step #5:     '    at Array.forEach (<anonymous>)\n' +
Step #5:     '    at Object.<anonymous> (/workspace/google-cloud-node/packages/google-cloud-secretmanager/librarian.js:145:11)\n' +
Step #5:     '    at Module._compile (node:internal/modules/cjs/loader:1364:14)\n' +
Step #5:     '    at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)\n' +
Step #5:     '    at Module.load (node:internal/modules/cjs/loader:1203:32)\n' +
Step #5:     '    at Module._load (node:internal/modules/cjs/loader:1019:12)\n' +
Step #5:     '    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)\n' +
Step #5:     '    at node:internal/main/run_main_module:28:49\n' +
Step #5:     "Error processing file /workspace/google-cloud-node/packages/google-cloud-secretmanager/src/v1/secret_manager_service_client.ts: Error: Pattern /topicPathTemplate:\\s+new\\s+this\\._gaxModule\\.PathTemplate\\(\\s+'projects\\/{project}\\/topics\\/{topic}',?\\s*\\),?\\s*};/g was not found or did not result in any changes.\n" +
Step #5:     '    at replaceInFile (/workspace/google-cloud-node/packages/google-cloud-secretmanager/librarian.js:29:13)\n' +
Step #5:     '    at /workspace/google-cloud-node/packages/google-cloud-secretmanager/librarian.js:148:5\n' +
Step #5:     '    at Array.forEach (<anonymous>)\n' +
Step #5:     '    at Object.<anonymous> (/workspace/google-cloud-node/packages/google-cloud-secretmanager/librarian.js:145:11)\n' +
Step #5:     '    at Module._compile (node:internal/modules/cjs/loader:1364:14)\n' +
Step #5:     '    at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)\n' +
Step #5:     '    at Module.load (node:internal/modules/cjs/loader:1203:32)\n' +
Step #5:     '    at Module._load (node:internal/modules/cjs/loader:1019:12)\n' +
Step #5:     '    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)\n' +
Step #5:     '    at node:internal/main/run_main_module:28:49\n' +
Step #5:     'Error processing file /workspace/google-cloud-node/packages/google-cloud-secretmanager/src/v1beta2/secret_manager_service_client.ts: Error: Pattern /return\\sPromise\\.resolve\\(\\);\\s+}\\s+}/g was not found or did not result in any changes.\n' +
Step #5:     '    at replaceInFile (/workspace/google-cloud-node/packages/google-cloud-secretmanager/librarian.js:29:13)\n' +
Step #5:     '    at /workspace/google-cloud-node/packages/google-cloud-secretmanager/librarian.js:147:5\n' +
Step #5:     '    at Array.forEach (<anonymous>)\n' +
Step #5:     '    at Object.<anonymous> (/workspace/google-cloud-node/packages/google-cloud-secretmanager/librarian.js:145:11)\n' +
Step #5:     '    at Module._compile (node:internal/modules/cjs/loader:1364:14)\n' +
Step #5:     '    at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)\n' +
Step #5:     '    at Module.load (node:internal/modules/cjs/loader:1203:32)\n' +
Step #5:     '    at Module._load (node:internal/modules/cjs/loader:1019:12)\n' +
Step #5:     '    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)\n' +
Step #5:     '    at node:internal/main/run_main_module:28:49\n' +
Step #5:     "Error processing file /workspace/google-cloud-node/packages/google-cloud-secretmanager/src/v1beta2/secret_manager_service_client.ts: Error: Pattern /topicPathTemplate:\\s+new\\s+this\\._gaxModule\\.PathTemplate\\(\\s+'projects\\/{project}\\/topics\\/{topic}',?\\s*\\),?\\s*};/g was not found or did not result in any changes.\n" +
Step #5:     '    at replaceInFile (/workspace/google-cloud-node/packages/google-cloud-secretmanager/librarian.js:29:13)\n' +
Step #5:     '    at /workspace/google-cloud-node/packages/google-cloud-secretmanager/librarian.js:148:5\n' +
Step #5:     '    at Array.forEach (<anonymous>)\n' +
Step #5:     '    at Object.<anonymous> (/workspace/google-cloud-node/packages/google-cloud-secretmanager/librarian.js:145:11)\n' +
Step #5:     '    at Module._compile (node:internal/modules/cjs/loader:1364:14)\n' +
Step #5:     '    at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)\n' +
Step #5:     '    at Module.load (node:internal/modules/cjs/loader:1203:32)\n' +
Step #5:     '    at Module._load (node:internal/modules/cjs/loader:1019:12)\n' +
Step #5:     '    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)\n' +
Step #5:     '    at node:internal/main/run_main_module:28:49\n'
Step #5: }
Step #5: 
Step #5: Node.js v18.20.8
Step #5: 
Step #5: Traceback (most recent call last):
Step #5:   File "<frozen runpy>", line 198, in _run_module_as_main
Step #5:   File "<frozen runpy>", line 88, in _run_code
Step #5:   File "/synthtool/synthtool/languages/node_mono_repo.py", line 689, in <module>
Step #5:     owlbot_entrypoint()
Step #5:     ~~~~~~~~~~~~~~~~~^^
Step #5:   File "/synthtool/synthtool/languages/node_mono_repo.py", line 662, in owlbot_entrypoint
Step #5:     owlbot_main(
Step #5:     ~~~~~~~~~~~^
Step #5:         dir,
Step #5:         ^^^^
Step #5:     ...<3 lines>...
Step #5:         patch_staging,
Step #5:         ^^^^^^^^^^^^^^
Step #5:     )
Step #5:     ^
Step #5:   File "/synthtool/synthtool/languages/node_mono_repo.py", line 623, in owlbot_main
Step #5:     shell.run(
Step #5:     ~~~~~~~~~^
Step #5:         [
Step #5:         ^
Step #5:     ...<3 lines>...
Step #5:         ]
Step #5:         ^
Step #5:     )
Step #5:     ^
Step #5:   File "/synthtool/synthtool/shell.py", line 39, in run
Step #5:     raise exc
Step #5:   File "/synthtool/synthtool/shell.py", line 27, in run
Step #5:     return subprocess.run(
Step #5:            ~~~~~~~~~~~~~~^
Step #5:         args,
Step #5:         ^^^^^
Step #5:     ...<4 lines>...
Step #5:         encoding="utf-8",
Step #5:         ^^^^^^^^^^^^^^^^^
Step #5:     )
Step #5:     ^
Step #5:   File "/root/.pyenv/versions/3.13.12/lib/python3.13/subprocess.py", line 577, in run
Step #5:     raise CalledProcessError(retcode, process.args,
Step #5:                              output=stdout, stderr=stderr)
Step #5: subprocess.CalledProcessError: Command '['node', '/synthtool/synthtool/languages/node-monorepo-newprocess.js', PosixPath('/workspace/google-cloud-node/packages/google-cloud-secretmanager')]' returned non-zero exit status 1.
Step #5: Entering post-processing for /workspace/google-cloud-node/packages/google-cloud-servicehealth
Step #5: Entering post-processing for /workspace/google-cloud-node/packages/google-cloud-appoptimize
Step #5: Entering post-processing for /workspace/google-cloud-node/packages/google-cloud-beyondcorp-appgateways
Step #5: Entering post-processing for /workspace/google-cloud-node/packages/google-cloud-ces
Step #5: Entering post-processing for /workspace/google-cloud-node/packages/google-cloud-redis-cluster
Step #5: Entering post-processing for /workspace/google-cloud-node/packages/google-cloud-devicestreaming
Step #5: Entering post-processing for /workspace/google-cloud-node/packages/google-cloud-databasecenter
Step #5: Entering post-processing for /workspace/google-cloud-node/packages/google-cloud-osconfig
Step #5: Entering post-processing for /workspace/google-cloud-node/packages/google-cloud-contactcenterinsights
Step #5: Entering post-processing for /workspace/google-cloud-node/packages/google-cloud-secretmanager
Finished Step #5
ERROR
ERROR: build step 5 "gcr.io/cloud-devrel-public-resources/owlbot-nodejs-mono-repo:latest@sha256:af5fe933b006a4679903d4dc8e1f11e45b46c53acef70e4fd6a4b1949fab8781" failed: step exited with non-zero status: 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants