test: align GHES fakes with bounded reads

Assisted-by: Codex (model: GPT-5, autonomous)

Author: PascalThuet

tests/test_extensions.py

@@ -9,6 +9,7 @@
 - Catalog stack (multi-catalog support)
 """
 
+import io
 import pytest
 import json
 import os
@@ -7302,10 +7303,10 @@ def test_extension_wrapper_resolves_ghes_asset_when_host_configured(tmp_path, mo
     def fake_open(url, timeout=None, extra_headers=None):
         captured.append(url)
         resp = MagicMock()
-        resp.read.return_value = json.dumps({
+        resp.read.side_effect = io.BytesIO(json.dumps({
             "assets": [{"name": "ext.zip",
                         "url": "https://ghes.example/api/v3/repos/o/r/releases/assets/7"}]
-        }).encode()
+        }).encode()).read
         yield resp
 
     monkeypatch.setattr(catalog, "_open_url", fake_open)

tests/test_presets.py

@@ -4730,9 +4730,14 @@ def test_preset_add_from_direct_api_asset_url_passes_through(self, project_dir):
         class FakeResponse:
             def __init__(self, data):
                 self._data = data
+                self._pos = 0
 
-            def read(self):
-                return self._data
+            def read(self, size=-1):
+                if size < 0:
+                    size = len(self._data) - self._pos
+                out = self._data[self._pos : self._pos + size]
+                self._pos += len(out)
+                return out
 
             def __enter__(self):
                 return self
@@ -4787,9 +4792,14 @@ def test_preset_add_from_ghes_release_url_resolves_via_api_v3(self, project_dir,
         class FakeResponse:
             def __init__(self, data):
                 self._data = data
+                self._pos = 0
 
-            def read(self):
-                return self._data
+            def read(self, size=-1):
+                if size < 0:
+                    size = len(self._data) - self._pos
+                out = self._data[self._pos : self._pos + size]
+                self._pos += len(out)
+                return out
 
             def __enter__(self):
                 return self
@@ -6111,10 +6121,10 @@ def test_preset_wrapper_resolves_ghes_asset_when_host_configured(tmp_path, monke
     def fake_open(url, timeout=None, extra_headers=None):
         captured.append(url)
         resp = MagicMock()
-        resp.read.return_value = json.dumps({
+        resp.read.side_effect = io.BytesIO(json.dumps({
             "assets": [{"name": "pack.zip",
                         "url": "https://ghes.example/api/v3/repos/o/r/releases/assets/9"}]
-        }).encode()
+        }).encode()).read
         yield resp
 
     monkeypatch.setattr(catalog, "_open_url", fake_open)

tests/test_workflows.py

@@ -5509,10 +5509,15 @@ def test_workflow_add_from_ghes_release_url_resolves_via_api_v3(self, project_di
         class FakeResponse:
             def __init__(self, data, url=None):
                 self._data = data
+                self._pos = 0
                 self._url = url or "https://ghes.example/api/v3/repos/org/repo/releases/assets/42"
 
-            def read(self):
-                return self._data
+            def read(self, size=-1):
+                if size < 0:
+                    size = len(self._data) - self._pos
+                out = self._data[self._pos : self._pos + size]
+                self._pos += len(out)
+                return out
 
             def geturl(self):
                 return self._url
@@ -5564,10 +5569,15 @@ def test_workflow_add_catalog_based_ghes_release_url_resolves_via_api_v3(self, p
         class FakeResponse:
             def __init__(self, data, url=None):
                 self._data = data
+                self._pos = 0
                 self._url = url or "https://ghes.example/api/v3/repos/org/repo/releases/assets/55"
 
-            def read(self):
-                return self._data
+            def read(self, size=-1):
+                if size < 0:
+                    size = len(self._data) - self._pos
+                out = self._data[self._pos : self._pos + size]
+                self._pos += len(out)
+                return out
 
             def geturl(self):
                 return self._url