Skip to content

Fix Copilot session state collection - #64461

Merged
pelikhan merged 15 commits into
mainfrom
copilot/fix-agentic-conversation-session-state
Oct 1, 2026
Merged

pelikhan merged 15 commits into
mainfrom
copilot/fix-agentic-conversation-session-state

Conversation

@dsyme

@dsyme dsyme commented Sep 30, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • configure AWF to persist Copilot CLI session state in a deterministic host-visible directory
  • copy the AWF-managed state into the parser's copilot-session-state logs, with a legacy $HOME fallback
  • version-gate --session-state-dir for AWF v0.25.15 and newer
  • recompile affected workflows and update compiler golden fixtures

The linked run preserved the real Copilot state under /tmp/awf-agent-session-state-*, while the summary step copied an empty host $HOME/.copilot/session-state. Without events.jsonl, the parser could not render Agentic Conversation.

Fixes #64460

Validation

  • make agent-report-progress
  • go test ./pkg/workflow -count=1
  • go test ./pkg/constants -count=1
  • bash -n actions/setup/sh/copy_copilot_session_state.sh
  • shellcheck actions/setup/sh/copy_copilot_session_state.sh
  • 300 workflows recompiled successfully; lock files are in sync

Run: https://github.com/github/gh-aw/actions/runs/36705489092

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 27.7 AIC · ⌖ 8.61 AIC · ⊞ 9.7K · ◷
Comment /souschef to run again


Branch refresh requested by PR Sous Chef run https://github.com/github/gh-aw/actions/runs/36721750745

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 10 AIC · ⌖ 8.46 AIC · ⊞ 9.2K · ◷
Comment /souschef to run again


Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 22.4 AIC · ⌖ 8.52 AIC · ⊞ 9.2K · ◷
Comment /souschef to run again


Run: https://github.com/github/gh-aw/actions/runs/36736658192

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 21.3 AIC · ⌖ 8.67 AIC · ⊞ 9.2K · ◷
Comment /souschef to run again


Run: https://github.com/github/gh-aw/actions/runs/36746690122

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 11 AIC · ⌖ 8.47 AIC · ⊞ 9.2K · ◷
Comment /souschef to run again


Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 13.9 AIC · ⌖ 8.55 AIC · ⊞ 9.5K · ◷
Comment /souschef to run again


Run: https://github.com/github/gh-aw/actions/runs/36765079107

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 11.4 AIC · ⌖ 6.87 AIC · ⊞ 9.2K · ◷
Comment /souschef to run again



Branch refresh requested by PR Sous Chef run https://github.com/github/gh-aw/actions/runs/36766302125

Generated by 👨🍳 PR Sous Chef · pi · gpt54

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 8.69 AIC · ⌖ 8.59 AIC · ⊞ 9.4K · ◷
Comment /souschef to run again


Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 17 AIC · ⌖ 8.55 AIC · ⊞ 9.7K · ◷
Comment /souschef to run again


Branch refresh requested by PR Sous Chef run https://github.com/github/gh-aw/actions/runs/36774731083

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 17.1 AIC · ⌖ 8.61 AIC · ⊞ 9.5K · ◷
Comment /souschef to run again


Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 13.8 AIC · ⌖ 6.81 AIC · ⊞ 9.7K · ◷
Comment /souschef to run again


Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 21.2 AIC · ⌖ 8.39 AIC · ⊞ 9.4K · ◷
Comment /souschef to run again


Run: https://github.com/github/gh-aw/actions/runs/36785232614

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 17.5 AIC · ⌖ 7.01 AIC · ⊞ 9.7K · ◷
Comment /souschef to run again


Branch refresh requested by PR Sous Chef run https://github.com/github/gh-aw/actions/runs/36788332137

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 27.9 AIC · ⌖ 6.88 AIC · ⊞ 9.7K · ◷
Comment /souschef to run again


Generated by PR Sous Chef run https://github.com/github/gh-aw/actions/runs/36791546296

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 11.3 AIC · ⌖ 8.4 AIC · ⊞ 9.7K · ◷
Comment /souschef to run again


Run: https://github.com/github/gh-aw/actions/runs/36799719793

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 18.2 AIC · ⌖ 9.9 AIC · ⊞ 9.2K · ◷
Comment /souschef to run again



✨ PR Review Safe Output Test - Run 36812703027

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • clients2.google.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "clients2.google.com"

See Network Configuration for more information.

💥 [THE END] — Illustrated by Smoke Claude · claude · sonnet46 · 67.6 AIC · ⌖ 17.9 AIC · ⊞ 978 · ◷
Comment /smoke-claude to run again


Branch refresh requested by PR Sous Chef run https://github.com/github/gh-aw/actions/runs/36815294059

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 38.3 AIC · ⌖ 8.93 AIC · ⊞ 9.5K · ◷
Comment /souschef to run again


Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 32.4 AIC · ⌖ 8.51 AIC · ⊞ 9.4K · ◷
Comment /souschef to run again


Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 23.3 AIC · ⌖ 8.62 AIC · ⊞ 9.2K · ◷
Comment /souschef to run again


Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 33.8 AIC · ⌖ 8.59 AIC · ⊞ 9.7K · ◷
Comment /souschef to run again


pr-sous-chef branch refresh requested in run https://github.com/github/gh-aw/actions/runs/36883904989

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 27 AIC · ⌖ 8.63 AIC · ⊞ 9.7K · ◷
Comment /souschef to run again

Configure AWF to persist Copilot session state in a deterministic host-visible directory, copy it into parser logs with a legacy fallback, and version-gate the new flag. Recompile affected workflows and update compiler goldens.

Fixes #64460

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings September 30, 2026 10:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The copy-script test does not exercise its newly introduced source-selection, fallback, or recursive-copy behavior.

Review effort: Balanced
Findings: 1 Medium severity

Open (1)
What changed in this PR

Adds deterministic, host-visible Copilot session-state persistence so structured events reach artifact parsing and the Agentic Conversation summary.

Changes:

  • Adds version-gated Copilot --session-state-dir support.
  • Copies AWF-managed state with legacy $HOME fallback.
  • Recompiles affected workflows and golden fixtures.
File Description
.github/​workflows/​agent-performance-analyzer.lock.yml Recompiled with session-state persistence.
.github/​workflows/​agent-persona-explorer.lock.yml Recompiled with session-state persistence.
.github/​workflows/​agentic-token-audit.lock.yml Recompiled with session-state persistence.
.github/​workflows/​agentic-token-optimizer.lock.yml Recompiled with session-state persistence.
.github/​workflows/​archie.lock.yml Recompiled with session-state persistence.
.github/​workflows/​architecture-guardian.lock.yml Recompiled with session-state persistence.
.github/​workflows/​breaking-change-checker.lock.yml Recompiled with session-state persistence.
.github/​workflows/​ci-coach.lock.yml Recompiled with session-state persistence.
.github/​workflows/​cli-consistency-checker.lock.yml Recompiled with session-state persistence.
.github/​workflows/​cli-version-checker.lock.yml Recompiled with session-state persistence.
.github/​workflows/​code-scanning-fixer.lock.yml Recompiled with session-state persistence.
.github/​workflows/​code-simplifier.lock.yml Recompiled with session-state persistence.
.github/​workflows/​constraint-solving-potd.lock.yml Recompiled with session-state persistence.
.github/​workflows/​contribution-check.lock.yml Recompiled with session-state persistence.
.github/​workflows/​copilot-cli-deep-research.lock.yml Recompiled with session-state persistence.
.github/​workflows/​copilot-opt.lock.yml Recompiled with session-state persistence.
.github/​workflows/​copilot-pr-merged-report.lock.yml Recompiled with session-state persistence.
.github/​workflows/​copilot-pr-nlp-analysis.lock.yml Recompiled with session-state persistence.
.github/​workflows/​copilot-pr-prompt-analysis.lock.yml Recompiled with session-state persistence.
.github/​workflows/​craft.lock.yml Recompiled with session-state persistence.
.github/​workflows/​daily-action-setup-security-audit.lock.yml Recompiled with session-state persistence.
.github/​workflows/​daily-agent-of-the-day-blog-writer.lock.yml Recompiled with session-state persistence.
.github/​workflows/​daily-ambient-context-optimizer.lock.yml Recompiled with session-state persistence.
.github/​workflows/​daily-arxiv-researcher.lock.yml Recompiled with session-state persistence.
.github/​workflows/​daily-assign-issue-to-user.lock.yml Recompiled with session-state persistence.
.github/​workflows/​daily-byok-ollama-test.lock.yml Recompiled with session-state persistence.
.github/​workflows/​daily-code-debt-aider.lock.yml Recompiled with session-state persistence.
.github/​workflows/​daily-code-metrics.lock.yml Recompiled with session-state persistence.
.github/​workflows/​daily-community-attribution.lock.yml Recompiled with session-state persistence.
.github/​workflows/​daily-compiler-quality.lock.yml Recompiled with session-state persistence.
.github/​workflows/​daily-compiler-threat-spec-optimizer.lock.yml Recompiled with session-state persistence.
.github/​workflows/​daily-credit-limit-test.lock.yml Recompiled with session-state persistence.
.github/​workflows/​daily-ecosystem-explorer.lock.yml Recompiled with session-state persistence.
.github/​workflows/​daily-experiment-report.lock.yml Recompiled with session-state persistence.
.github/​workflows/​daily-file-diet.lock.yml Recompiled with session-state persistence.
.github/​workflows/​daily-firewall-report.lock.yml Recompiled with session-state persistence.
.github/​workflows/​daily-formal-spec-verifier.lock.yml Recompiled with session-state persistence.
.github/​workflows/​daily-function-namer.lock.yml Recompiled with session-state persistence.
.github/​workflows/​daily-geo-optimizer.lock.yml Recompiled with session-state persistence.
.github/​workflows/​daily-github-docs-seo-optimizer.lock.yml Recompiled with session-state persistence.
.github/​workflows/​daily-go-test-stubs-aider.lock.yml Recompiled with session-state persistence.
.github/​workflows/​daily-graft-intelligence.lock.yml Recompiled with session-state persistence.
.github/​workflows/​daily-hippo-learn.lock.yml Recompiled with session-state persistence.
.github/​workflows/​daily-issues-report.lock.yml Recompiled with session-state persistence.
.github/​workflows/​daily-malicious-code-scan.lock.yml Recompiled with session-state persistence.
.github/​workflows/​daily-mcp-concurrency-analysis.lock.yml Recompiled with session-state persistence.
.github/​workflows/​daily-model-inventory.lock.yml Recompiled with session-state persistence.
.github/​workflows/​daily-model-resolution.lock.yml Recompiled with session-state persistence.
.github/​workflows/​daily-multi-device-docs-tester.lock.yml Recompiled with session-state persistence.
.github/​workflows/​daily-news.lock.yml Recompiled with session-state persistence.
.github/​workflows/​daily-performance-summary.lock.yml Recompiled with session-state persistence.
.github/​workflows/​daily-pr-review-cursor.lock.yml Recompiled with session-state persistence.
.github/​workflows/​daily-regression-audit-kiro.lock.yml Recompiled with session-state persistence.
.github/​workflows/​daily-reliability-review.lock.yml Recompiled with session-state persistence.
.github/​workflows/​daily-repo-chronicle.lock.yml Recompiled with session-state persistence.
.github/​workflows/​daily-safe-output-integrator.lock.yml Recompiled with session-state persistence.
.github/​workflows/​daily-schema-audit-cursor.lock.yml Recompiled with session-state persistence.
.github/​workflows/​daily-secrets-analysis.lock.yml Recompiled with session-state persistence.
.github/​workflows/​daily-security-observability.lock.yml Recompiled with session-state persistence.
.github/​workflows/​daily-security-red-team.lock.yml Recompiled with session-state persistence.
.github/​workflows/​daily-spdd-spec-planner.lock.yml Recompiled with session-state persistence.
.github/​workflows/​daily-spec-coverage-kiro.lock.yml Recompiled with session-state persistence.
.github/​workflows/​daily-squid-image-scan.lock.yml Recompiled with session-state persistence.
.github/​workflows/​daily-syntax-error-quality.lock.yml Recompiled with session-state persistence.
.github/​workflows/​daily-team-evolution-insights.lock.yml Recompiled with session-state persistence.
.github/​workflows/​daily-team-status.lock.yml Recompiled with session-state persistence.
.github/​workflows/​daily-testify-uber-super-expert.lock.yml Recompiled with session-state persistence.
.github/​workflows/​daily-token-consumption-report.lock.yml Recompiled with session-state persistence.
.github/​workflows/​daily-trajectory-grader-implementer.lock.yml Recompiled with session-state persistence.
.github/​workflows/​daily-workflow-updater.lock.yml Recompiled with session-state persistence.
.github/​workflows/​dataflow-pr-discussion-dataset.lock.yml Recompiled with session-state persistence.
.github/​workflows/​dead-code-remover.lock.yml Recompiled with session-state persistence.
.github/​workflows/​delight.lock.yml Recompiled with session-state persistence.
.github/​workflows/​dependabot-burner.lock.yml Recompiled with session-state persistence.
.github/​workflows/​deployment-incident-monitor.lock.yml Recompiled with session-state persistence.
.github/​workflows/​design-decision-gate.lock.yml Recompiled with session-state persistence.
.github/​workflows/​dev-hawk.lock.yml Recompiled with session-state persistence.
.github/​workflows/​dictation-prompt.lock.yml Recompiled with session-state persistence.
.github/​workflows/​docs-noob-tester.lock.yml Recompiled with session-state persistence.
.github/​workflows/​draft-pr-cleanup.lock.yml Recompiled with session-state persistence.
.github/​workflows/​duplicate-code-detector.lock.yml Recompiled with session-state persistence.
.github/​workflows/​eslint-miner.lock.yml Recompiled with session-state persistence.
.github/​workflows/​evoskill-evolver.lock.yml Recompiled with session-state persistence.
.github/​workflows/​firewall-escape.lock.yml Recompiled with session-state persistence.
.github/​workflows/​firewall.lock.yml Recompiled with session-state persistence.
.github/​workflows/​glossary-maintainer.lock.yml Recompiled with session-state persistence.
.github/​workflows/​impeccable-skills-reviewer.lock.yml Recompiled with session-state persistence.
.github/​workflows/​issue-monster.lock.yml Recompiled with session-state persistence.
.github/​workflows/​jsweep.lock.yml Recompiled with session-state persistence.
.github/​workflows/​layout-spec-maintainer.lock.yml Recompiled with session-state persistence.
.github/​workflows/​linter-miner.lock.yml Recompiled with session-state persistence.
.github/​workflows/​mattpocock-skills-reviewer.lock.yml Recompiled with session-state persistence.
.github/​workflows/​mcp-inspector.lock.yml Recompiled with session-state persistence.
.github/​workflows/​mergefest.lock.yml Recompiled with session-state persistence.
.github/​workflows/​necromancer.lock.yml Recompiled with session-state persistence.
.github/​workflows/​objective-impact-report.lock.yml Recompiled with session-state persistence.
.github/​workflows/​org-health-report.lock.yml Recompiled with session-state persistence.
.github/​workflows/​plan.lock.yml Recompiled with session-state persistence.
.github/​workflows/​pr-code-quality-reviewer.lock.yml Recompiled with session-state persistence.
.github/​workflows/​pr-description-caveman.lock.yml Recompiled with session-state persistence.
.github/​workflows/​pr-nitpick-reviewer.lock.yml Recompiled with session-state persistence.
.github/​workflows/​pr-sous-chef.lock.yml Recompiled with session-state persistence.
.github/​workflows/​pr-triage-agent.lock.yml Recompiled with session-state persistence.
.github/​workflows/​q.lock.yml Recompiled with session-state persistence.
.github/​workflows/​refactoring-cadence.lock.yml Recompiled with session-state persistence.
.github/​workflows/​refiner.lock.yml Recompiled with session-state persistence.
.github/​workflows/​release.lock.yml Recompiled with session-state persistence.
.github/​workflows/​repo-tree-map.lock.yml Recompiled with session-state persistence.
.github/​workflows/​repository-quality-improver.lock.yml Recompiled with session-state persistence.
.github/​workflows/​research.lock.yml Recompiled with session-state persistence.
.github/​workflows/​security-compliance.lock.yml Recompiled with session-state persistence.
.github/​workflows/​slide-deck-maintainer.lock.yml Recompiled with session-state persistence.
.github/​workflows/​smoke-aider.lock.yml Recompiled with session-state persistence.
.github/​workflows/​smoke-checkout-pr-dispatch.lock.yml Recompiled with session-state persistence.
.github/​workflows/​smoke-copilot-aoai-apikey.lock.yml Recompiled with session-state persistence.
.github/​workflows/​smoke-copilot-aoai-entra.lock.yml Recompiled with session-state persistence.
.github/​workflows/​smoke-copilot-arm.lock.yml Recompiled with session-state persistence.
.github/​workflows/​smoke-copilot-auto.lock.yml Recompiled with session-state persistence.
.github/​workflows/​smoke-copilot-mai.lock.yml Recompiled with session-state persistence.
.github/​workflows/​smoke-copilot-sdk.lock.yml Recompiled with session-state persistence.
.github/​workflows/​smoke-copilot-small.lock.yml Recompiled with session-state persistence.
.github/​workflows/​smoke-copilot-sub-agents.lock.yml Recompiled with session-state persistence.
.github/​workflows/​smoke-copilot.lock.yml Recompiled with session-state persistence.
.github/​workflows/​smoke-create-cross-repo-pr.lock.yml Recompiled with session-state persistence.
.github/​workflows/​smoke-crush.lock.yml Recompiled with session-state persistence.
.github/​workflows/​smoke-cursor.lock.yml Recompiled with session-state persistence.
.github/​workflows/​smoke-deepseek-harness.lock.yml Recompiled with session-state persistence.
.github/​workflows/​smoke-gemini.lock.yml Recompiled with session-state persistence.
.github/​workflows/​smoke-goose.lock.yml Recompiled with session-state persistence.
.github/​workflows/​smoke-issues.lock.yml Recompiled with session-state persistence.
.github/​workflows/​smoke-kiro.lock.yml Recompiled with session-state persistence.
.github/​workflows/​smoke-multi-pr.lock.yml Recompiled with session-state persistence.
.github/​workflows/​smoke-opencode.lock.yml Recompiled with session-state persistence.
.github/​workflows/​smoke-pi.lock.yml Recompiled with session-state persistence.
.github/​workflows/​smoke-project.lock.yml Recompiled with session-state persistence.
.github/​workflows/​smoke-pydantic.lock.yml Recompiled with session-state persistence.
.github/​workflows/​smoke-repo-memory-ledger.lock.yml Recompiled with session-state persistence.
.github/​workflows/​smoke-service-ports.lock.yml Recompiled with session-state persistence.
.github/​workflows/​smoke-temporary-id.lock.yml Recompiled with session-state persistence.
.github/​workflows/​smoke-test-tools.lock.yml Recompiled with session-state persistence.
.github/​workflows/​smoke-update-cross-repo-pr.lock.yml Recompiled with session-state persistence.
.github/​workflows/​smoke-workflow-call-with-inputs.lock.yml Recompiled with session-state persistence.
.github/​workflows/​spec-extractor.lock.yml Recompiled with session-state persistence.
.github/​workflows/​spec-librarian.lock.yml Recompiled with session-state persistence.
.github/​workflows/​squad-game-planner.lock.yml Recompiled with session-state persistence.
.github/​workflows/​squad-implement-worker.lock.yml Recompiled with session-state persistence.
.github/​workflows/​squad-plan.lock.yml Recompiled with session-state persistence.
.github/​workflows/​squad.lock.yml Recompiled with session-state persistence.
.github/​workflows/​stale-pr-cleanup.lock.yml Recompiled with session-state persistence.
.github/​workflows/​stale-repo-identifier.lock.yml Recompiled with session-state persistence.
.github/​workflows/​sub-issue-closer.lock.yml Recompiled with session-state persistence.
.github/​workflows/​super-linter.lock.yml Recompiled with session-state persistence.
.github/​workflows/​technical-doc-writer.lock.yml Recompiled with session-state persistence.
.github/​workflows/​terminal-stylist.lock.yml Recompiled with session-state persistence.
.github/​workflows/​test-quality-sentinel.lock.yml Recompiled with session-state persistence.
.github/​workflows/​tidy.lock.yml Recompiled with session-state persistence.
.github/​workflows/​ubuntu-image-analyzer.lock.yml Recompiled with session-state persistence.
.github/​workflows/​uk-ai-operational-resilience.lock.yml Recompiled with session-state persistence.
.github/​workflows/​unbloat-docs.lock.yml Recompiled with session-state persistence.
.github/​workflows/​video-analyzer.lock.yml Recompiled with session-state persistence.
.github/​workflows/​visual-regression-checker.lock.yml Recompiled with session-state persistence.
.github/​workflows/​weekly-blog-post-writer.lock.yml Recompiled with session-state persistence.
.github/​workflows/​weekly-editors-health-check.lock.yml Recompiled with session-state persistence.
.github/​workflows/​weekly-issue-summary.lock.yml Recompiled with session-state persistence.
.github/​workflows/​weekly-network-domains-audit.lock.yml Recompiled with session-state persistence.
.github/​workflows/​weekly-safe-outputs-spec-review.lock.yml Recompiled with session-state persistence.
.github/​workflows/​workflow-generator.lock.yml Recompiled with session-state persistence.
.github/​workflows/​workflow-health-manager.lock.yml Recompiled with session-state persistence.
.github/​workflows/​workflow-skill-extractor.lock.yml Recompiled with session-state persistence.
actions/​setup/​sh/​copy_copilot_session_state.sh Prefers AWF-managed state and retains legacy fallback.
pkg/​constants/​spec_test.go Verifies the minimum AWF version constant.
pkg/​constants/​version_constants.go Defines AWF v0.25.15 as the feature minimum.
pkg/​workflow/​awf_command_builder.go Adds the gated Copilot AWF argument.
pkg/​workflow/​awf_command_builder_test.go Covers argument emission by engine and version.
pkg/​workflow/​awf_feature_flags.go Adds session-state capability detection.
pkg/​workflow/​awf_feature_flags_test.go Tests feature-version boundaries.
pkg/​workflow/​copilot_engine_execution.go Updates session-copy documentation.
pkg/​workflow/​copilot_session_copy_test.go Adds static checks for copy-script paths.
pkg/​workflow/​testdata/​TestWasmGolden_AllEngines/​copilot.golden Updates generated Copilot output.
pkg/​workflow/​testdata/​TestWasmGolden_CompileFixtures/​basic-copilot.golden Updates basic Copilot output.
pkg/​workflow/​testdata/​TestWasmGolden_CompileFixtures/​playwright-cli-mode.golden Updates Playwright Copilot output.
pkg/​workflow/​testdata/​TestWasmGolden_CompileFixtures/​with-imports.golden Updates imported-workflow output.

Comment thread pkg/workflow/copilot_session_copy_test.go Outdated
@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot This PR still needs forward progress: please address the outstanding review feedback at #64461 (comment), refresh the branch if needed, and then run the pr-finisher skill.

Generated by 👨🍳 PR Sous Chef

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 27.7 AIC · ⌖ 8.61 AIC · ⊞ 9.7K · ◷
Comment /souschef to run again

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot This PR still needs forward progress: please address the outstanding review feedback from Copilot at #64461 (comment), refresh the branch if needed, and then run the pr-finisher skill.

Generated by 👨🍳 PR Sous Chef

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 9.63 AIC · ⌖ 8.6 AIC · ⊞ 9.4K · ◷
Comment /souschef to run again

Copilot AI commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

@copilot This PR still needs forward progress: please address the outstanding review feedback at #64461 (comment), refresh the branch if needed, and th...

Addressed the linked review feedback and ran the PR-finisher checks. The changes are committed and pushed as d4adfe0; local formatting, lint, tests, and workflow recompilation passed.

Copilot AI commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

@copilot This PR still needs forward progress: please address the outstanding review feedback from Copilot at #64461 (comment), refresh the branch if n...

This request was completed in d4adfe0: I added script-execution coverage for AWF precedence, legacy fallback, recursive copying, and empty sources. The linked review thread is resolved, and I reran the PR-finisher checks on the current commit; all passed.

@pelikhan

Copy link
Copy Markdown
Collaborator

@copilot

  • use a folder under /tmp/gh-aw/ so that it gets secret redaction
  • review and configure all other agentic engines

Copilot AI and others added 2 commits September 30, 2026 13:26
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

@copilot

  • use a folder under /tmp/gh-aw/ so that it gets secret redaction...

Updated in 5e03b59 (with refreshed compiler goldens in 95d5292). Claude, Gemini, Aider, Crush, Cursor, DeepSeek Harness, GenAIScript, Kiro, and OpenCode now route supported state/history paths under /tmp/gh-aw/; Codex/Copilot were already there, Pi and Goose disable persistent sessions. Cursor plugin staging follows its isolated HOME. Pydantic AI remains upstream-managed and depends on $HOME/.local for its installed runtime; I found no persistent conversation file path to relocate. The redactor scans supported text formats under /tmp/gh-aw/, not SQLite databases. Workflow package tests and impacted tests pass; final repo validation is blocked by three existing custom-linter findings in unchanged Claude code, and CodeQL timed out.

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot This PR still needs forward progress: please address the outstanding review feedback, refresh the branch if needed, and then run the pr-finisher skill.

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 21.3 AIC · ⌖ 8.67 AIC · ⊞ 9.2K · ◷
Comment /souschef to run again

…onversation-session-state

# Conflicts:
#	.github/workflows/daily-arxiv-researcher.lock.yml

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot AI commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

@copilot This PR still needs forward progress: please address the outstanding review feedback, refresh the branch if needed, and then run the pr-finisher skill.

Generated by [👨‍🍳 PR Sous Ch...

Refreshed the branch from origin/main, regenerated the conflicted workflow lock, and updated the WASM golden; the merge is published as f2ae794. PR-finisher checks completed: the full make test, lint, impacted unit tests, and workflow recompile pass. make agent-report-progress still fails on an unchanged ESLint README-parity test inherited from main; CodeQL timed out. CI on this new commit needs a maintainer re-trigger.

@pelikhan

Copy link
Copy Markdown
Collaborator

@copilot create a shared agentic workflow that injects post agent steps that ensures the session file is available and fail tbe run i not. Inject in many argentic workflows using different sandbox runtimes as a sanity check.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Thanks for the fix, @dsyme! 👋 The Copilot session state collection change is well described and validated. Per CONTRIBUTING.md, non-core members should file issues rather than open PRs; if you are on the core team, please disregard.

Generated by ✅ Contribution Check · copilot · auto · 40.5 AIC · ⌖ 9.28 AIC · ⊞ 9.1K · ◷

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot this PR still needs forward progress before a maintainer can investigate efficiently.

Please address the outstanding review feedback, then run the pr-finisher skill.

Outstanding review feedback

A branch refresh was also requested by PR Sous Chef in this run.

Generated by 👨🍳 PR Sous Chef

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 32.4 AIC · ⌖ 8.51 AIC · ⊞ 9.4K · ◷
Comment /souschef to run again

Copilot AI commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

@copilot this PR still needs forward progress before a maintainer can investigate efficiently.

Please address the outstanding review feedback, then run the pr-finisher skill....

I checked the current PR review-thread data, but it does not include the three linked discussions (4151755483, 4151755485, or 4151755489); fetching their permalinks also failed. The visible review feedback has already been addressed and replied to in 2d9b179. Please repost the missing review text or ensure those threads are available so I can assess them. The PR base is current with main, so no branch refresh is needed.

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

pr-sous-chef
@copilot this PR still needs forward progress before a maintainer can investigate efficiently.

Please address the outstanding review feedback, refresh the branch if needed, then run the pr-finisher skill.

Outstanding review threads:

A branch refresh was also requested by PR Sous Chef in this run.

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 23.3 AIC · ⌖ 8.62 AIC · ⊞ 9.2K · ◷
Comment /souschef to run again

Copilot AI commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

pr-sous-chef
@copilot this PR still needs forward progress before a maintainer can investigate efficiently.
...

I repeated the PR review-thread query and it still returns only 13 threads; none contains comments 4151755483, 4151755485, or 4151755489. The linked pages and direct API requests are unavailable here, so their feedback text cannot be reviewed or safely acted on. The current PR metadata shows main at 55f35d4, which is already included in this branch. Please make those comment bodies visible or paste their text so I can address them.

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

pr-sous-chef
@copilot this PR still needs forward progress before a maintainer can investigate efficiently.

Please address the remaining unresolved review thread below, refresh the branch if needed, then run the pr-finisher skill.

Outstanding review feedback

A branch refresh was also requested by PR Sous Chef in this run.

Generated by 👨🍳 PR Sous Chef

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 33.8 AIC · ⌖ 8.59 AIC · ⊞ 9.7K · ◷
Comment /souschef to run again

Copilot AI commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

pr-sous-chef
@copilot this PR still needs forward progress before a maintainer can investigate efficiently.
...

The specifically cited review thread (4143794762) is already resolved. Its request for execution-based tests was addressed in d4adfe0; the current head includes those tests. No branch refresh is needed: this PR's base is main at 55f35d4, and that commit is included in the branch. The later 2d9b179 follow-up also kept this fix Copilot-specific and limited copied artifacts to redactor-supported formats, addressing the scope and redaction concerns. PR-finisher review data still shows other already-answered, outdated threads as unresolved, but I don't have a thread-resolution operation available here; the latest workflow run is also still in progress. So I can't mark Reviews/CI as merge-ready from this pass.

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot please move this PR toward maintainer review: address any remaining feedback, refresh the branch if useful, and run the pr-finisher skill before handing back.

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 25.3 AIC · ⌖ 8.76 AIC · ⊞ 9.4K · ◷
Comment /souschef to run again

Copilot AI commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

@copilot please move this PR toward maintainer review: address any remaining feedback, refresh the branch if useful, and run the pr-finisher skill before handing back.

Generated by [👨‍🍳 P...

Ran the pr-finisher checks; no code changes were needed. The Copilot session-state fix remains Copilot-only, and copied files are restricted to redactor-supported formats. make fmt, make lint, make test-unit, make test, and make recompile all passed, and the branch contains the current main tip (55f35d4). The open review concerns already have substantive replies, but this interface does not support resolving review threads. PR CI for the current SHA is marked action_required; the prior Smoke Gemini failure was Execute Gemini CLI on older SHA e4da7f0, not the artifact assertion, and no failed jobs were found in the later Sous Chef run. The PR still reports merge state blocked, so maintainer review/thread resolution and CI approval or re-trigger are still needed.

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

pr-sous-chef
@copilot this PR still needs forward progress before a maintainer can investigate efficiently.

  • Please run the pr-finisher skill on this branch.
  • If there are unresolved review comments or failing checks, address them in the same pass and report what changed.
  • If the branch is stale versus base, refresh it as part of that work.

Generated by 👨🍳 PR Sous Chef

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 21.7 AIC · ⌖ 8.68 AIC · ⊞ 9.7K · ◷
Comment /souschef to run again

Copilot AI commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

pr-sous-chef
@copilot this PR still needs forward progress before a maintainer can investigate efficiently.
...

I reran PR-finisher triage. No new actionable review feedback or code change was found; the previously raised Copilot scope and artifact-redaction concerns are addressed in 2d9b179. The working tree is clean, and the branch contains the reported main tip (55f35d4). Local make fmt, make lint, make test-unit, make test, and make recompile passed on this SHA in the previous finisher pass. Current checks show the Copilot agent check still in progress; earlier Copilot agent checks passed. PR CI checks remain action_required, and the PR remains blocked. Existing addressed threads remain unresolved, and this interface still does not provide a thread-resolution action. No files were changed.

@pelikhan

pelikhan commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator

@copilot review changes and suggest a list of AW to run to validate. Add runtime check steps in these aw to canary check file correct present.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

@copilot review changes and suggest a list of AW to run to validate. Add runtime check steps in these aw to canary check file correct present.

Reviewed the Copilot session-state change: it remains Copilot-only, copies only redactor-supported files, and has execution tests for source precedence/fallback and filtering. Commit 8a4cef6 adds the shared post-run assertion for a non-empty events.jsonl to the remaining Copilot CLI smoke workflows: Auto, AOAI API-key, AOAI Entra, ARM64, and MAI. Main Smoke Copilot and Smoke Copilot Small already had it. The runtime assertion was exercised locally for both missing and present events.

Recommended canary order: Smoke Copilot Auto (default CLI path), Smoke Copilot Small (alternate model), Smoke Copilot AOAI Entra (alternate auth), then Smoke Copilot ARM64. To cover every CLI variant with an assertion, also run Smoke Copilot AOAI API-key and Smoke Copilot MAI. I excluded Copilot SDK and SDK sub-agent workflows because they use a separate SDK execution path.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@pelikhan

pelikhan commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator

/smoke-copilot

@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

📰 BREAKING: Smoke Copilot is now investigating this issue comment. Sources say the story is developing...

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Smoke Copilot: build ✅, PR query ✅, Serena/Playwright/curl/file ❌ (bash denied), rest not run. Overall: FAIL. cc @dsyme @Copilot

📰 BREAKING: Report filed by Smoke Copilot · copilot · auto · 13.2 AIC · ⌖ 3.02 AIC · ⊞ 9.7K · ◷
Comment /smoke-copilot to run again
Add label smoke to run again

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

pr-sous-chef
@copilot this PR still needs forward progress before a maintainer can investigate efficiently.

Please address the outstanding review feedback, branch refresh, and then run the pr-finisher skill.

Outstanding review feedback

A branch refresh was also requested by PR Sous Chef in this run.

Generated by 👨🍳 PR Sous Chef

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 27 AIC · ⌖ 8.63 AIC · ⊞ 9.7K · ◷
Comment /souschef to run again

Copilot AI commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

pr-sous-chef
@copilot this PR still needs forward progress before a maintainer can investigate efficiently.
...

PR-finisher pass complete: the branch already includes current main at 631b36d; make fmt, make lint, make test-unit, make test, and make recompile all pass, with a clean worktree. The requested GitHub Actions review 5372010303 is not returned by the available PR review endpoints, and its permalink cannot be fetched here. All visible unresolved review threads already have substantive Copilot replies, but this interface has no review-thread resolve operation. Current-head CI has passing completed jobs and Windows/Go-lint jobs still running; Smoke Copilot's non-empty events assertion passed, while safe-output issue-type handling failed for lack of issue context.

/smoke-copilot

Smoke Copilot ran on HEAD 2252513. The session-artifact assertion passed and found a non-empty copilot-session-state/.../events.jsonl. The run later concluded failure in safe_outputs: set_issue_type was skipped because this workflow_dispatch run was not in issue context; the agent job itself succeeded.

@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v0.90.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Copilot Agentic Conversation missing when AWF preserves session state outside host HOME

5 participants