Skip to content

[Bug]: editor shortcuts still reach the timeline while the Export modal is open #434

Description

@EtienneLescot

Describe the bug

Editor shortcuts still reach the timeline while the Export modal is open. With the modal up, pressing Z, T and C created three regions in the project behind it:

Key Region created
T trim — 0:01.9
Z zoom — 1.80×
C Full Camera segment

This is what 65aa74ef ("stop editor shortcuts reaching the timeline under a modal") is meant to prevent.

The guard exists and works — it just is not applied to this modal

The Keyboard Shortcuts modal blocks correctly. Tested on a fresh playhead position, because a first attempt was confounded by a zoom region already sitting where the playhead was:

State Press Z at an unused playhead position Result
Keyboard Shortcuts modal open yes no region created
Same modal closed yes region created immediately

So the blocking path and the focus restoration on close both behave. The Export modal is simply not wired into the same guard.

Why it is worth fixing before release

It compounds with #433 (undo/redo are inert): a user who brushes Z, T or C while configuring an export gets stray regions in their timeline and cannot undo them.

Expected behavior

While any modal is open, editor shortcuts do not mutate the timeline.

To Reproduce

  1. Record anything and let the editor open.
  2. Click Export to open the export modal.
  3. Press Z, then T, then C.
  4. Close the modal — three new regions are on the timeline at the playhead.

Environment

  • OS: Windows 11 (26200)
  • Build: packaged Openscreen.exe 1.9.6, built from main @ 95e350e0 via npm run build:win

Found during a computer-use pass over technical-documentation/testing/manual-e2e-checklist.md.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingstatus: fixed in mainWork is merged into main but may not be in a downloadable release yet.status: pending releaseMerged change is waiting for a packaged desktop release.

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions