test(wallet): Tier-2 browser-signing e2e (Playwright + mock provider on anvil)

[MuncleUscles]

What

Adds the Tier-2 browser-wallet signing e2e harness for genlayer-cli, per the design doc. It drives the real daemon bridge page (src/lib/wallet/bridgePage.ts) in a headless chromium with an injected mock window.ethereum, and delegates signing to Node via page.exposeFunction("__glSign", …) where a viem local account (anvil dev key) actually signs + broadcasts eth_sendTransaction to an ephemeral anvil, returning a real tx hash.

So the full loop runs for real — bridge + served page JS + session daemon + real chain — with zero human and zero MetaMask.

How the mock works

• e2e/fixtures/mockProvider.ts — installMockProvider({address, chainIdHex, behavior}) returns an init-script string installed via page.addInitScript(...) before page.goto() (beats the injection race). Behaviors: approve | reject (4001) | wrong-network (4901). eth_sendTransaction → window.__glSign.
• e2e/helpers/bridgePage.ts — launches chromium, wires __glSign to a viem sendTransaction on anvil, injects the mock, and drives connect.
• e2e/fixtures/chain.ts — startAnvil() boots anvil on a random port and deploys the recording StakingStub.
• e2e/fixtures/cli.ts — runs dist/index.js under a scratch HOME with a seeded custom-network config (chain-id / rpc / staking → the anvil + stub) so ensureChain() matches; spawnConnect() scrapes the printed session URL.

Lanes (all green on anvil, ~16s, serial workers:1)

• S1 connect/status/disconnect — descriptor 0600 {pid live, port, token, address, chainId}, /api/ping 200, "Connected as …", teardown removes descriptor + pid.
• S2 staking validator-join --wallet browser — page auto-signs → asserted via a real receipt + on-chain stub callCount.
• S4 session reuse — two sequential joins over one daemon/tab, distinct hashes, same pid.
• S5 config default walletMode=browser — bare validator-join signs via session; --wallet keystore overrides (keystore path, no enqueue).
• S6 user-reject (4001 → "Transaction rejected in wallet", session survives) + tab-closed (page.close() → stale heartbeat → fail-fast "tab appears to be closed"). Short GENLAYER_E2E_* timeout overrides keep these in seconds.

Staking stub

e2e/fixtures/StakingStub.sol (+ committed compiled StakingStub.json) is a ~10-line recording stub: validatorJoin() / validatorJoin(address) are payable, record the call (callCount, lastOperator/Validator/Amount), and emit the ValidatorJoin(operator, validator, amount) event the CLI decodes. It proves the sign→broadcast→receipt loop only — no consensus.

Deferred (nightly follow-up)

• Lane B (S3) — IC deploy on Docker localnet: describe.skip, guarded by GENLAYER_E2E_LOCALNET, documented in e2e/lane-b-deploy.e2e.ts. Bare anvil has no GenVM/consensus.
• Tier 3 (Synpress / real MetaMask) — out of scope.

Prod-safe support changes

• sessionConstants.ts — GENLAYER_E2E_{LONG_POLL,HEARTBEAT_DEAD,CONNECT_TIMEOUT}_MS overrides; unset/invalid → production defaults unchanged.
• browserBridge.ts — skip openUrl when GENLAYER_E2E_NO_OPEN is set (harness drives its own chromium); production unaffected.

CI

New .github/workflows/e2e-wallet.yml (distinct name from the synced e2e.yml): ubuntu + node 20 → npm ci → build → foundry-toolchain → playwright install --with-deps chromium → npm run test:e2e. Informational — keep off required checks until stable, then promote.

How to run

npm run build            # specs spawn dist/index.js
npx playwright install chromium
npm run test:e2e

Verification

• npm run test:e2e → 9 passed, 1 skipped (Lane B), stable across 3 runs.
• npm run test:coverage (Tier-1 vitest) → 733 passed; Playwright specs excluded from the vitest glob.
• npm run build clean; tsc --noEmit = 32 errors (pre-existing baseline, zero new).

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 31e970ee-5801-430d-8c8d-58cc5c61255f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/cli-wallet-e2e

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}