test(wallet): cover WalletAction status/disconnect + availableToStake#379
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes concrete unit-test gaps on the browser-wallet surface (follow-up to #367).
What's added
tests/actions/walletStatusDisconnect.test.ts(10 tests) — mirrors the mocking style ofwalletConnect.test.ts(mockedsessionDescriptor+WalletSessionClient), fully hermetic.WalletAction.status: no descriptor →No active wallet session.+ exit 1; live connected → prints the status object (address/network/chainId/port/url/heartbeat/queuedTransactions) + exit 0; live-but-connecting →connecting+ exit 1; stale tab heartbeat → reportsstale(still exit 0); stale descriptor via dead pid and via failed ping → warn +removeDescriptor+ exit 1 (state never read).WalletAction.disconnect: no descriptor → message, no throw, no client; live daemon clean exit →shutdown()+removeDescriptor+ no SIGTERM; pid lingers → SIGTERM fallback then cleanup; racing exit (waitForPidGone false but pid already gone) → no SIGTERM, still cleans up.process.killspied so no real signal is sent.tests/libs/availableToStake.test.ts(4 tests) — direct coverage ofvestingAvailableToStake: revoked →0nwithgetBalancenever called; not-revoked → returnsgetBalance({address})asserted against the vesting address; zero-balance passthrough; failing read propagates (no silent 0).Scope
Primary deliverables A/B/C only. No Tier-1 D item added: the E2E design's Tier-1 candidates (resolver chain-mismatch/degrade/error modes,
sessionClient.waitForTxResulttimeout/tab-closed fail-fast, config-defaultresolveWalletMode) are already covered by existingsessionResolver/sessionClient/walletSessionspecs; the bridge result-store GC is a private method reachable only by driving the full HTTP loop, not a cheap standalone unit spec.Verification
npm run buildclean.npx vitest runfull suite green: 72 files, 747 tests passed (+14 from this PR).tsc --noEmitbaseline unchanged (32 pre-existing SDK-typing errors; zero in the new files).